MGMT-21018: Add hive pause annotation to ClusterDeployment #238
Conversation
For Hypershift, the ClusterDeployment should have a Hive paused annotation so that Hive doesn't reconcile it. There have been instances where Hive reconciles the ClusterDeployment created for an HCP cluster and it causes unintended consequences.
|
@CrystalChun: This pull request references MGMT-21018 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the sub-task to target the "4.20.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci-robot
added
the
jira/valid-reference
openshift-ci
bot
added
the
size/M
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: CrystalChun The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/retest |
| @@ -137,6 +138,12 @@ func (r *AgentClusterReconciler) Reconcile(ctx context.Context, req ctrl.Request | |||
| return ctrl.Result{}, err | |||
| } | |||
|
|
|||
| err = r.ensureClusterDeploymentAnnotations(ctx, clusterDeployment) | |||
There was a problem hiding this comment.
I can't tell from the context, but we need to make sure that this is conditional based on the type of cluster. You do want hive to reconcile non-HCP clusters!
There was a problem hiding this comment.
Thanks for pointing that out, Eric! The reconcile prior to this line only acts on ClusterDeployments created by or referenced by the AgentCluster CR, which is used only with HCP clusters.
|
@CrystalChun: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/cc @gamli75 |
For Hypershift, the ClusterDeployment should have a Hive paused annotation so that Hive doesn't reconcile it.
There have been instances where Hive reconciles the ClusterDeployment created for an HCP cluster and it causes unintended consequences.