-
Notifications
You must be signed in to change notification settings - Fork 47
OCPBUGS-59243,OCPBUGS-59244: UPSTREAM: 5590: Bump golog v1.2.5 #557
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
/assign @JoelSpeed |
|
@damdo: This pull request explicitly references no jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
Would it not be appropriate to link this up to a CVE bug? /lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JoelSpeed The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@JoelSpeed this is not fixing a bug. It is just bumping a non-buggy version to the latest version. |
|
But you'll need a bug chain to be able to update 4.19 right? |
|
I was thinking to use NO-JIRA also on 4.19, but that might not work for older branches 🤔 |
|
@damdo: This pull request references Jira Issue OCPBUGS-59243, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
Requesting review from QA contact: The bug has been updated to refer to the pull request using the external bug tracker. This pull request references Jira Issue OCPBUGS-59244, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
Requesting review from QA contact: The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/lgtm |
|
Security issues are unrelated. /override ci/prow/security |
|
@damdo: Overrode contexts on behalf of damdo: ci/prow/security In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/retest-required |
|
/test e2e-aws-capi-techpreview |
|
/test e2e-aws-ovn-techpreview |
|
/retest |
|
/retest-required |
1 similar comment
|
/retest-required |
|
/test e2e-aws-capi-techpreview e2e-aws-ovn-techpreview |
|
/override ci/prow/e2e-aws-capi-techpreview |
|
@damdo: Overrode contexts on behalf of damdo: ci/prow/e2e-aws-capi-techpreview In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@damdo: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/override ci/prow/e2e-aws-serial-2of2 |
|
@damdo: Overrode contexts on behalf of damdo: ci/prow/e2e-aws-serial-2of2 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
18b2069
into
openshift:main
|
@damdo: Jira Issue OCPBUGS-59243: Some pull requests linked via external trackers have merged: The following pull requests linked via external trackers have not merged: These pull request must merge or be unlinked from the Jira bug in order for it to move to the next state. Once unlinked, request a bug refresh with Jira Issue OCPBUGS-59243 has not been moved to the MODIFIED state. Jira Issue OCPBUGS-59244: Some pull requests linked via external trackers have merged: The following pull requests linked via external trackers have not merged: These pull request must merge or be unlinked from the Jira bug in order for it to move to the next state. Once unlinked, request a bug refresh with Jira Issue OCPBUGS-59244 has not been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[ART PR BUILD NOTIFIER] Distgit: ose-aws-cluster-api-controllers |
Carry kubernetes-sigs#5590 until it is merged and released.