Skip to content

Conversation

@damdo
Copy link
Member

@damdo damdo commented Jul 11, 2025

Carry kubernetes-sigs#5590 until it is merged and released.

@damdo
Copy link
Member Author

damdo commented Jul 11, 2025

/assign @JoelSpeed

@damdo damdo changed the title UPSTREAM: 5590: Bump golog v1.2.5 NO-JIRA: UPSTREAM: 5590: Bump golog v1.2.5 Jul 11, 2025
@openshift-ci-robot
Copy link

@damdo: This pull request explicitly references no jira issue.

In response to this:

Carry kubernetes-sigs#5590 until it is merged and released.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jul 11, 2025
@openshift-ci openshift-ci bot requested review from JoelSpeed and elmiko July 11, 2025 12:42
@JoelSpeed
Copy link

Would it not be appropriate to link this up to a CVE bug?

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 11, 2025
@openshift-ci
Copy link

openshift-ci bot commented Jul 11, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JoelSpeed

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 11, 2025
@damdo
Copy link
Member Author

damdo commented Jul 11, 2025

@JoelSpeed this is not fixing a bug. It is just bumping a non-buggy version to the latest version.
I don't think linking up would be appropriate

@JoelSpeed
Copy link

But you'll need a bug chain to be able to update 4.19 right?

@damdo
Copy link
Member Author

damdo commented Jul 11, 2025

I was thinking to use NO-JIRA also on 4.19, but that might not work for older branches 🤔
Ok I'll create the extra bugs for 4.20

@damdo damdo changed the title NO-JIRA: UPSTREAM: 5590: Bump golog v1.2.5 OCPBUGS-59243,OCPBUGS-59244: UPSTREAM: 5590: Bump golog v1.2.5 Jul 11, 2025
@openshift-ci-robot openshift-ci-robot added jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Jul 11, 2025
@openshift-ci-robot
Copy link

@damdo: This pull request references Jira Issue OCPBUGS-59243, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.20.0) matches configured target version for branch (4.20.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @xiaojiey

The bug has been updated to refer to the pull request using the external bug tracker.

This pull request references Jira Issue OCPBUGS-59244, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.20.0) matches configured target version for branch (4.20.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @xiaojiey

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Carry kubernetes-sigs#5590 until it is merged and released.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested a review from xiaojiey July 11, 2025 12:53
@damdo damdo force-pushed the bump-golog-v1.2.5 branch from beeef27 to ec5e6a9 Compare July 11, 2025 12:57
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jul 11, 2025
@JoelSpeed
Copy link

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 11, 2025
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD de68d01 and 2 for PR HEAD ec5e6a9 in total

@damdo
Copy link
Member Author

damdo commented Jul 11, 2025

Security issues are unrelated.

/override ci/prow/security

@openshift-ci
Copy link

openshift-ci bot commented Jul 11, 2025

@damdo: Overrode contexts on behalf of damdo: ci/prow/security

In response to this:

Security issues are unrelated.

/override ci/prow/security

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD de68d01 and 2 for PR HEAD ec5e6a9 in total

@damdo
Copy link
Member Author

damdo commented Jul 14, 2025

/retest-required

@damdo
Copy link
Member Author

damdo commented Jul 14, 2025

/test e2e-aws-capi-techpreview

@damdo
Copy link
Member Author

damdo commented Jul 14, 2025

/test e2e-aws-ovn-techpreview

@damdo
Copy link
Member Author

damdo commented Jul 14, 2025

/retest

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD de68d01 and 2 for PR HEAD ec5e6a9 in total

@damdo
Copy link
Member Author

damdo commented Jul 15, 2025

/retest-required

1 similar comment
@damdo
Copy link
Member Author

damdo commented Jul 15, 2025

/retest-required

@damdo
Copy link
Member Author

damdo commented Jul 15, 2025

/test e2e-aws-capi-techpreview e2e-aws-ovn-techpreview

@damdo
Copy link
Member Author

damdo commented Jul 15, 2025

e2e-aws-capi-techpreview passed but failed on deprovision because of rate limits that are affecting AWS CI.

/override ci/prow/e2e-aws-capi-techpreview

@openshift-ci
Copy link

openshift-ci bot commented Jul 15, 2025

@damdo: Overrode contexts on behalf of damdo: ci/prow/e2e-aws-capi-techpreview

In response to this:

e2e-aws-capi-techpreview passed but failed on deprovision because of rate limits that are affecting AWS CI.

/override ci/prow/e2e-aws-capi-techpreview

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD de68d01 and 2 for PR HEAD ec5e6a9 in total

@openshift-ci
Copy link

openshift-ci bot commented Jul 15, 2025

@damdo: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/regression-clusterinfra-aws-ipi-techpreview-capi ec5e6a9 link false /test regression-clusterinfra-aws-ipi-techpreview-capi
ci/prow/okd-scos-e2e-aws-ovn ec5e6a9 link false /test okd-scos-e2e-aws-ovn

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@damdo
Copy link
Member Author

damdo commented Jul 16, 2025

ci/prow/e2e-aws-serial-2of2 passed but failed on deprovision due to rate limiting

/override ci/prow/e2e-aws-serial-2of2

@openshift-ci
Copy link

openshift-ci bot commented Jul 16, 2025

@damdo: Overrode contexts on behalf of damdo: ci/prow/e2e-aws-serial-2of2

In response to this:

ci/prow/e2e-aws-serial-2of2 passed but failed on deprovision due to rate limiting

/override ci/prow/e2e-aws-serial-2of2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-merge-bot openshift-merge-bot bot merged commit 18b2069 into openshift:main Jul 16, 2025
13 of 15 checks passed
@openshift-ci-robot
Copy link

@damdo: Jira Issue OCPBUGS-59243: Some pull requests linked via external trackers have merged:

The following pull requests linked via external trackers have not merged:

These pull request must merge or be unlinked from the Jira bug in order for it to move to the next state. Once unlinked, request a bug refresh with /jira refresh.

Jira Issue OCPBUGS-59243 has not been moved to the MODIFIED state.

Jira Issue OCPBUGS-59244: Some pull requests linked via external trackers have merged:

The following pull requests linked via external trackers have not merged:

These pull request must merge or be unlinked from the Jira bug in order for it to move to the next state. Once unlinked, request a bug refresh with /jira refresh.

Jira Issue OCPBUGS-59244 has not been moved to the MODIFIED state.

In response to this:

Carry kubernetes-sigs#5590 until it is merged and released.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-bot
Copy link

[ART PR BUILD NOTIFIER]

Distgit: ose-aws-cluster-api-controllers
This PR has been included in build ose-aws-cluster-api-controllers-container-v4.20.0-202507161016.p0.g18b2069.assembly.stream.el9.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants