OCPCLOUD-2642: Include ASO CRDs for CAPZ installation #322

nrb · 2024-10-29T02:25:32Z

This PR reverts the exclusion of ASO CRDs.

TODO:

Include ASO CRDs in kustomization
Include ASO CRDs in component ConfigMap
Disable CRD management in ASO Deployment.
Merge OCPCLOUD-2642: manifests-gen: Allow overriding kustomize component path cluster-capi-operator#228 and update vendored version of manifests-gen.
Add ASO to CI so we have a container image to reference - OCPCLOUD-2642: Add Azure Service Operator release#55371

openshift-ci-robot · 2024-10-29T02:25:35Z

@nrb: This pull request references OCPCLOUD-2642 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.

In response to this:

This PR reverts the exclusion of ASO CRDs.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci · 2024-10-29T02:25:35Z

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

openshift-ci-robot · 2024-10-29T02:26:32Z

@nrb: This pull request references OCPCLOUD-2642 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.

In response to this:

This PR reverts the exclusion of ASO CRDs.

TODO:

Include ASO CRDs in kustomization

Include ASO CRDs in component ConfigMap

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

damdo

Looks reasonable up until now 👍

openshift-ci-robot · 2024-10-29T20:10:48Z

@nrb: This pull request references OCPCLOUD-2642 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.

In response to this:

This PR reverts the exclusion of ASO CRDs.

TODO:

Include ASO CRDs in kustomization

Include ASO CRDs in component ConfigMap

Disable CRD management in ASO Deployment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

nrb · 2024-10-29T20:16:46Z

@damdo @RadekManak Since the diff's too big for GitHub to render, how do we go about editing the arguments on the ASO Deployment? Use a Kustomize file to layer over the defaults?

Currently, it is

apiVersion: apps/v1
kind: Deployment
metadata:
  creationTimestamp: null
  labels:
    app.kubernetes.io/name: azure-service-operator
    app.kubernetes.io/version: v2.6.0
    cluster.x-k8s.io/provider: infrastructure-azure
    clusterctl.cluster.x-k8s.io: ""
    control-plane: controller-manager
  name: azureserviceoperator-controller-manager
  namespace: openshift-cluster-api
spec:
  replicas: 1
  selector:
    matchLabels:
      control-plane: controller-manager
  strategy: {}
  template:
    metadata:
      annotations:
        kubectl.kubernetes.io/default-container: manager
        target.workload.openshift.io/management: '{"effect": "PreferredDuringScheduling"}'
      creationTimestamp: null
      labels:
        aadpodidbinding: aso-manager-binding
        app.kubernetes.io/name: azure-service-operator
        app.kubernetes.io/version: v2.6.0
        control-plane: controller-manager
    spec:
      containers:
      - args:
        - --metrics-addr=:8080
        - --health-addr=:8081
        - --enable-leader-election
        - --v=2
        - --crd-pattern=${ADDITIONAL_ASO_CRDS:= }
        - --webhook-port=9443
        - --webhook-cert-dir=/tmp/k8s-webhook-server/serving-certs

From the help of the aso controller binary:

  -crd-management string
        Instructs the operator on how it should manage the Custom Resource Definitions. One of 'auto', 'none' (default "auto")
  -crd-pattern string
        Install these CRDs. CRDs already in the cluster will also always be upgraded.

So, ideally, we'd omit -crd-pattern entirely and add -crd-management=none.

openshift-ci-robot · 2024-10-30T18:31:45Z

@nrb: This pull request references OCPCLOUD-2642 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.

In response to this:

This PR reverts the exclusion of ASO CRDs.

TODO:

Include ASO CRDs in kustomization

Include ASO CRDs in component ConfigMap

Disable CRD management in ASO Deployment.

Merge OCPCLOUD-2642: manifests-gen: Allow overriding kustomize component path cluster-capi-operator#228 and update vendored version of manifests-gen.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

nrb · 2024-10-30T18:32:23Z

I figured out an approach to updating the container arguments, however it relies on openshift/cluster-capi-operator#228 being present in manifests-gen before this can merge.

damdo

Looks reasonable to me 👍

openshift-ci-robot · 2024-11-06T18:59:36Z

@nrb: This pull request references OCPCLOUD-2642 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.

In response to this:

This PR reverts the exclusion of ASO CRDs.

TODO:

Include ASO CRDs in kustomization

Include ASO CRDs in component ConfigMap

Disable CRD management in ASO Deployment.

Merge OCPCLOUD-2642: manifests-gen: Allow overriding kustomize component path cluster-capi-operator#228 and update vendored version of manifests-gen.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot · 2024-11-08T17:07:54Z

@nrb: This pull request references OCPCLOUD-2642 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.

In response to this:

This PR reverts the exclusion of ASO CRDs.

TODO:

Include ASO CRDs in kustomization

Include ASO CRDs in component ConfigMap

Disable CRD management in ASO Deployment.

Merge OCPCLOUD-2642: manifests-gen: Allow overriding kustomize component path cluster-capi-operator#228 and update vendored version of manifests-gen.

Add ASO to CI so we have a container image to reference - OCPCLOUD-2642: Add Azure Service Operator release#55371

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

damdo · 2024-11-09T09:49:37Z

/retest

damdo · 2024-11-11T09:24:38Z

/retest

bryan-cox · 2024-11-13T14:53:51Z

/retest

bryan-cox · 2024-11-13T19:37:25Z

/test e2e-azure-serial

openshift-ci · 2024-12-18T19:38:20Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from nrb. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci-robot · 2024-12-18T19:39:52Z

@nrb: This pull request references OCPCLOUD-2642 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

This PR reverts the exclusion of ASO CRDs.

TODO:

Include ASO CRDs in kustomization

Include ASO CRDs in component ConfigMap

Disable CRD management in ASO Deployment.

Merge OCPCLOUD-2642: manifests-gen: Allow overriding kustomize component path cluster-capi-operator#228 and update vendored version of manifests-gen.

Add ASO to CI so we have a container image to reference - OCPCLOUD-2642: Add Azure Service Operator release#55371

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Signed-off-by: Nolan Brubaker <[email protected]>

nrb · 2024-12-19T15:46:02Z

While the tests are passing here, the Deployment isn't able to actually create pods because h the image isn't in payload quite yet - that happens in openshift/cluster-capi-operator#235.

So we'll need that PR to merge before we can have a valid test for this behavior.

            "status": {
                "conditions": [
                    {
                        "lastTransitionTime": "2024-12-18T21:22:08Z",
                        "lastUpdateTime": "2024-12-18T21:22:08Z",
                        "message": "Deployment does not have minimum availability.",
                        "reason": "MinimumReplicasUnavailable",
                        "status": "False",
                        "type": "Available"
                    },
                    {
                        "lastTransitionTime": "2024-12-18T21:32:09Z",
                        "lastUpdateTime": "2024-12-18T21:32:09Z",
                        "message": "ReplicaSet \"azureserviceoperator-controller-manager-75678d9f88\" has timed out progressing.",
                        "reason": "ProgressDeadlineExceeded",
                        "status": "False",
                        "type": "Progressing"
                    }
                ],

damdo · 2025-01-07T09:59:21Z

It looks like openshift/cluster-capi-operator#235 merged now, so we should be able to see that succeeding now

damdo · 2025-01-07T09:59:35Z

/test e2e-azure-capi-techpreview

damdo · 2025-01-07T09:59:38Z

/retest

nrb · 2025-01-07T19:53:00Z

event happened 352 times, something is wrong: namespace/openshift-cluster-api node/ci-op-jxzpnrgk-40c0c-5mms6-worker-eastus3-j9tn8 pod/azureserviceoperator-controller-manager-b885ff67c-zjq4s hmsg/c8d2995934 - reason/Pulling Pulling image "registry.build10.ci.openshift.org/ci-op-jxzpnrgk/stable@sha256:a7aab3e27a07cc343b97c020c90985f249fa9d8adabf2cf3fa60a0f045ee0596" (12:26:31Z) result=reject }

This failure looks legitimate, probably means that the CAPZ deployment fails to start, too. Will check logs and CI to see if I can get that image.

nrb · 2025-01-07T20:41:10Z

The ASO log isn't in plaintext: https://gcsweb-ci.apps.ci.l2s4.p1.openshiftapps.com/gcs/test-platform-results/pr-logs/pull/openshift_cluster-api-provider-azure/322/pull-ci-openshift-cluster-api-provider-azure-master-e2e-azure-techpreview/1876569391852687360/artifacts/e2e-azure-techpreview/gather-extra/artifacts/pods/openshift-cluster-api_azureserviceoperator-controller-manager-b885ff67c-zjq4s_manager.log

Looking at the pods for ASO, I see this in the status:

      name: manager
      ready: false
      restartCount: 0
      started: false
      state:
        waiting:
          message: secret "aso-controller-settings" not found
          reason: CreateContainerConfigError

Double checking the rest of the deployment, I see that all the Azure environment variables are set to come from that secret, so I'll need some more patching on this to make sure our settings are used instead.

nrb · 2025-01-07T20:50:06Z

We'll need to either populate the aso-controller-settings secret with the information we already have for CAPZ/the Azure CCM, or update the ASO deployment to reference the same secret that those components use.

openshift-bot · 2025-04-17T01:01:06Z

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

openshift-merge-robot · 2025-04-17T01:01:16Z

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

openshift-bot · 2025-05-17T08:30:12Z

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten
/remove-lifecycle stale

nrb · 2025-05-19T15:21:05Z

/lifecycle frozen
/remove-lifecycle rotten

openshift-ci · 2025-05-19T15:21:07Z

@nrb: The lifecycle/frozen label cannot be applied to Pull Requests.

In response to this:

/lifecycle frozen
/remove-lifecycle rotten

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

openshift-ci · 2025-07-01T15:46:37Z

@nrb: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-azure-techpreview	`da93f62`	link	false	`/test e2e-azure-techpreview`
ci/prow/e2e-azure-serial-2of2	`da93f62`	link	true	`/test e2e-azure-serial-2of2`
ci/prow/e2e-azure-serial-1of2	`da93f62`	link	true	`/test e2e-azure-serial-1of2`

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Oct 29, 2024

openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 29, 2024

damdo reviewed Oct 29, 2024

View reviewed changes

nrb mentioned this pull request Oct 30, 2024

OCPCLOUD-2642: manifests-gen: Allow overriding kustomize component path openshift/cluster-capi-operator#228

Merged

damdo reviewed Oct 31, 2024

View reviewed changes

damdo mentioned this pull request Nov 4, 2024

OCPCLOUD-2745: Merge https://github.com/kubernetes-sigs/cluster-api-provider-azure:v1.17.1 (32cd4c7) into master #320

Closed

nrb force-pushed the OCPCLOUD-2642 branch from 5cb8769 to d441e06 Compare November 4, 2024 20:43

nrb mentioned this pull request Nov 4, 2024

WIP: Add Azure VAP #321

Draft

nrb marked this pull request as ready for review November 6, 2024 18:59

openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 6, 2024

openshift-ci bot requested review from damdo and JoelSpeed November 6, 2024 19:00

nrb force-pushed the OCPCLOUD-2642 branch from d441e06 to ba005f8 Compare November 8, 2024 17:05

nrb force-pushed the OCPCLOUD-2642 branch from ba005f8 to aa9e929 Compare December 18, 2024 19:36

openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 18, 2024

nrb force-pushed the OCPCLOUD-2642 branch from aa9e929 to 6921c8d Compare December 18, 2024 19:50

openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 18, 2024

nrb changed the title ~~OCPCLOUD-2642: Generate ASO CRDs for CAPZ installation~~ OCPCLOUD-2642: Include ASO CRDs for CAPZ installation Dec 18, 2024

UPSTREAM: <carry>: Regenerate manifests to include ASO

da93f62

Signed-off-by: Nolan Brubaker <[email protected]>

nrb force-pushed the OCPCLOUD-2642 branch from 6921c8d to da93f62 Compare December 18, 2024 20:21

openshift-ci bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 17, 2025

openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 17, 2025

openshift-ci bot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels May 17, 2025

openshift-ci bot removed the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label May 19, 2025

OCPCLOUD-2642: Include ASO CRDs for CAPZ installation #322

Are you sure you want to change the base?

OCPCLOUD-2642: Include ASO CRDs for CAPZ installation #322

Uh oh!

Conversation

nrb commented Oct 29, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci-robot commented Oct 29, 2024 • edited by openshift-ci bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci bot commented Oct 29, 2024

Uh oh!

openshift-ci-robot commented Oct 29, 2024 • edited by openshift-ci bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

damdo left a comment

Choose a reason for hiding this comment

Uh oh!

openshift-ci-robot commented Oct 29, 2024 • edited by openshift-ci bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nrb commented Oct 29, 2024

Uh oh!

openshift-ci-robot commented Oct 30, 2024 • edited by openshift-ci bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nrb commented Oct 30, 2024

Uh oh!

damdo left a comment

Choose a reason for hiding this comment

Uh oh!

openshift-ci-robot commented Nov 6, 2024 • edited by openshift-ci bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci-robot commented Nov 8, 2024 • edited by openshift-ci bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

damdo commented Nov 9, 2024

Uh oh!

damdo commented Nov 11, 2024

Uh oh!

bryan-cox commented Nov 13, 2024

Uh oh!

bryan-cox commented Nov 13, 2024

Uh oh!

openshift-ci bot commented Dec 18, 2024

Uh oh!

openshift-ci-robot commented Dec 18, 2024 • edited by openshift-ci bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nrb commented Dec 19, 2024

Uh oh!

damdo commented Jan 7, 2025

Uh oh!

damdo commented Jan 7, 2025

Uh oh!

damdo commented Jan 7, 2025

Uh oh!

nrb commented Jan 7, 2025

Uh oh!

nrb commented Jan 7, 2025

Uh oh!

nrb commented Jan 7, 2025

Uh oh!

openshift-bot commented Apr 17, 2025

Uh oh!

openshift-merge-robot commented Apr 17, 2025

Uh oh!

openshift-bot commented May 17, 2025

Uh oh!

nrb commented May 19, 2025

Uh oh!

openshift-ci bot commented May 19, 2025

Uh oh!

openshift-ci bot commented Jul 1, 2025

Uh oh!

Uh oh!

nrb commented Oct 29, 2024 •

edited

Loading

openshift-ci-robot commented Oct 29, 2024 •

edited by openshift-ci bot

Loading

openshift-ci-robot commented Oct 29, 2024 •

edited by openshift-ci bot

Loading

openshift-ci-robot commented Oct 29, 2024 •

edited by openshift-ci bot

Loading

openshift-ci-robot commented Oct 30, 2024 •

edited by openshift-ci bot

Loading

openshift-ci-robot commented Nov 6, 2024 •

edited by openshift-ci bot

Loading

openshift-ci-robot commented Nov 8, 2024 •

edited by openshift-ci bot

Loading

openshift-ci-robot commented Dec 18, 2024 •

edited by openshift-ci bot

Loading