WIP: Migrate asset generation to ocp-manifests #386
Conversation
These are remnants of the in-tree infracluster controller and are no longer used by CI jobs [1][2]. [1] openshift/release#72179 [2] openshift/release#72221 Signed-off-by: Stephen Finucane <[email protected]>
This lets us work like everyone else. Signed-off-by: Stephen Finucane <[email protected]>
Invoke our new makefile target. In the future, this should happen automatically. ❯ make -C openshift ocp-manifests PROVIDER_VERSION=v0.12.5 Signed-off-by: Stephen Finucane <[email protected]>
This is now handled by CCAPIO's manifest-gen. We also rework our OpenShift-specific Dockerfile and Makefile to align with those used for other providers. Signed-off-by: Stephen Finucane <[email protected]>
openshift-ci
bot
added
the
do-not-merge/work-in-progress
|
Skipping CI for Draft Pull Request. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@stephenfin: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
1 participant
This aligns us with the other providers and should ease the maintenance burden somewhat.
Note
manifests-genis currently being rewritten, so there's a good chance we won't end up merging a lot of this. We likely want the initial patch to removeMakefiletargets along with theDockerfilechanges, however.