Revert "TRT-2048: Revert "OCPCLOUD-2792: corecluster: set controller level conditions + tests""

[damdo]

Reverts #273 which is the revert of #256

Context: https://redhat-internal.slack.com/archives/C01CQA76KMX/p1748604228528099?thread_ts=1741634385.702679&cid=C01CQA76KMX

[openshift-ci-robot]

@damdo: This pull request references TRT-2048 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.20.0" version, but no target version was set.

Details

In response to this:

Reverts #273 which is the revert of #256

Context: https://redhat-internal.slack.com/archives/C01CQA76KMX/p1748604228528099?thread_ts=1741634385.702679&cid=C01CQA76KMX

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign theobarberbany for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-merge-robot]

PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[openshift-ci]

@damdo: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-gcp-capi-techpreview	8c98807	link	true	/test e2e-gcp-capi-techpreview
ci/prow/e2e-aws-capi-techpreview	8c98807	link	true	/test e2e-aws-capi-techpreview
ci/prow/e2e-azure-ovn-techpreview	8c98807	link	false	/test e2e-azure-ovn-techpreview
ci/prow/e2e-metal3-capi-techpreview	8c98807	link	false	/test e2e-metal3-capi-techpreview
ci/prow/e2e-aws-ovn-techpreview	8c98807	link	true	/test e2e-aws-ovn-techpreview
ci/prow/e2e-aws-capi-customnoupgrade-migration	8c98807	link	true	/test e2e-aws-capi-customnoupgrade-migration
ci/prow/e2e-vsphere-capi-techpreview	8c98807	link	true	/test e2e-vsphere-capi-techpreview
ci/prow/e2e-gcp-ovn-techpreview	8c98807	link	true	/test e2e-gcp-ovn-techpreview
ci/prow/regression-clusterinfra-cucushift-rehearse-capi-aws-ipi	8c98807	link	false	/test regression-clusterinfra-cucushift-rehearse-capi-aws-ipi
ci/prow/e2e-openstack-capi-techpreview	8c98807	link	true	/test e2e-openstack-capi-techpreview
ci/prow/e2e-azure-capi-techpreview	8c98807	link	true	/test e2e-azure-capi-techpreview
ci/prow/e2e-openstack-ovn-techpreview	8c98807	link	true	/test e2e-openstack-ovn-techpreview
ci/prow/e2e-azure-ovn-techpreview-upgrade	8c98807	link	true	/test e2e-azure-ovn-techpreview-upgrade
ci/prow/e2e-aws-ovn-techpreview-upgrade	8c98807	link	true	/test e2e-aws-ovn-techpreview-upgrade

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[openshift-bot]

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

[damdo]

/remove-lifecycle stale

[openshift-bot]

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

[coderabbitai]

Important

Review skipped

Auto reviews are limited based on label configuration.

🚫 Review skipped — only excluded labels are configured. (1)

• do-not-merge/work-in-progress

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}