-
Notifications
You must be signed in to change notification settings - Fork 147
OCPBUGS-62738:CNTRLPLANE-1315:Add OpenShift Tests Extension (OTE) for cluster-etcd-operator #1491
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
gangwgr
wants to merge
3
commits into
openshift:release-4.20
Choose a base branch
from
gangwgr:release-4.20
base: release-4.20
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+199,174
−11
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,105 @@ | ||
| package main | ||
|
|
||
| import ( | ||
| "fmt" | ||
| "os" | ||
| "strings" | ||
|
|
||
| "github.com/openshift-eng/openshift-tests-extension/pkg/cmd" | ||
| e "github.com/openshift-eng/openshift-tests-extension/pkg/extension" | ||
| et "github.com/openshift-eng/openshift-tests-extension/pkg/extension/extensiontests" | ||
| g "github.com/openshift-eng/openshift-tests-extension/pkg/ginkgo" | ||
|
|
||
| "github.com/spf13/cobra" | ||
|
|
||
| // The import below is necessary to ensure that the cluster etcd operator tests are registered with the extension. | ||
| _ "github.com/openshift/cluster-etcd-operator/test/extended" | ||
| ) | ||
|
|
||
| func main() { | ||
| registry := e.NewRegistry() | ||
| ext := e.NewExtension("openshift", "payload", "cluster-etcd-operator") | ||
|
|
||
| // Suite: conformance/parallel (fast, parallel-safe) | ||
| ext.AddSuite(e.Suite{ | ||
| Name: "openshift/cluster-etcd-operator/conformance/parallel", | ||
| Parents: []string{"openshift/conformance/parallel"}, | ||
| Qualifiers: []string{ | ||
| `!(name.contains("[Serial]") || name.contains("[Slow]"))`, | ||
| }, | ||
| }) | ||
|
|
||
| // Suite: conformance/serial (explicitly serial tests) | ||
| ext.AddSuite(e.Suite{ | ||
| Name: "openshift/cluster-etcd-operator/conformance/serial", | ||
| Parents: []string{"openshift/conformance/serial"}, | ||
| Qualifiers: []string{ | ||
| `name.contains("[Serial]")`, | ||
| }, | ||
| }) | ||
|
|
||
| // Suite: optional/slow (long-running tests) | ||
| ext.AddSuite(e.Suite{ | ||
| Name: "openshift/cluster-etcd-operator/optional/slow", | ||
| Parents: []string{"openshift/optional/slow"}, | ||
| Qualifiers: []string{ | ||
| `name.contains("[Slow]")`, | ||
| }, | ||
| }) | ||
|
|
||
| // Suite: all (includes everything) | ||
| ext.AddSuite(e.Suite{ | ||
| Name: "openshift/cluster-etcd-operator/all", | ||
| }) | ||
|
|
||
| specs, err := g.BuildExtensionTestSpecsFromOpenShiftGinkgoSuite() | ||
| if err != nil { | ||
| panic(fmt.Sprintf("couldn't build extension test specs from ginkgo: %+v", err.Error())) | ||
| } | ||
|
|
||
| // Ensure [Disruptive] tests are also [Serial] (for any future tests that might need this) | ||
| specs = specs.Walk(func(spec *et.ExtensionTestSpec) { | ||
| if strings.Contains(spec.Name, "[Disruptive]") && !strings.Contains(spec.Name, "[Serial]") { | ||
| spec.Name = strings.ReplaceAll( | ||
| spec.Name, | ||
| "[Disruptive]", | ||
| "[Serial][Disruptive]", | ||
| ) | ||
| } | ||
| }) | ||
|
|
||
| // Preserve original-name labels for renamed tests | ||
| specs = specs.Walk(func(spec *et.ExtensionTestSpec) { | ||
| for label := range spec.Labels { | ||
| if strings.HasPrefix(label, "original-name:") { | ||
| parts := strings.SplitN(label, "original-name:", 2) | ||
| if len(parts) > 1 { | ||
| spec.OriginalName = parts[1] | ||
| } | ||
| } | ||
| } | ||
| }) | ||
|
|
||
| // Ignore obsolete tests | ||
| ext.IgnoreObsoleteTests( | ||
| // "[sig-etcd] <test name here>", | ||
| ) | ||
|
|
||
| // Initialize environment before running any tests | ||
| specs.AddBeforeAll(func() { | ||
| // do stuff | ||
| }) | ||
|
|
||
| ext.AddSpecs(specs) | ||
| registry.Register(ext) | ||
|
|
||
| root := &cobra.Command{ | ||
| Long: "Cluster Etcd Operator Tests Extension", | ||
| } | ||
|
|
||
| root.AddCommand(cmd.DefaultExtensionCommands(registry)...) | ||
|
|
||
| if err := root.Execute(); err != nil { | ||
| os.Exit(1) | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,5 @@ | ||
| //go:build linux | ||
|
|
||
| package render | ||
|
|
||
| import ( | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
disclaimer: I have no idea about the entire effort
is it desired that we ship the test binary with the production operator?