-
Notifications
You must be signed in to change notification settings - Fork 131
OCPBUGS-53867: Bump github.com/golang-jwt/jwt #1229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: release-4.14
Are you sure you want to change the base?
Conversation
@sbiradar10: This pull request references Jira Issue OCPBUGS-53867, which is valid. 7 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Jira ([email protected]), skipping review request. The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/lgtm |
@sbiradar10 It looks like it's complaining about the |
@sbiradar10 Yea I believe it needs to be run inside the |
New changes are detected. LGTM label has been removed. |
@shannon just made changes now |
/retest-required |
2 similar comments
/retest-required |
/retest-required |
/assign flavianmissi Can you please review/approve this? This was a follow up to #1224 because we missed the second go.mod file. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you squash your commits ?
d2e9b19
to
6e95bc9
Compare
/retest-required |
/approve |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: ricardomaraschini, sbiradar10, shannon The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest-required |
/hold Hi @sbiradar10, I noticed that v5 version is not quite right. It should be So I will put a hold on this until it's updated. |
added new changes suggested changes
97cf3a0
to
3be0fa5
Compare
/unhold |
@sbiradar10: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Prevent GHSA-mh63-6h87-95cp. We are relying on
https://github.com/Azure/go-autorest that has been archived and isn't receiving more updates. This will force us to move to a different package but we can't wait for that to happen to address the CVE therefore this PR adds a replacement on github.com/golang-jwt/jwt/v4 pointing to v4.5.2.