OCPBUGS-62626: only report Progressing=True when progressing towards new configuration by atiratree · Pull Request #1293 · openshift/cluster-image-registry-operator

atiratree · 2026-02-16T10:46:10Z

followup for #1286

openshift-ci-robot · 2026-02-16T10:46:15Z

@atiratree: This pull request references Jira Issue OCPBUGS-62626, which is invalid:

expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is ON_QA instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

followup for #1286

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci · 2026-02-16T10:48:15Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: atiratree
Once this PR has been reviewed and has the lgtm label, please assign ricardomaraschini for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

atiratree · 2026-02-16T10:58:14Z

/jira refresh

openshift-ci-robot · 2026-02-16T10:58:21Z

@atiratree: This pull request references Jira Issue OCPBUGS-62626, which is valid.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.22.0) matches configured target version for branch (4.22.0)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @xiuwang

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

atiratree · 2026-02-16T15:24:31Z

/retest

atiratree · 2026-02-17T09:02:52Z

/retest

openshift-ci · 2026-02-18T18:14:31Z

@atiratree: you cannot LGTM your own PR.

Details

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

atiratree · 2026-02-18T18:14:37Z

/retest

ricardomaraschini

Looks good, I have just one clarification to ask. I have left it as a comment.

ricardomaraschini · 2026-02-24T13:30:45Z

pkg/operator/nodecadaemon.go

 		}

-		if ds.Generation != ds.Status.ObservedGeneration {
+		if ds.Status.UpdatedNumberScheduled < ds.Status.DesiredNumberScheduled && ds.Status.NumberMisscheduled == 0 {


If we have misscheduled pods then we aren't progressing ? I mean, aren't we expecting something else to happen to become "AsExpected" ?

Nice catch! My bad, I can't remember if I wanted to add another state or something, but I didn't revisit this line.

…ssing condition

atiratree · 2026-02-24T17:37:53Z

@ricardomaraschini thanks! Should be fixed now.

atiratree · 2026-02-25T01:15:24Z

/retest

openshift-ci · 2026-02-25T03:12:48Z

@atiratree: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-aws-ovn-image-registry	`ddb9494`	link	true	`/test e2e-aws-ovn-image-registry`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

atiratree · 2026-02-25T10:03:31Z

/hold
need to check the failures

xiuwang · 2026-03-02T11:37:50Z

/verified by @xiuwang

openshift-ci-robot · 2026-03-02T11:38:05Z

@xiuwang: This PR has been marked as verified by @xiuwang.

Details

In response to this:

/verified by @xiuwang

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

atiratree · 2026-03-03T12:31:25Z

the image registry operator seems to be available and functioning well

The reported alert looks irrelevant:

  {
        "metric": {
          "__name__": "ALERTS",
          "alertname": "KubeJobFailed",
          "alertstate": "firing",
          "condition": "true",
          "container": "kube-rbac-proxy-main",
          "endpoint": "https-main",
          "job": "kube-state-metrics",
          "job_name": "periodic-gathering-krjbd",
          "namespace": "openshift-insights",
          "prometheus": "openshift-monitoring/k8s",
          "service": "kube-state-metrics",
          "severity": "warning"
        },
        "value": [
          1771987258.648,
          "1"
        ]
      }
    ]

The test also isn't completely healthy and we can see the exact same failure elsewhere
https://sippy.dptools.openshift.org/sippy-ng/tests/4.22/analysis?test=%5Bsig-instrumentation%5D%20Prometheus%20%5Bapigroup%3Aimage.openshift.io%5D%20when%20installed%20on%20the%20cluster%20shouldn%27t%20report%20any%20alerts%20in%20firing%20state%20apart%20from%20Watchdog%20and%20AlertmanagerReceiversNotConfigured%20%5BEarly%5D%5Bapigroup%3Aconfig.openshift.io%5D%20%5BSuite%3Aopenshift%2Fconformance%2Fparallel%5D&filters=%7B%22items%22%3A%5B%7B%22columnField%22%3A%22name%22%2C%22operatorValue%22%3A%22equals%22%2C%22value%22%3A%22%5Bsig-instrumentation%5D%20Prometheus%20%5Bapigroup%3Aimage.openshift.io%5D%20when%20installed%20on%20the%20cluster%20shouldn%27t%20report%20any%20alerts%20in%20firing%20state%20apart%20from%20Watchdog%20and%20AlertmanagerReceiversNotConfigured%20%5BEarly%5D%5Bapigroup%3Aconfig.openshift.io%5D%20%5BSuite%3Aopenshift%2Fconformance%2Fparallel%5D%22%7D%2C%7B%22columnField%22%3A%22variants%22%2C%22not%22%3Atrue%2C%22operatorValue%22%3A%22has%20entry%22%2C%22value%22%3A%22never-stable%22%7D%2C%7B%22columnField%22%3A%22variants%22%2C%22not%22%3Atrue%2C%22operatorValue%22%3A%22has%20entry%22%2C%22value%22%3A%22aggregated%22%7D%5D%2C%22linkOperator%22%3A%22and%22%7D

atiratree · 2026-03-03T12:32:42Z

/label docs-approved
/label px-approved
/hold cancel

openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Feb 16, 2026

atiratree mentioned this pull request Feb 16, 2026

OTA-1678: remove image-registry exceptions on operator state transitions openshift/origin#30755

Open

openshift-ci bot requested review from flavianmissi and ricardomaraschini February 16, 2026 10:48

openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Feb 16, 2026

openshift-ci bot requested a review from xiuwang February 16, 2026 10:58

deployment status should depend on the Deployment Progressing condition

dd8c921

atiratree force-pushed the OTA-1678 branch from 403c31e to f5730c6 Compare February 16, 2026 10:59

atiratree mentioned this pull request Feb 17, 2026

OCPBUGS-65896: controllers: Prevent Progressing=True when scaling only openshift/cluster-authentication-operator#836

Closed

ricardomaraschini reviewed Feb 24, 2026

View reviewed changes

daemon set should use status.updatedNumberScheduled to compute Progre…

ddb9494

…ssing condition

atiratree force-pushed the OTA-1678 branch from f5730c6 to ddb9494 Compare February 24, 2026 17:34

openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 25, 2026

openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Mar 2, 2026

openshift-ci bot added docs-approved Signifies that Docs has signed off on this PR px-approved Signifies that Product Support has signed off on this PR and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Mar 3, 2026

Conversation

atiratree commented Feb 16, 2026

Uh oh!

openshift-ci-robot commented Feb 16, 2026

Uh oh!

openshift-ci bot commented Feb 16, 2026

Uh oh!

atiratree commented Feb 16, 2026

Uh oh!

openshift-ci-robot commented Feb 16, 2026

Uh oh!

atiratree commented Feb 16, 2026

Uh oh!

atiratree commented Feb 17, 2026

Uh oh!

openshift-ci bot commented Feb 18, 2026

Uh oh!

atiratree commented Feb 18, 2026

Uh oh!

ricardomaraschini left a comment

Choose a reason for hiding this comment

Uh oh!

ricardomaraschini Feb 24, 2026

Choose a reason for hiding this comment

Uh oh!

atiratree Feb 24, 2026

Choose a reason for hiding this comment

Uh oh!

atiratree commented Feb 24, 2026

Uh oh!

atiratree commented Feb 25, 2026

Uh oh!

openshift-ci bot commented Feb 25, 2026

Uh oh!

atiratree commented Feb 25, 2026

Uh oh!

xiuwang commented Mar 2, 2026

Uh oh!

openshift-ci-robot commented Mar 2, 2026

Uh oh!

atiratree commented Mar 3, 2026

Uh oh!

atiratree commented Mar 3, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants