IR-350: make metrics server tls configuration file-based#1297
IR-350: make metrics server tls configuration file-based#1297ricardomaraschini wants to merge 2 commits intoopenshift:mainfrom
Conversation
openshift-ci-robot
added
the
jira/valid-reference
|
@ricardomaraschini: This pull request references IR-350 which is a valid jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci
bot
added
the
approved
ricardomaraschini
force-pushed
the
ir-350-operator
branch
2 times, most recently
from
a36fb9c to
783b2c7
Compare
|
nicely done! /retest-required |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: flavianmissi, ricardomaraschini The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ricardomaraschini
force-pushed
the
ir-350-operator
branch
from
783b2c7 to
f4d7200
Compare
|
New changes are detected. LGTM label has been removed. |
|
/hold This PR depends on openshift/cluster-version-operator#1322 |
openshift-ci
bot
added
the
do-not-merge/hold
| include.release.openshift.io/self-managed-high-availability: "true" | ||
| release.openshift.io/create-only: "true" | ||
| include.release.openshift.io/single-node-developer: "true" | ||
| config.openshift.io/inject-tls: "true" |
There was a problem hiding this comment.
Currently still WIP annotation
|
/retest |
ricardomaraschini
force-pushed
the
ir-350-operator
branch
from
f4d7200 to
8735826
Compare
|
/retest |
ricardomaraschini
force-pushed
the
ir-350-operator
branch
4 times, most recently
from
4a1f253 to
9089e15
Compare
ricardomaraschini
force-pushed
the
ir-350-operator
branch
from
9089e15 to
c6f82c1
Compare
|
We want to use this to test openshift/cluster-version-operator#1322 so let's unhold it. /unhold |
openshift-ci
bot
removed
the
do-not-merge/hold
|
Nevermind, this may cause IPv6 issues. Putting it back on hold. /hold |
openshift-ci
bot
added
the
do-not-merge/hold
|
@kaleemsiddiqu Can we try to test this one on IPv6 ? What we want to guarantee is that this will deploy on an IPv6 cluster and that the metrics endpoint on the operator works. I did some investigations and I believe we are good with this one but we better to be 100% sure. |
ricardomaraschini
force-pushed
the
ir-350-operator
branch
from
c6f82c1 to
36368ff
Compare
|
/retest |
1 similar comment
|
/retest |
ricardomaraschini
force-pushed
the
ir-350-operator
branch
from
36368ff to
db5f2d7
Compare
|
/retest |
updates the metrics server to read tls and serving configuration from a controller config file instead of using hardcoded values. this allows for dynamic configuration of bind address, minimum tls version, and cipher suites. this new flag is optional for now. by making it optional hypershift tests pass. to make it required a patch in hypershift is needed (to be done).
the aws bootstrap test was flaky, the test has a concurency issue with the operator sync(). this commit fixes.
ricardomaraschini
force-pushed
the
ir-350-operator
branch
from
db5f2d7 to
6f53820
Compare
|
/retest |
1 similar comment
|
/retest |
|
@ricardomaraschini: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
4 participants
updates the metrics server to read tls and serving configuration from a controller config file instead of using hardcoded values. this allows for dynamic configuration of bind address, minimum tls version, and cipher suites.