Skip to content

Conversation

@khdo
Copy link

@khdo khdo commented Aug 25, 2025

No description provided.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 25, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 25, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 25, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign gcs278 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@khdo khdo marked this pull request as ready for review September 5, 2025 13:06
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 5, 2025
if OKD {
packageName = "servicemeshoperator3"
catalogSource = "okderators"
}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does this require OKDerators catalog to be installed? what happens if you trigger this feature without installing OKDerators?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are also interested in the answer to this question.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 5, 2025

@khdo: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-azure-ovn 9219971 link false /test e2e-azure-ovn
ci/prow/e2e-gcp-operator 9219971 link true /test e2e-gcp-operator

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@candita
Copy link
Contributor

candita commented Sep 24, 2025

Thanks for the update. Once this has proved successful and merges, we can investigate removing the OKD skip in:
https://github.com/openshift/origin/blob/main/test/extended/router/gatewayapicontroller.go#L72

@candita
Copy link
Contributor

candita commented Sep 24, 2025

/assign @bentito
/assign @grzpiotrowski

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants