-
Notifications
You must be signed in to change notification settings - Fork 218
DNM/SPLAT-2468: spike/aws-nlb/internal/proxy: enforce proxy proto on internal NLB IC #1276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
@mtulio: This pull request references SPLAT-2468 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the spike to target the "4.21.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
Skipping CI for Draft Pull Request. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/test unit verify images verify-deps e2e-aws-ovn |
|
/test unit |
|
/test e2e-aws-ovn |
|
Trying this first: /testwith openshift/cloud-provider-aws/main/e2e-aws-ovn-techpreview openshift/cloud-provider-aws#117 Then next: /testwith openshift/cloud-provider-aws/main/e2e-aws-ovn-techpreview openshift/cloud-provider-aws#117 openshift/origin#30235 |
may not work testing with external workflow :( /testwith openshift/cluster-ingress-operator/master/e2e-aws-ovn openshift/cloud-provider-aws#117 |
|
/testwith openshift/cluster-ingress-operator/master/e2e-aws-ovn openshift/cloud-provider-aws#117 |
|
/test ? |
|
@mtulio: The following commands are available to trigger required jobs: The following commands are available to trigger optional jobs: Use In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/testwith openshift/cluster-ingress-operator/master/e2e-aws-ovn-hypershift-conformance openshift/cloud-provider-aws#117 |
|
@mtulio: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Please, do not move this PR (spike).
This change introduce a configuration to enforce the routers on AWS to configure the Service with custom annotations to configure the target group attributes intending to fix the hairpinning traffic on private AWS deployments.
Refs: