Skip to content

Conversation

@richardsonnick
Copy link

To support new PQC curves, let's add a config for explicitly setting the supported groups.

ROUTER_CURVES is piped through OpenShift/router to HAProxy where it will be used by ssl-default-bind-curves

For more context see: openshift/router#678

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 30, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 30, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 30, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign miciah for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@richardsonnick richardsonnick marked this pull request as ready for review September 30, 2025 13:18
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 30, 2025
@openshift-ci openshift-ci bot requested review from candita and rikatz September 30, 2025 13:20
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 3, 2025

@richardsonnick: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/okd-scos-e2e-aws-ovn a0154e9 link false /test okd-scos-e2e-aws-ovn
ci/prow/verify a0154e9 link true /test verify
ci/prow/verify-deps a0154e9 link true /test verify-deps
ci/prow/e2e-azure-operator a0154e9 link true /test e2e-azure-operator
ci/prow/e2e-aws-ovn-techpreview a0154e9 link false /test e2e-aws-ovn-techpreview
ci/prow/e2e-aws-ovn a0154e9 link true /test e2e-aws-ovn
ci/prow/hypershift-e2e-aks a0154e9 link true /test hypershift-e2e-aks
ci/prow/e2e-aws-ovn-serial a0154e9 link true /test e2e-aws-ovn-serial
ci/prow/e2e-aws-ovn-single-node a0154e9 link false /test e2e-aws-ovn-single-node
ci/prow/e2e-aws-ovn-serial-2of2 a0154e9 link true /test e2e-aws-ovn-serial-2of2

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't directly modify the vendored modules. There should be a corresponding go.mod/go.sum bump for this change.

@Miciah
Copy link
Contributor

Miciah commented Oct 15, 2025

/assign

@richardsonnick richardsonnick marked this pull request as draft October 16, 2025 15:30
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 16, 2025
@candita
Copy link
Contributor

candita commented Oct 30, 2025

/assign @rfredette @davidesalerno

// curves:
// - X25519
// - P-256
Curves []string `json:"curves.omitempty"`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even if we cannot change vendored modules as pointed out by Andrey, I think there is an error.

The annotation should be json:"curves,omitempty" (with comma)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants