-
Notifications
You must be signed in to change notification settings - Fork 218
Add support for TLS curves in router deployment configuration #1287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Skipping CI for Draft Pull Request. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@richardsonnick: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't directly modify the vendored modules. There should be a corresponding go.mod/go.sum bump for this change.
|
/assign |
|
/assign @rfredette @davidesalerno |
| // curves: | ||
| // - X25519 | ||
| // - P-256 | ||
| Curves []string `json:"curves.omitempty"` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Even if we cannot change vendored modules as pointed out by Andrey, I think there is an error.
The annotation should be json:"curves,omitempty" (with comma)
To support new PQC curves, let's add a config for explicitly setting the supported groups.
ROUTER_CURVES is piped through OpenShift/router to HAProxy where it will be used by
ssl-default-bind-curvesFor more context see: openshift/router#678