OCPBUGS-62627: cluster operator ingress reported Progressing=True wit…

[davidesalerno]

…h reason=Reconciling for a node reboot

This PR will avoid Cluster Ingress Operator reporting Progressing=True condition if there is a node reboot or scale up as per Cluster Operator new requirement (link).

The Cluster Ingress Operator will continue to report DeploymentRollingOut=true condition with a different Reason if there is a node reboot or scale up and we will exclude these reasons (ReplicasStabilizing and PodsStarting) from the ones causing the operator Progressing=True condition.

In order to detect the a Deployment has been fully rolled out in the past we will use Deployment condition Progressing with reason NewReplicaSetAvailable as similarly done in library-go (see PR)

[openshift-ci-robot]

@davidesalerno: This pull request references Jira Issue OCPBUGS-62627, which is invalid:

• expected the bug to target the "4.21.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

…h reason=Reconciling for a node reboot

This PR will avoid Cluster Ingress Operator reporting Progressing=True condition if there is a node reboot or scale up as per Cluster Operator new requirement (link).

The Cluster Ingress Operator will continue to report DeploymentRollingOut=true condition with a different Reason if there is a node reboot or scale up and we will exclude these reasons (ReplicasStabilizing and PodsStarting ) from the ones causing the operator Progressing=True condition.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign davidesalerno for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[davidesalerno]

/jira refresh

[openshift-ci-robot]

@davidesalerno: This pull request references Jira Issue OCPBUGS-62627, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.21.0) matches configured target version for branch (4.21.0)
• bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @lihongan

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

@davidesalerno: This pull request references Jira Issue OCPBUGS-62627, which is valid.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.21.0) matches configured target version for branch (4.21.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @lihongan

In response to this:

…h reason=Reconciling for a node reboot

This PR will avoid Cluster Ingress Operator reporting Progressing=True condition if there is a node reboot or scale up as per Cluster Operator new requirement (link).

The Cluster Ingress Operator will continue to report DeploymentRollingOut=true condition with a different Reason if there is a node reboot or scale up and we will exclude these reasons (ReplicasStabilizing and PodsStarting) from the ones causing the operator Progressing=True condition.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

@davidesalerno: This pull request references Jira Issue OCPBUGS-62627, which is valid.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.21.0) matches configured target version for branch (4.21.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @lihongan

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

…h reason=Reconciling for a node reboot

This PR will avoid Cluster Ingress Operator reporting Progressing=True condition if there is a node reboot or scale up as per Cluster Operator new requirement (link).

The Cluster Ingress Operator will continue to report DeploymentRollingOut=true condition with a different Reason if there is a node reboot or scale up and we will exclude these reasons (ReplicasStabilizing and PodsStarting) from the ones causing the operator Progressing=True condition.

In order to detect the a Deployment has been fully rolled out in the past we will use Deployment condition Progressing with reason NewReplicaSetAvailable as similarly done in library-go (see PR)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[davidesalerno]

/retest

[openshift-ci]

@davidesalerno: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[lihongan]

per-merge tested and passed
/label qe-approved
/verified by @lihongan

## watching co/ingress status while rebooting the node

## with the fix:
$ oc get co/ingress -w
NAME      VERSION                                                AVAILABLE   PROGRESSING   DEGRADED   SINCE   MESSAGE
ingress   4.21.0-0-2025-11-17-075629-test-ci-ln-scc84qk-latest   True        False         False      23m     


## without the fix
$ oc get co/ingress -w
NAME      VERSION                              AVAILABLE   PROGRESSING   DEGRADED   SINCE   MESSAGE
ingress   4.21.0-0.nightly-2025-11-13-042845   True        False         False      34m     
ingress   4.21.0-0.nightly-2025-11-13-042845   True        True          False      35m     ingresscontroller "default" is progressing: IngressControllerProgressing: One or more status conditions indicate progressing: DeploymentRollingOut=True (DeploymentRollingOut: Waiting for router deployment rollout to finish: 1 of 2 updated replica(s) are available......
ingress   4.21.0-0.nightly-2025-11-13-042845   True        False         False      36m     

[openshift-ci-robot]

@lihongan: This PR has been marked as verified by @lihongan.

In response to this:

per-merge tested and passed
/label qe-approved
/verified by @lihongan

## watching co/ingress status while rebooting the node

## with the fix:
$ oc get co/ingress -w
NAME      VERSION                                                AVAILABLE   PROGRESSING   DEGRADED   SINCE   MESSAGE
ingress   4.21.0-0-2025-11-17-075629-test-ci-ln-scc84qk-latest   True        False         False      23m     


## without the fix
$ oc get co/ingress -w
NAME      VERSION                              AVAILABLE   PROGRESSING   DEGRADED   SINCE   MESSAGE
ingress   4.21.0-0.nightly-2025-11-13-042845   True        False         False      34m     
ingress   4.21.0-0.nightly-2025-11-13-042845   True        True          False      35m     ingresscontroller "default" is progressing: IngressControllerProgressing: One or more status conditions indicate progressing: DeploymentRollingOut=True (DeploymentRollingOut: Waiting for router deployment rollout to finish: 1 of 2 updated replica(s) are available......
ingress   4.21.0-0.nightly-2025-11-13-042845   True        False         False      36m     

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[candita]

Sorry, I forgot to assign this a few weeks back.
/assign @bentito