Skip to content

Conversation

vrutkovs
Copy link
Member

@vrutkovs vrutkovs commented Aug 6, 2025

In order to make controller sync less often this commit reworks it:

  • remove unused informers
  • filter events - run sync when either source or target configmaps change
  • use listers instead of direct client gets
  • avoid applies unless configmap contents change

@openshift-ci openshift-ci bot requested review from deads2k and dgrisonnet August 6, 2025 08:05
Copy link
Contributor

openshift-ci bot commented Aug 6, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vrutkovs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 6, 2025
@vrutkovs vrutkovs force-pushed the nodekubeconfig-lister branch from 749cf43 to 686a4ea Compare August 6, 2025 08:30
@vrutkovs
Copy link
Member Author

vrutkovs commented Aug 6, 2025

/test e2e-short-cert-rotation

@vrutkovs vrutkovs force-pushed the nodekubeconfig-lister branch 3 times, most recently from 338d30a to a82359c Compare August 6, 2025 09:49
@vrutkovs
Copy link
Member Author

vrutkovs commented Aug 6, 2025

/test e2e-short-cert-rotation

@vrutkovs vrutkovs force-pushed the nodekubeconfig-lister branch from a82359c to d2115d0 Compare August 13, 2025 04:38
Copy link
Contributor

openshift-ci bot commented Aug 13, 2025

@vrutkovs: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/okd-scos-e2e-aws-ovn d2115d0 link false /test okd-scos-e2e-aws-ovn
ci/prow/e2e-aws-ovn d2115d0 link true /test e2e-aws-ovn
ci/prow/e2e-aws-operator-disruptive-single-node d2115d0 link false /test e2e-aws-operator-disruptive-single-node
ci/prow/e2e-gcp-operator-single-node d2115d0 link false /test e2e-gcp-operator-single-node

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants