-
Notifications
You must be signed in to change notification settings - Fork 181
OCPBUGS-60496: Use BoundServceAccountTokenVolume dy default #1896
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
OCPBUGS-60496: Use BoundServceAccountTokenVolume dy default #1896
Conversation
@lance5890: This pull request explicitly references no jira issue. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: lance5890 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @lance5890. Thanks for your PR. I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/cc @vrutkovs |
08c8a6b
to
a7c1760
Compare
Could you create a jira ticket with a more thorough description? We certainly need to discuss it first in order to avoid regressions - and consider backporting it too |
I will create a Jira ticket for this. The change has been tested in my local cluster, and I'll share more details soon. Do you think this PR deserves an |
@lance5890: This pull request references Jira Issue OCPBUGS-60496, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
Ah, yes, sure |
/jira refresh |
@vrutkovs: This pull request references Jira Issue OCPBUGS-60496, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
@lance5890: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
the related pr openshift/cluster-version-operator#660 will block the upgrade need more investigation |
/hold |
need to wait the openshift/cluster-version-operator#1225 to merge first |
runAsUser: 65534 | ||
seccompProfile: | ||
type: RuntimeDefault | ||
automountServiceAccountToken: false # here to prevent deadlock, remove in 4.9 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the automountServiceAccountToken
should be supported within cvo for upgrading
The
BoundServiceAccountTokenVolume
is enabled by default, and the auto-generated sa has also injected theservice-ca.crt
kind of post-cleanup of #1142 and openshift/kubernetes#714