Add priority field to prevent early shutdown

[CoreyCook8]

Based on the issue described here : kubernetes/kubernetes#133442

priorityClassName is currently ignored by Kubelet for static pod files so setting this value has no impact on the gracefulShutdown order causing the static pods to start to be killed as soon as shutdown begins.

To prevent this we must set priority explicitly

[openshift-ci]

Hi @CoreyCook8. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: CoreyCook8
Once this PR has been reviewed and has the lgtm label, please assign ingvagabund for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[CoreyCook8]

👋 @ingvagabund you're the recommended reviewer here, would you be able to take a look at these? 🙏 We opened 4 PRs to fix this issue, one has been merged. I linked the other two below:

openshift/cluster-kube-controller-manager-operator#865
openshift/cluster-kube-apiserver-operator#1915

[ingvagabund]

/ok-to-test

[ingvagabund]

Priority admission plugin mentions:

// if the pod contained a priority that differs from the one computed from the priority class, error

As long as the priority of system-node-critical PC does not change we are ok.

[ingvagabund]

@CoreyCook8 we need to introduce a new e2e test under https://github.com/openshift/origin/tree/main/test/extended to make sure the priority number does not change for system-node-critical. Would you be willing to go through this exercise? :)

[CoreyCook8]

👋 I created openshift/origin#30268 if you don't mind taking a look and giving an ok-to-test?

[openshift-ci]

@CoreyCook8: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-aws-operator-preferred-host	48e3986	link	true	/test e2e-aws-operator-preferred-host
ci/prow/unit	48e3986	link	true	/test unit
ci/prow/e2e-aws-ovn-serial	48e3986	link	true	/test e2e-aws-ovn-serial
ci/prow/e2e-aws-operator	48e3986	link	true	/test e2e-aws-operator
ci/prow/e2e-aws-ovn	48e3986	link	true	/test e2e-aws-ovn
ci/prow/e2e-aws-ovn-upgrade	48e3986	link	true	/test e2e-aws-ovn-upgrade

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.