Skip to content

Conversation

machine424
Copy link
Contributor

  • I added CHANGELOG entry for this change.
  • No user facing changes, so no entry in CHANGELOG was needed.

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 30, 2025
Copy link
Contributor

@simonpasquier simonpasquier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 30, 2025
Copy link
Contributor

openshift-ci bot commented Jul 30, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: machine424, simonpasquier

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [machine424,simonpasquier]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@machine424 machine424 changed the title Depppp chore: update deps to align with Kube 1.33 Jul 30, 2025
@machine424 machine424 changed the title chore: update deps to align with Kube 1.33 WIP: chore: update deps to align with Kube 1.33 Jul 31, 2025
@openshift-ci openshift-ci bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. and removed lgtm Indicates that a PR is ready to be merged. labels Jul 31, 2025
Copy link
Contributor

openshift-ci bot commented Aug 4, 2025

New changes are detected. LGTM label has been removed.

@machine424
Copy link
Contributor Author

Prometheus Kube SD is still not compatible with k8s.io/client-go 1.33

 # github.com/prometheus/prometheus/discovery/kubernetes
vendor/github.com/prometheus/prometheus/discovery/kubernetes/kubernetes.go:862:36: not enough arguments in call to cache.DefaultWatchErrorHandler
	have (*"k8s.io/client-go/tools/cache".Reflector, error)
	want (context.Context, *"k8s.io/client-go/tools/cache".Reflector, error) 

Will need to fix that upstream

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 16, 2025
@juzhao
Copy link
Contributor

juzhao commented Sep 18, 2025

see from #2656 (comment)
for the ApplyNetworkPolicy func is not in 4.20 CMO library-go, will follow your advice

If the openshift/library-go update (better done in a separate PR) will involve a lot of work and will take time, especially if it requires to bump the kube deps (I know that the prom deps would break on 1.33 e.g. #2632 (comment)), you can just put the content of https://github.com/openshift/library-go/blob/master/pkg/operator/resource/resourceapply/networking.go#L19 in a file under https://github.com/openshift/cluster-monitoring-operator/tree/main/pkg/tasks and use it in the tasks.

@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 15, 2025
Copy link
Contributor

openshift-ci bot commented Oct 16, 2025

@machine424: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/okd-scos-e2e-aws-ovn 44c5268 link false /test okd-scos-e2e-aws-ovn
ci/prow/e2e-hypershift-conformance 44c5268 link true /test e2e-hypershift-conformance
ci/prow/generate 44c5268 link true /test generate
ci/prow/ginkgo-tests 44c5268 link false /test ginkgo-tests
ci/prow/versions 44c5268 link false /test versions
ci/prow/e2e-aws-ovn-techpreview 44c5268 link true /test e2e-aws-ovn-techpreview
ci/prow/e2e-agnostic-operator 44c5268 link true /test e2e-agnostic-operator

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants