MON-4386,MON-4387: telemetry Collection Profile
#2694
Conversation
This profile only caters to metrics that telemetry rules rely upon. Signed-off-by: Pranshu Srivastava <[email protected]>
openshift-ci
bot
added
the
do-not-merge/work-in-progress
|
@rexagod: This pull request references MON-4386 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.21.0" version, but no target version was set. This pull request references MON-4387 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.21.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
Skipping CI for Draft Pull Request. |
openshift-ci-robot
added
the
jira/valid-reference
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rexagod The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
rexagod
force-pushed
the
MON-4386,MON-4387
branch
from
9476550 to
9c9b657
Compare
Adds in-cluster monitoring stack's telemetry metrics under the `telemetry` profile. Signed-off-by: Pranshu Srivastava <[email protected]>
rexagod
force-pushed
the
MON-4386,MON-4387
branch
from
9c9b657 to
d5f9e7e
Compare
| @@ -1,5 +1,9 @@ | |||
| # Note: This CHANGELOG is only for the monitoring team to track all monitoring related changes. Please see OpenShift release notes for official changes. | |||
|
|
|||
| ## 4.XX | |||
There was a problem hiding this comment.
Since adding external support may take a while.
|
@rexagod: This pull request references MON-4386 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.21.0" version, but no target version was set. This pull request references MON-4387 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.21.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@rexagod: This pull request references MON-4386 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.21.0" version, but no target version was set. This pull request references MON-4387 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.21.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
rexagod
changed the title
telemetry profile and add support for in-house componentstelemetry Collection Profile
2 participants
Both of these changes need to be merged together. Additionally, MON-4788 also needs to be merged with these (once it's pushed).
Marked as draft for now as this needs all non-in-cluster-monitoring-stack recording rules ported to monitors as well.
Not 100% sure right now without investigating more on this, but I believe we can keep the existing machinery, i.e., the whitelisted machinery in CMO and everything from that point on as is, as that would serve as (a) a safeguard to make sure we pipe out the same rules and (b) a check to make sure the metrics (rules) being collected match the rules being sent out. But this will be worked on later once we start adding tests for this in origin (after the aforementioned porting effort is done).