-
Notifications
You must be signed in to change notification settings - Fork 380
MON-4398: Enable UTF-8 by default in admission-webhook #2704
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
@slashpai: This pull request references MON-4398 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/skip |
/retest-required |
Signed-off-by: Jayapriya Pai <[email protected]>
Signed-off-by: Jayapriya Pai <[email protected]>
Assisted-by: Cursor Signed-off-by: Jayapriya Pai <[email protected]>
@simonpasquier I removed amcfg test should be good now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: simonpasquier, slashpai The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest-required |
/skip |
/test e2e-hypershift-conformance |
/retest-required |
@slashpai: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Ref: prometheus-operator v0.86.0 introduced the new flag to admission webhook to choose between validation scheme.
https://github.com/prometheus-operator/prometheus-operator/blob/cc19d0e3fc10ba4e7f325d7e30bc80677a55b5fb/cmd/admission-webhook/main.go#L55