Skip to content

MON-4398: Enable UTF-8 by default in admission-webhook #2704

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 23, 2025
Merged

MON-4398: Enable UTF-8 by default in admission-webhook #2704

merged 3 commits into from
Oct 23, 2025
+44 −0

Conversation

slashpai
Copy link
Member

@slashpai slashpai commented Oct 9, 2025

Ref: prometheus-operator v0.86.0 introduced the new flag to admission webhook to choose between validation scheme.
https://github.com/prometheus-operator/prometheus-operator/blob/cc19d0e3fc10ba4e7f325d7e30bc80677a55b5fb/cmd/admission-webhook/main.go#L55

  • I added CHANGELOG entry for this change.
  • No user facing changes, so no entry in CHANGELOG was needed.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Oct 9, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Oct 9, 2025 •
edited by openshift-ci bot
Loading

@slashpai: This pull request references MON-4398 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set.

In response to this:

Ref: prometheus-operator v0.86.0 introduced the new flag to admission webhook to choose between validation scheme.
https://github.com/prometheus-operator/prometheus-operator/blob/cc19d0e3fc10ba4e7f325d7e30bc80677a55b5fb/cmd/admission-webhook/main.go#L55

  • I added CHANGELOG entry for this change.
  • No user facing changes, so no entry in CHANGELOG was needed.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 9, 2025
@slashpai
Copy link
Member Author

slashpai commented Oct 9, 2025

/skip

@slashpai
Copy link
Member Author

slashpai commented Oct 9, 2025

/retest-required

simonpasquier
simonpasquier reviewed Oct 9, 2025
View reviewed changes
@slashpai
MON-4398: Enable utf8 validation for admission webhook
7b22f5d 
Signed-off-by: Jayapriya Pai <[email protected]>
@slashpai
assets regenerate
b42d010 
Signed-off-by: Jayapriya Pai <[email protected]>
@slashpai
e2e: add test to verify utf8 support
4add0cf 
Assisted-by: Cursor
Signed-off-by: Jayapriya Pai <[email protected]>
@slashpai
Copy link
Member Author

@simonpasquier I removed amcfg test should be good now

simonpasquier
simonpasquier reviewed Oct 16, 2025
View reviewed changes
Copy link
Contributor

@simonpasquier simonpasquier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 16, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 16, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: simonpasquier, slashpai

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [simonpasquier,slashpai]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@slashpai
Copy link
Member Author

/retest-required

@simonpasquier
Copy link
Contributor

/skip

@simonpasquier
Copy link
Contributor

/test e2e-hypershift-conformance

@juzhao
Copy link
Contributor

juzhao commented Oct 20, 2025

/retest-required

1 similar comment
@juzhao
Copy link
Contributor

juzhao commented Oct 22, 2025

/retest-required

@juzhao
Copy link
Contributor

juzhao commented Oct 22, 2025

/verified by @juzhao

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Oct 22, 2025
@openshift-ci-robot
Copy link
Contributor

@juzhao: This PR has been marked as verified by @juzhao.

In response to this:

/verified by @juzhao

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD fb571fb and 2 for PR HEAD 4add0cf in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 06230e4 and 1 for PR HEAD 4add0cf in total

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 23, 2025 •
edited
Loading

@slashpai: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/ginkgo-tests 4add0cf link false /test ginkgo-tests
ci/prow/versions 4add0cf link false /test versions
ci/prow/okd-scos-e2e-aws-ovn 4add0cf link false /test okd-scos-e2e-aws-ovn

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@juzhao
Copy link
Contributor

juzhao commented Oct 23, 2025

/retest-required

@openshift-merge-bot openshift-merge-bot bot merged commit 828fe9e into openshift:main Oct 23, 2025
20 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@simonpasquier simonpasquier simonpasquier left review comments

@danielmellado danielmellado Awaiting requested review from danielmellado

Assignees

@simonpasquier simonpasquier

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@slashpai @openshift-ci-robot @simonpasquier @juzhao