OCPBUGS-45671: chore(prometheus/remotewrite): clarify that the in-cluster proxy env vars set in prometheus container can be used in all configs that support proxyConfig.proxyFromEnvironment

[machine424]

• I added CHANGELOG entry for this change.
• No user facing changes, so no entry in CHANGELOG was needed.

[machine424]

/retitle OCPBUGS-45671: chore(prometheus/remotewrite): clarify that the in-cluster proxy env vars set in prometheus container can be used in all configs that support proxyConfig.proxyFromEnvironment

[openshift-ci-robot]

@machine424: This pull request references Jira Issue OCPBUGS-45671, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.21.0) matches configured target version for branch (4.21.0)
• bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @juzhao

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

• I added CHANGELOG entry for this change.
• No user facing changes, so no entry in CHANGELOG was needed.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[danielmellado]

lgtm on the clarification side and test cleaning, but I assume that you'll add another PR with the actual setting for Oauth2? I was thinking about something in the lines of

if rw.OAuth2 != nil {
  if f.proxy.HTTPProxy() != "" || f.proxy.HTTPSProxy() != "" {
    rw.OAuth2.ProxyFromEnvironment = ptr.To(true)
  }

Was wondering whether just auto enabling that from our side would it be better, but that may imply more stuff so for now we can just explain it.

[danielmellado]

/lgtm

[simonpasquier]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: danielmellado, machine424, simonpasquier

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [danielmellado,machine424,simonpasquier]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[danielmellado]

/retest-required

[juzhao]

/retest-required

[juzhao]

/verified by @juzhao

[openshift-ci-robot]

@juzhao: This PR has been marked as verified by @juzhao.

In response to this:

/verified by @juzhao

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

@machine424: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/versions	636644a	link	false	/test versions
ci/prow/okd-scos-e2e-aws-ovn	636644a	link	false	/test okd-scos-e2e-aws-ovn
ci/prow/ginkgo-tests	636644a	link	false	/test ginkgo-tests
ci/prow/e2e-hypershift-conformance	636644a	link	true	/test e2e-hypershift-conformance

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD ffeace4 and 2 for PR HEAD 636644a in total