Skip to content

Conversation

@danielmellado
Copy link
Contributor

@danielmellado danielmellado commented Nov 27, 2025

Signed-off-by: Daniel Mellado [email protected]

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Nov 27, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Nov 27, 2025

@danielmellado: This pull request references MON-4442 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.21.0" version, but no target version was set.

In response to this:

  • I added CHANGELOG entry for this change.
  • No user facing changes, so no entry in CHANGELOG was needed.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 27, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: danielmellado

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 27, 2025
@danielmellado
Copy link
Contributor Author

/jira refresh

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Nov 27, 2025

@danielmellado: This pull request references MON-4442 which is a valid jira issue.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Copy link
Contributor

@jan--f jan--f left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm afraid this is not what I had in mind. We need to be mindful with context size and a lot here seems like low-value context for an agent (see inline comments). Some facts are wrong (CMO is deployed by CVO not OLM).

Other valuable things are missing

  • How to interact with Jira
  • how to interact with prow and prow results
  • Openshift conventions

@danielmellado danielmellado changed the title MON-4442: Add AGENTS.md to CMO WIP: MON-4442: Add AGENTS.md to CMO Nov 28, 2025
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 28, 2025
@danielmellado
Copy link
Contributor Author

Hey @jan--f this is a draft, rather than the content I think what I was looking for reviews is on the actual style. Would this just be ok in that terms? I'll address your comments in any case but I'll keep this off reviews in the contents' side until done as otherwise it doesn't make sense. Apologies for the confusion if I wasn't clear.

@danielmellado danielmellado force-pushed the add_agents_md branch 2 times, most recently from 69a4e66 to e860681 Compare November 28, 2025 16:22
Signed-off-by: Daniel Mellado <[email protected]>
@danielmellado danielmellado changed the title WIP: MON-4442: Add AGENTS.md to CMO MON-4442: Add AGENTS.md to CMO Dec 3, 2025
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 3, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 3, 2025

@danielmellado: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants