-
Notifications
You must be signed in to change notification settings - Fork 384
MON-4406: watch ClusterMonitoring config resource #2770
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
MON-4406: watch ClusterMonitoring config resource #2770
Conversation
adds a shared informer to watch the ClusterMonitoring config resource and trigger CMO reconciliation when it changes. follows the same pattern used for ConfigMaps, Secrets, and other cluster resources. the informer is only created when the ClusterMonitoringConfig feature gate is enabled.
|
@danielmellado: This pull request references MON-4406 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/cc @simonpasquier |
|
/retest-required |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: danielmellado, simonpasquier The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/verified by e2e tests we run a tech-preview job which passes. |
|
@simonpasquier: This PR has been marked as verified by In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@danielmellado: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
This PR adds a shared informer to watch the ClusterMonitoring config resource and trigger CMO reconciliation when it changes. It now follows the same pattern used for ConfigMaps, Secrets, and other cluster resources. This is only handled when the ClusterMonitingConfig feateure gate is enabled