Skip to content

Conversation

@danielmellado
Copy link
Contributor

This PR adds a shared informer to watch the ClusterMonitoring config resource and trigger CMO reconciliation when it changes. It now follows the same pattern used for ConfigMaps, Secrets, and other cluster resources. This is only handled when the ClusterMonitingConfig feateure gate is enabled

adds a shared informer to watch the ClusterMonitoring config resource
and trigger CMO reconciliation when it changes. follows the same
pattern used for ConfigMaps, Secrets, and other cluster resources.

the informer is only created when the ClusterMonitoringConfig feature
gate is enabled.
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Dec 3, 2025

@danielmellado: This pull request references MON-4406 which is a valid jira issue.

In response to this:

This PR adds a shared informer to watch the ClusterMonitoring config resource and trigger CMO reconciliation when it changes. It now follows the same pattern used for ConfigMaps, Secrets, and other cluster resources. This is only handled when the ClusterMonitingConfig feateure gate is enabled

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Dec 3, 2025
@danielmellado
Copy link
Contributor Author

/cc @simonpasquier

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 3, 2025
@danielmellado
Copy link
Contributor Author

/retest-required

@simonpasquier
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 3, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 3, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: danielmellado, simonpasquier

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [danielmellado,simonpasquier]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@simonpasquier
Copy link
Contributor

/verified by e2e tests

we run a tech-preview job which passes.

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Dec 3, 2025
@openshift-ci-robot
Copy link
Contributor

@simonpasquier: This PR has been marked as verified by e2e tests.

In response to this:

/verified by e2e tests

we run a tech-preview job which passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 3, 2025

@danielmellado: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants