Skip to content

[release-4.19] OCPBUGS-59633: E2E add test to verify guaranteed pod is running after kubelet restart #1365

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
openshift-merge-bot merged 3 commits into from
Sep 1, 2025
Merged

[release-4.19] OCPBUGS-59633: E2E add test to verify guaranteed pod is running after kubelet restart #1365

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
791a3bb
verify Guranteed pod is running after kubelet restart
Jul 11, 2025
3f02e16
avoid using indirect references and test negative pod status condition
Jul 15, 2025
2a1974f
typo fix and add more debug when pod fails
Jul 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 32 additions & 0 deletions test/e2e/performanceprofile/functests/1_performance/cpu_management.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -346,6 +346,11 @@ var _ = Describe("[rfe_id:27363][performance] CPU Management", Ordered, func() {
cpuManagerCpusetBeforeRestart, err := nodes.CpuManagerCpuSet(ctx, workerRTNode)
Expect(err).ToNot(HaveOccurred())
testlog.Infof("pre kubelet restart default cpuset: %v", cpuManagerCpusetBeforeRestart.String())

By("capturing test pod state before restart")
originalPodUID := testpod.UID
testlog.Infof("pre kubelet restart pod UID: %v", originalPodUID)

kubeletRestartCmd := []string{
"chroot",
"/rootfs",
Expand All @@ -362,6 +367,33 @@ var _ = Describe("[rfe_id:27363][performance] CPU Management", Ordered, func() {

testlog.Infof("post restart: finished cooldown time: %v", restartCooldownTime)

By("verify test pod comes back after kubelet restart")
Eventually(func() error {
var updatedPod corev1.Pod
err := testclient.DataPlaneClient.Get(ctx, client.ObjectKeyFromObject(testpod), &updatedPod)
if err != nil {
return fmt.Errorf("failed to get pod after restart: %v", err)
}

// Verify it's the same pod (same UID)
if updatedPod.UID != originalPodUID {
return fmt.Errorf("pod UID changed after restart: original=%v, current=%v", originalPodUID, updatedPod.UID)
}

// Verify pod is ready
if updatedPod.Status.Phase != corev1.PodRunning {
return fmt.Errorf("pod is not running after restart: phase=%v", updatedPod.Status.Phase)
}
// Check pod ready condition
for _, condition := range updatedPod.Status.Conditions {
if condition.Type == corev1.PodReady && condition.Status != corev1.ConditionTrue {
return fmt.Errorf("Pod condition is not in Ready state after kubelet restart: reason: %v, message: %v", condition.Reason, condition.Message)

}
}
return nil
}).WithTimeout(5*time.Minute).WithPolling(10*time.Second).Should(Succeed(), "test pod should come back after kubelet restart")
Copy link
Contributor

@MarSik MarSik Aug 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is not a bug, but the pod never went anywhere :) It should be still present and up.

Copy link
Contributor

@mrniranjan mrniranjan Aug 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, we are only checking if the pod is still in running state after kubelet restart


By("fetch Default cpuset from cpu manager state after restart")
cpuManagerCpusetAfterRestart, err := nodes.CpuManagerCpuSet(ctx, workerRTNode)
Expect(err).ToNot(HaveOccurred())
Expand Down