OCPBUGS-62632: Do not report Progressing=True during cluster scaleup or node reboot #1447
Conversation
|
Skipping CI for Draft Pull Request. |
openshift-ci
bot
added
the
do-not-merge/work-in-progress
openshift-ci-robot
added
jira/valid-reference
|
@jmencak: This pull request references Jira Issue OCPBUGS-62632, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci
bot
added
the
approved
|
/jira refresh |
openshift-ci-robot
added
jira/valid-bug
|
@jmencak: This pull request references Jira Issue OCPBUGS-62632, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Jira ([email protected]), skipping review request. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/test all |
|
/payload-job periodic-ci-openshift-release-master-ci-4.22-upgrade-from-stable-4.21-e2e-aws-ovn-upgrade |
|
@jmencak: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/7bda56e0-d9b5-11f0-8a9c-d6494fa18d6f-0 |
|
/test e2e-aws-ovn-techpreview |
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
Upgrade test looks good, no legacy-cvo-invariants test issues from |
|
/test all |
|
@jmencak: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/payload-job periodic-ci-openshift-release-master-ci-4.22-upgrade-from-stable-4.21-e2e-aws-ovn-upgrade |
|
@jmencak: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/80d32230-ec98-11f0-8481-3c171578c72f-0 |
|
After running periodic-ci-openshift-release-master-ci-4.22-upgrade-from-stable-4.21-e2e-aws-ovn-upgrade job twice, I'm not seeing any issues with [Monitor:legacy-cvo-invariants][bz-Node Tuning Operator]. |
openshift-ci-robot
added
the
verified
|
@jmencak: This PR has been marked as verified by DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@jmencak: This pull request references Jira Issue OCPBUGS-62632, which is valid. 3 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Jira ([email protected]), skipping review request. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
jmencak
force-pushed
the
4.22-OCPBUGS-62632-co-progressing
branch
from
2183008 to
a0fdb4a
Compare
openshift-ci-robot
removed
the
verified
|
/payload-job periodic-ci-openshift-release-master-ci-4.22-upgrade-from-stable-4.21-e2e-aws-ovn-upgrade |
|
@jmencak: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/6ecf5750-efb0-11f0-91d6-4442dbea1efe-0 |
…or node reboot
This change improves user's upgrade experience as outlined by
OCPSTRAT-2484 by fixing false alarms in ClusterOperator status.
The following new rule is adhered to:
* Operators should not report Progressing only because DaemonSets
owned by them are adjusting to a new node from cluster scaleup or a node
rebooting from cluster upgrade.
This is achieved by adding helper annotation
"tuned.openshift.io/last-stable-daemonset-generation" to the tuned daemonset.
Other minor fixes:
* Minor logging fix (updateTunedProfileStatus())
* Removed non-functional code from the operator initializing ClusterOperator status
Resolves: OCPBUGS-62632
jmencak
force-pushed
the
4.22-OCPBUGS-62632-co-progressing
branch
from
a0fdb4a to
06457f7
Compare
|
/payload-job periodic-ci-openshift-release-master-ci-4.22-upgrade-from-stable-4.21-e2e-aws-ovn-upgrade |
|
@jmencak: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/14e4ee40-efd7-11f0-8d58-25f10bcff945-0 |
|
No longer seeing any issues with [Monitor:legacy-cvo-invariants][bz-Node Tuning Operator]. |
openshift-ci-robot
added
the
verified
|
@jmencak: This PR has been marked as verified by DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jmencak, MarSik The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@jmencak: Jira Issue Verification Checks: Jira Issue OCPBUGS-62632 Jira Issue OCPBUGS-62632 has been moved to the MODIFIED state and will move to the VERIFIED state when the change is available in an accepted nightly payload. 🕓 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
4 participants
This change improves user's upgrade experience as outlined by OCPSTRAT-2484 by fixing false alarms in ClusterOperator status.
The following new rule is adhered to:
This is achieved by adding helper annotation
tuned.openshift.io/last-stable-daemonset-generationto the tuned daemonset.Other minor fixes:
Resolves: OCPBUGS-62632