[4.19] OCPBUGS-73797: PPC: ghw: filter out namespaces dir #1455

shajmakh · 2026-01-14T15:06:36Z

manual backport of https://github.com/openshift/cluster-node-tuning-operator/pull/1421/commits. AA was prompted to create the backport. See commits for details.

The consts are not used anywhere else so make them private. Assisted-by: Cursor v1.2.2 AI-Attribution: AIA Entirely AI, Human-initiated, Reviewed, Cursor v1.2.2 Signed-off-by: Shereen Haj <[email protected]>

The previous code fails to run PPC when there is a namespace that has a suffix `nodes`. ensure filtering the namespace directory to allow PPC to work when such namespaces exist. Assisted-by: Cursor v1.2.2 AI-Attribution: AIA Entirely AI, Human-initiated, Reviewed, Cursor v1.2.2 Signed-off-by: Shereen Haj <[email protected]>

openshift-ci-robot · 2026-01-14T15:12:48Z

@shajmakh: This pull request references Jira Issue OCPBUGS-73797, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.19.z) matches configured target version for branch (4.19.z)
bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
release note text is set and does not match the template
dependent bug Jira Issue OCPBUGS-63751 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
dependent Jira Issue OCPBUGS-63751 targets the "4.20.z" version, which is one of the valid target versions: 4.20.0, 4.20.z
bug has dependents

No GitHub users were found matching the public email listed for the QA contact in Jira ([email protected]), skipping review request.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

manual backport of https://github.com/openshift/cluster-node-tuning-operator/pull/1421/commits. AA was prompted to create the backport. See commits for details.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

shajmakh · 2026-01-14T15:12:56Z

/jira refresh

openshift-ci-robot · 2026-01-14T15:13:03Z

@shajmakh: This pull request references Jira Issue OCPBUGS-73797, which is valid.

7 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.19.z) matches configured target version for branch (4.19.z)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
release note text is set and does not match the template
dependent bug Jira Issue OCPBUGS-63751 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
dependent Jira Issue OCPBUGS-63751 targets the "4.20.z" version, which is one of the valid target versions: 4.20.0, 4.20.z
bug has dependents

No GitHub users were found matching the public email listed for the QA contact in Jira ([email protected]), skipping review request.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

shajmakh · 2026-01-14T15:13:55Z

/verified later @oblau

openshift-ci-robot · 2026-01-14T15:14:08Z

@shajmakh: This PR has been marked to be verified later by @oblau.

Details

In response to this:

/verified later @oblau

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

ffromani

/approve

openshift-ci · 2026-01-14T17:19:56Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ffromani, shajmakh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [ffromani]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

ffromani · 2026-01-14T17:29:29Z

/lgtm

yanirq · 2026-01-15T09:27:24Z

/label backport-risk-assessed

shajmakh · 2026-01-15T09:31:08Z

/retest

openshift-ci-robot · 2026-01-15T11:01:13Z

/retest-required

Remaining retests: 0 against base HEAD 1928af1 and 2 for PR HEAD 801e557 in total

shajmakh · 2026-01-15T12:36:33Z

the hypershift lane is hitting cluster infra issues
/retest

ffromani · 2026-01-16T09:21:12Z

/retest-required

openshift-ci · 2026-01-16T10:39:29Z

@shajmakh: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-hypershift-pao	`801e557`	link	true	`/test e2e-hypershift-pao`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

PPC: pkg: public consts to private

ed22c37

The consts are not used anywhere else so make them private. Assisted-by: Cursor v1.2.2 AI-Attribution: AIA Entirely AI, Human-initiated, Reviewed, Cursor v1.2.2 Signed-off-by: Shereen Haj <[email protected]>

openshift-ci bot requested review from Tal-or and yanirq January 14, 2026 15:07

shajmakh changed the title ~~PPC: ghw: filter out namespaces dir~~ [4.19] PPC: ghw: filter out namespaces dir Jan 14, 2026

shajmakh changed the title ~~[4.19] PPC: ghw: filter out namespaces dir~~ [4.19] OCPBUGS-73797: PPC: ghw: filter out namespaces dir Jan 14, 2026

openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Jan 14, 2026

openshift-ci-robot added verified-later verified Signifies that the PR passed pre-merge verification criteria labels Jan 14, 2026

ffromani reviewed Jan 14, 2026

View reviewed changes

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 14, 2026

openshift-ci bot assigned ffromani Jan 14, 2026

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 14, 2026

openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Jan 15, 2026

[4.19] OCPBUGS-73797: PPC: ghw: filter out namespaces dir #1455

Are you sure you want to change the base?

[4.19] OCPBUGS-73797: PPC: ghw: filter out namespaces dir #1455

Uh oh!

Conversation

shajmakh commented Jan 14, 2026

Uh oh!

openshift-ci-robot commented Jan 14, 2026

Uh oh!

shajmakh commented Jan 14, 2026

Uh oh!

openshift-ci-robot commented Jan 14, 2026

Uh oh!

shajmakh commented Jan 14, 2026

Uh oh!

openshift-ci-robot commented Jan 14, 2026

Uh oh!

ffromani left a comment

Choose a reason for hiding this comment

Uh oh!

openshift-ci bot commented Jan 14, 2026

Uh oh!

ffromani commented Jan 14, 2026

Uh oh!

yanirq commented Jan 15, 2026

Uh oh!

shajmakh commented Jan 15, 2026

Uh oh!

openshift-ci-robot commented Jan 15, 2026

Uh oh!

shajmakh commented Jan 15, 2026

Uh oh!

ffromani commented Jan 16, 2026

Uh oh!

openshift-ci bot commented Jan 16, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants