-
Notifications
You must be signed in to change notification settings - Fork 108
OCPBUGS-61175: Add RBAC rule to let manila-csi-driver-operator manage NetworkPolicy #615
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OCPBUGS-61175: Add RBAC rule to let manila-csi-driver-operator manage NetworkPolicy #615
Conversation
|
@mpatlasov: This pull request references Jira Issue OCPBUGS-61175, which is valid. 3 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Jira (wduan@redhat.com), skipping review request. The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mpatlasov The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/testwith openshift/csi-operator/main/e2e-openstack-manila-csi openshift/csi-operator#424 |
1 similar comment
|
/testwith openshift/csi-operator/main/e2e-openstack-manila-csi openshift/csi-operator#424 |
|
/retest-required |
|
/testwith openshift/csi-operator/main/e2e-openstack-manila-csi openshift/csi-operator#424 |
The operator needs permissions to publish and monitor NPs in the custom namespace `openshift-manila-csi-driver`. See openshift/csi-operator#424 for details.
6771b75 to
e5c46a2
Compare
|
/testwith openshift/csi-operator/main/e2e-openstack-manila-csi openshift/csi-operator#424 |
|
/lgtm |
|
/retest |
|
/test hypershift-e2e-aks |
|
/test e2e-openstack |
|
/retest |
|
@duanwei33 , as FYI, this PR is verified by testwith here. See in its job history how it failed again and again, until this PR was updated to move RBAC rule to 05_clusterrole.yaml. |
|
/retest |
|
/lgtm /test e2e-openstack |
|
/test e2e-openstack |
1 similar comment
|
/test e2e-openstack |
|
/test e2e-openstack |
3 similar comments
|
/test e2e-openstack |
|
/test e2e-openstack |
|
/test e2e-openstack |
|
@mpatlasov: This PR has been marked as verified by DetailsIn response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@mpatlasov: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
0098376
into
openshift:main
|
@mpatlasov: Jira Issue OCPBUGS-61175: Some pull requests linked via external trackers have merged: The following pull request, linked via external tracker, has not merged:
All associated pull requests must be merged or unlinked from the Jira bug in order for it to move to the next state. Once unlinked, request a bug refresh with Jira Issue OCPBUGS-61175 has not been moved to the MODIFIED state. This PR is marked as verified. If the remaining PRs listed above are marked as verified before merging, the issue will automatically be moved to VERIFIED after all of the changes from the PRs are available in an accepted nightly payload. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
…in mgmt namespace The operator needs permissions to publish and monitor NPs in the custom namespace `openshift-manila-csi-driver`. Previous PR (openshift#615) missed mgmt case.
The operator needs permissions to publish and monitor NPs in the custom namespace
openshift-manila-csi-driver. See openshift/csi-operator#424 for details.