Skip to content

Conversation

@mpatlasov
Copy link
Contributor

The operator needs permissions to publish and monitor NPs in the custom namespace openshift-manila-csi-driver. See openshift/csi-operator#424 for details.

@mpatlasov mpatlasov changed the title Add RBAC rule to let manila-csi-driver-operator manage NetworkPolicy OCPBUGS-61175: Add RBAC rule to let manila-csi-driver-operator manage NetworkPolicy Sep 4, 2025
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Sep 4, 2025
@openshift-ci-robot
Copy link
Contributor

@mpatlasov: This pull request references Jira Issue OCPBUGS-61175, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.21.0) matches configured target version for branch (4.21.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira (wduan@redhat.com), skipping review request.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

The operator needs permissions to publish and monitor NPs in the custom namespace openshift-manila-csi-driver. See openshift/csi-operator#424 for details.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 4, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mpatlasov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 4, 2025
@mpatlasov
Copy link
Contributor Author

/testwith openshift/csi-operator/main/e2e-openstack-manila-csi openshift/csi-operator#424

1 similar comment
@mpatlasov
Copy link
Contributor Author

/testwith openshift/csi-operator/main/e2e-openstack-manila-csi openshift/csi-operator#424

@mpatlasov
Copy link
Contributor Author

/retest-required

@mpatlasov
Copy link
Contributor Author

/testwith openshift/csi-operator/main/e2e-openstack-manila-csi openshift/csi-operator#424

The operator needs permissions to publish and monitor NPs in the custom namespace `openshift-manila-csi-driver`. See openshift/csi-operator#424 for details.
@mpatlasov mpatlasov force-pushed the OCPBUGS-61175-NetworkPolicies-RBAC-for-manila-csi-operator branch from 6771b75 to e5c46a2 Compare September 10, 2025 23:05
@mpatlasov
Copy link
Contributor Author

/testwith openshift/csi-operator/main/e2e-openstack-manila-csi openshift/csi-operator#424

@dobsonj
Copy link
Member

dobsonj commented Sep 11, 2025

/lgtm
/retest

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 11, 2025
@mpatlasov
Copy link
Contributor Author

/retest

@mpatlasov
Copy link
Contributor Author

/test hypershift-e2e-aks

@mpatlasov
Copy link
Contributor Author

/test e2e-openstack

@mpatlasov
Copy link
Contributor Author

/retest

@mpatlasov
Copy link
Contributor Author

@duanwei33 , as FYI, this PR is verified by testwith here. See in its job history how it failed again and again, until this PR was updated to move RBAC rule to 05_clusterrole.yaml.

@mpatlasov
Copy link
Contributor Author

/retest

@stephenfin
Copy link
Contributor

/lgtm

/test e2e-openstack

@mpatlasov
Copy link
Contributor Author

/test e2e-openstack

1 similar comment
@mpatlasov
Copy link
Contributor Author

/test e2e-openstack

@mpatlasov
Copy link
Contributor Author

/test e2e-openstack

3 similar comments
@mpatlasov
Copy link
Contributor Author

/test e2e-openstack

@mpatlasov
Copy link
Contributor Author

/test e2e-openstack

@mpatlasov
Copy link
Contributor Author

/test e2e-openstack

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Sep 19, 2025
@openshift-ci-robot
Copy link
Contributor

@mpatlasov: This PR has been marked as verified by ci.

Details

In response to this:

/verified by ci
(https://prow.ci.openshift.org/view/gs/test-platform-results/logs/multi-pr-openshift-csi-operator-424-openshift-cluster-storage-operator-615-e2e-openstack-manila-csi/1965915241460011008 )

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 19, 2025

@mpatlasov: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-openstack e5c46a2 link false /test e2e-openstack

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 0098376 into openshift:main Sep 19, 2025
21 of 22 checks passed
@openshift-ci-robot
Copy link
Contributor

@mpatlasov: Jira Issue OCPBUGS-61175: Some pull requests linked via external trackers have merged:

The following pull request, linked via external tracker, has not merged:

All associated pull requests must be merged or unlinked from the Jira bug in order for it to move to the next state. Once unlinked, request a bug refresh with /jira refresh.

Jira Issue OCPBUGS-61175 has not been moved to the MODIFIED state.

This PR is marked as verified. If the remaining PRs listed above are marked as verified before merging, the issue will automatically be moved to VERIFIED after all of the changes from the PRs are available in an accepted nightly payload.

Details

In response to this:

The operator needs permissions to publish and monitor NPs in the custom namespace openshift-manila-csi-driver. See openshift/csi-operator#424 for details.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

mpatlasov added a commit to mpatlasov/cluster-storage-operator that referenced this pull request Oct 3, 2025
…in mgmt namespace

The operator needs permissions to publish and monitor NPs in the custom namespace `openshift-manila-csi-driver`. Previous PR (openshift#615) missed mgmt case.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants