Skip to content

Conversation

@RomanBednar
Copy link
Contributor

Changes the volume-data-source-validator deployment to use imagePullPolicy: IfNotPresent instead of Always. This prevents the pod from failing with ImagePullBackOff in disconnected environments. As a result, the storage cluster operator no longer becomes degraded due to this issue.

cc @openshift/storage

@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Dec 12, 2025
@openshift-ci-robot
Copy link
Contributor

@RomanBednar: This pull request references Jira Issue OCPBUGS-67012, which is invalid:

  • expected the bug to target the "4.22.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Changes the volume-data-source-validator deployment to use imagePullPolicy: IfNotPresent instead of Always. This prevents the pod from failing with ImagePullBackOff in disconnected environments. As a result, the storage cluster operator no longer becomes degraded due to this issue.

cc @openshift/storage

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from gnufied and mpatlasov December 12, 2025 09:07
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 12, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RomanBednar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 12, 2025
@mpatlasov
Copy link
Contributor

/lgtm
/test hypershift-e2e-aks

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 13, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 13, 2025

@RomanBednar: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@duanwei33
Copy link

The volume-data-source-validator's imagePullPolicy changes to IfNotPresent now:

$ curl -s "https://gcsweb-ci.apps.ci.l2s4.p1.openshiftapps.com/gcs/test-platform-results/pr-logs/pull/openshift_cluster-storage-operator/650/pull-ci-openshift-cluster-storage-operator-main-e2e-aws-csi/1999405541872373760/artifacts/e2e-aws-csi/gather-extra/artifacts/pods.json" | jq -r '.items[] | select(.metadata.name | contains("volume-data-source-validator")) | .spec.containers[] | select(.name == "volume-data-source-validator") | .imagePullPolicy'
IfNotPresent

@duanwei33
Copy link

/verified by manual check in #650 (comment)

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Dec 15, 2025
@openshift-ci-robot
Copy link
Contributor

@duanwei33: This PR has been marked as verified by manual check in https://github.com/openshift/cluster-storage-operator/pull/650#issuecomment-3652607008.

Details

In response to this:

/verified by manual check in #650 (comment)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@duanwei33
Copy link

/jira refresh

@openshift-ci-robot
Copy link
Contributor

@duanwei33: This pull request references Jira Issue OCPBUGS-67012, which is invalid:

  • expected the bug to target the "4.22.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@duanwei33
Copy link

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Dec 15, 2025
@openshift-ci-robot
Copy link
Contributor

@duanwei33: This pull request references Jira Issue OCPBUGS-67012, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.22.0) matches configured target version for branch (4.22.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira (wduan@redhat.com), skipping review request.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@jsafrane
Copy link
Contributor

/label acknowledge-critical-fixes-only
Storage does not work in disconnected clusters.

@openshift-ci openshift-ci bot added the acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. label Dec 16, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit 3bb2da5 into openshift:main Dec 16, 2025
16 checks passed
@openshift-ci-robot
Copy link
Contributor

@RomanBednar: Jira Issue Verification Checks: Jira Issue OCPBUGS-67012
✔️ This pull request was pre-merge verified.
✔️ All associated pull requests have merged.
✔️ All associated, merged pull requests were pre-merge verified.

Jira Issue OCPBUGS-67012 has been moved to the MODIFIED state and will move to the VERIFIED state when the change is available in an accepted nightly payload. 🕓

Details

In response to this:

Changes the volume-data-source-validator deployment to use imagePullPolicy: IfNotPresent instead of Always. This prevents the pod from failing with ImagePullBackOff in disconnected environments. As a result, the storage cluster operator no longer becomes degraded due to this issue.

cc @openshift/storage

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-merge-robot
Copy link
Contributor

Fix included in accepted release 4.22.0-0.nightly-2025-12-17-101159

@RomanBednar
Copy link
Contributor Author

/cherry-pick release-4.21

@openshift-cherrypick-robot

@RomanBednar: new pull request created: #652

Details

In response to this:

/cherry-pick release-4.21

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Development

Successfully merging this pull request may close these issues.

10 participants