Skip to content

OCPBUGS-55937: Gate 4.19 -> 4.20 upgrade due to admissionregistration.k8s.io/v1beta1 API removal #1193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: release-4.19
Choose a base branch
from
Open

OCPBUGS-55937: Gate 4.19 -> 4.20 upgrade due to admissionregistration.k8s.io/v1beta1 API removal #1193

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ce8ad1b
Add upgrade gate for the removal of admissionregistration.k8s.io/v1be…
jacobsee May 14, 2025
92f05f9
group -> version
jacobsee May 14, 2025
e849cad
Strengthen language for recommendation
jacobsee May 14, 2025
9930d86
Phrasing update from "migrate" to "update"
jacobsee Jul 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions install/0000_00_cluster-version-operator_01_admingate_configmap.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,3 +8,6 @@ metadata:
include.release.openshift.io/hypershift: "true"
include.release.openshift.io/ibm-cloud-managed: "true"
include.release.openshift.io/self-managed-high-availability: "true"
data:
ack-4.19-admissionregistration-v1beta1-api-removals-in-4.20: |-
The admissionregistration.k8s.io/v1beta1 API version is deprecated in 4.19 and will be removed in 4.20. The admissionregistration.k8s.io/v1 API versions of these resources are available for use in 4.19, and it is recommended to migrate to them before upgrading to 4.20.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The admissionregistration.k8s.io/v1beta1 API version is deprecated in 4.19 and will be removed in 4.20. The admissionregistration.k8s.io/v1 API versions of these resources are available for use in 4.19, and it is recommended to migrate to them before upgrading to 4.20.
The admissionregistration.k8s.io/v1beta1 API group version is deprecated and will be removed in 4.20. Clients must instead use the corresponding resources in the admissionregistration.k8s.io/v1 group version.

Nit: "Group version" is an appropriate term for this. Also, I don't know what the style conventions are for these messages, but stronger phrasing seems appropriate for the recommendation. Ignoring it means breaking any client that depends on the old GV.