Skip to content

OCPBUGS-60568: lib/resourcemerge: Add support for automountServiceAccountToken #1264

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

OCPBUGS-60568: lib/resourcemerge: Add support for automountServiceAccountToken #1264

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions lib/resourcemerge/core.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,7 @@ func ensurePodSpec(modified *bool, existing *corev1.PodSpec, required corev1.Pod
}
}

setBoolPtr(modified, &existing.AutomountServiceAccountToken, required.AutomountServiceAccountToken)
setStringIfSet(modified, &existing.ServiceAccountName, required.ServiceAccountName)
setBool(modified, &existing.HostNetwork, required.HostNetwork)
setBoolPtr(modified, &existing.HostUsers, required.HostUsers)
Expand Down
50 changes: 50 additions & 0 deletions lib/resourcemerge/core_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,56 @@ func TestEnsurePodSpec(t *testing.T) {
HostUsers: boolPtr(false),
},
},
{
name: "automountServiceAccountToken is set",
existing: corev1.PodSpec{},
input: corev1.PodSpec{
AutomountServiceAccountToken: boolPtr(false),
},

expectedModified: true,
expected: corev1.PodSpec{
AutomountServiceAccountToken: boolPtr(false),
},
},
{
name: "automountServiceAccountToken is unset",
existing: corev1.PodSpec{
AutomountServiceAccountToken: boolPtr(false),
},
input: corev1.PodSpec{},

expectedModified: true,
expected: corev1.PodSpec{},
},
{
name: "automountServiceAccountToken is changed",
existing: corev1.PodSpec{
AutomountServiceAccountToken: boolPtr(true),
},
input: corev1.PodSpec{
AutomountServiceAccountToken: boolPtr(false),
},

expectedModified: true,
expected: corev1.PodSpec{
AutomountServiceAccountToken: boolPtr(false),
},
},
{
name: "automountServiceAccountToken is unchanged",
existing: corev1.PodSpec{
AutomountServiceAccountToken: boolPtr(false),
},
input: corev1.PodSpec{
AutomountServiceAccountToken: boolPtr(false),
},

expectedModified: false,
expected: corev1.PodSpec{
AutomountServiceAccountToken: boolPtr(false),
},
},
{
name: "PodSecurityContext empty",
existing: corev1.PodSpec{
Expand Down