Skip to content

NO-JIRA: Fix typos in RHDH Quickstarts #1010

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

NO-JIRA: Fix typos in RHDH Quickstarts #1010

wants to merge 2 commits into from

Conversation

rm3l
Copy link
Member

@rm3l rm3l commented Jul 3, 2025

This PR fixes a few typos found in the RHDH Quickstarts while working on #1009. I chose to create a different PR to address this.

/cc @christoph-jerolimov @logonoff

@rm3l rm3l changed the title fix: fix typos in RHDH Quickstarts NO-JIRA: Fix typos in RHDH Quickstarts Jul 3, 2025
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jul 3, 2025
@openshift-ci-robot
Copy link
Contributor

@rm3l: This pull request explicitly references no jira issue.

In response to this:

This PR fixes a few typos found in the RHDH Quickstarts while working on #1009. I chose to create a different PR to address this.

/cc @christoph-jerolimov @logonoff

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

christoph-jerolimov
christoph-jerolimov approved these changes Jul 4, 2025
View reviewed changes
Copy link
Member

@christoph-jerolimov christoph-jerolimov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @rm3l , lgtm!

/lgtm
/approve

@openshift-ci openshift-ci bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jul 4, 2025
@rm3l
Copy link
Member Author

rm3l commented Jul 4, 2025

/test e2e-azure-ovn-upgrade

logonoff
logonoff approved these changes Jul 4, 2025
View reviewed changes
Copy link
Member

@logonoff logonoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
no qe/px approval needed for changing content
/label px-approved
/label qe-approved

docs approval:
/assign @opayne1

@openshift-ci openshift-ci bot added px-approved Signifies that Product Support has signed off on this PR qe-approved Signifies that QE has signed off on this PR labels Jul 4, 2025
@christoph-jerolimov
Copy link
Member

/retest

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jul 26, 2025
christoph-jerolimov
christoph-jerolimov approved these changes Jul 26, 2025
View reviewed changes
Copy link
Member

@christoph-jerolimov christoph-jerolimov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 26, 2025
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jul 26, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: christoph-jerolimov, logonoff, rm3l

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jul 26, 2025

@rm3l: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ovn-single-node ea3c30f link false /test e2e-aws-ovn-single-node

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

opayne1
opayne1 reviewed Jul 29, 2025
View reviewed changes
Copy link

@opayne1 opayne1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few small comments. Thanks!

quickstarts/rhdh-installation-via-helm.yaml
@@ -194,7 +194,7 @@ spec:
2. Click on the URL decorator in the top-right corner of the "developer-hub" Deployment to open your Red Hat Developer Hub instance.
3. Verify that the correct URL is used and the Red Hat Developer Hub installation works fine.
failedTaskHelp: |-
Doublecheck your Helm Chart hostname and TLS configuration, and if needed, the external DNS configuration.
Double-check your Helm Chart hostname and TLS configuration, and if needed, the external DNS configuration.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Double-check your Helm Chart hostname and TLS configuration, and if needed, the external DNS configuration.
Double check your Helm Chart hostname and TLS configuration, and if needed, the external DNS configuration.

Just needs a space, no hyphen.

quickstarts/rhdh-installation-via-helm.yaml
summary:
success: You have upgraded your RHDH instance!
success: You have added your Red Hat Developer Hub instance to the OpenShift Console menu!
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
success: You have added your Red Hat Developer Hub instance to the OpenShift Console menu!
success: You have added your instance of Red Hat Developer Hub to the OpenShift Console menu!

Just a small reword suggestion

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@opayne1 opayne1 opayne1 left review comments

@christoph-jerolimov christoph-jerolimov christoph-jerolimov approved these changes

@logonoff logonoff logonoff approved these changes

Assignees

@christoph-jerolimov christoph-jerolimov

@logonoff logonoff

@opayne1 opayne1

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. px-approved Signifies that Product Support has signed off on this PR qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@rm3l @openshift-ci-robot @christoph-jerolimov @logonoff @opayne1