-
Notifications
You must be signed in to change notification settings - Fork 144
OCPBUGS-61432: fix(oidc): fix OIDCClientSecretGet condition #1041
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OCPBUGS-61432: fix(oidc): fix OIDCClientSecretGet condition #1041
Conversation
set the OIDCClientSecretGet condition when client secrets don't exist in the openshift-config namespace instead of the openshift-console namespace. Signed-off-by: Ahmed Abdalla <[email protected]>
/retest-required |
@devguyio: This pull request references Jira Issue OCPBUGS-61432, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/jira refresh |
@jhadvig: This pull request references Jira Issue OCPBUGS-61432, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: devguyio, jhadvig The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/verified later @yapei |
@jhadvig: This PR has been marked to be verified later by In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/cherry-pick release-4.20 |
@jhadvig: once the present PR merges, I will cherry-pick it on top of In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
1 similar comment
/retest |
@devguyio: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
@devguyio: Jira Issue OCPBUGS-61432: All pull requests linked via external trackers have merged: This pull request has the In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
@jhadvig: new pull request created: #1045 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Fix included in accepted release 4.21.0-0.nightly-2025-09-13-162334 |
Since the
Authentication
resource references CAs and Secrets in theopenshift-config
namespace, its validation should focus on theopenshift-config
namespace.However the
OIDCClientSecretGet
condition logic checks for the synced client secret, namelyconsole-oauth-config
underopenshift-console
, instead of the one referenced by theAuthentication
resource underopenshift-config
.This PR fixes this behavior.