Skip to content

[release-4.20] OCPBUGS-61578: fix(oidc): fix OIDCClientSecretGet condition #1045

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: release-4.20
Choose a base branch
from
Open

[release-4.20] OCPBUGS-61578: fix(oidc): fix OIDCClientSecretGet condition #1045

wants to merge 1 commit into from

Conversation

openshift-cherrypick-robot
Copy link

This is an automated cherry-pick of #1041

/assign jhadvig

@devguyio
fix(oidc): fix OIDCClientSecretGet condition
c3edfdd 
set the OIDCClientSecretGet condition when client secrets
don't exist in the openshift-config namespace instead of
the openshift-console namespace.

Signed-off-by: Ahmed Abdalla <[email protected]>
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Sep 11, 2025
Merged
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: Jira Issue OCPBUGS-61432 has been cloned as Jira Issue OCPBUGS-61578. Will retitle bug to link to clone.
/retitle [release-4.20] OCPBUGS-61578: fix(oidc): fix OIDCClientSecretGet condition

In response to this:

This is an automated cherry-pick of #1041

/assign jhadvig

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot changed the title [release-4.20] OCPBUGS-61432: fix(oidc): fix OIDCClientSecretGet condition [release-4.20] OCPBUGS-61578: fix(oidc): fix OIDCClientSecretGet condition Sep 11, 2025
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Sep 11, 2025
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-61578, which is invalid:

  • release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This is an automated cherry-pick of #1041

/assign jhadvig

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Sep 11, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: openshift-cherrypick-robot
Once this PR has been reviewed and has the lgtm label, please ask for approval from jhadvig. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Sep 11, 2025

@openshift-cherrypick-robot: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-console c3edfdd link true /test e2e-aws-console

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@everettraven
Copy link
Contributor

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 12, 2025
@everettraven
Copy link
Contributor

/payload-job periodic-ci-openshift-cluster-authentication-operator-release-4.20-periodics-e2e-aws-sno-external-oidc-configure-techpreview

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Sep 12, 2025

@everettraven: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-cluster-authentication-operator-release-4.20-periodics-e2e-aws-sno-external-oidc-configure-techpreview

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/7b88b610-9017-11f0-94c4-a3d1b2d2d0e7-0

@everettraven
Copy link
Contributor

/payload-job periodic-ci-openshift-cluster-authentication-operator-release-4.20-periodics-e2e-aws-sno-external-oidc-uid-extra-techpreview periodic-ci-openshift-cluster-authentication-operator-release-4.20-periodics-e2e-aws-sno-external-oidc-rollback-techpreview

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Sep 12, 2025

@everettraven: trigger 2 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-cluster-authentication-operator-release-4.20-periodics-e2e-aws-sno-external-oidc-uid-extra-techpreview
  • periodic-ci-openshift-cluster-authentication-operator-release-4.20-periodics-e2e-aws-sno-external-oidc-rollback-techpreview

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/1b132620-9018-11f0-83bb-7bfb1a90a272-0

@jhadvig
Copy link
Member

jhadvig commented Sep 15, 2025

Closing since the change for main branch will get reverted - #1046

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spadgett spadgett Awaiting requested review from spadgett

@TheRealJon TheRealJon Awaiting requested review from TheRealJon

Assignees

@jhadvig jhadvig

Labels
do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@openshift-cherrypick-robot @openshift-ci-robot @everettraven @jhadvig @devguyio