OCPBUGS-62307: Remove orphaned console-conversion-webhook deployment and related resource

[jhadvig]

Problem

The console-conversion-webhook deployment was shipped in OCP 4.16 as part of the console-operator manifests but was removed in 4.17. After upgrading from 4.16 → 4.17, the deployment and its related resources (service, secret) remain on the cluster as orphaned resources.

Solution

Adds a new MigrationCleanupController that runs at operator startup to clean up the orphaned resources:

• Deployment: console-conversion-webhook
• Service: webhook
• Secret: webhook-serving-cert

Implementation Details

• Controller runs on every startup (idempotent - safe to run multiple times)
• Uses standard Kubernetes cascade deletion (deployment deletion automatically cleans up ReplicaSets and Pods)
• Only logs when resources are actually deleted to avoid noise
• Integrated into main controller startup sequence in pkg/console/starter/starter.go
• The MigrationCleanupController will run only once when the operator starts up, and then never run again unless the operator is restarted.

Files Changed

• pkg/console/controllers/migration/cleanup_controller.go - New migration cleanup controller
• pkg/console/starter/starter.go - Integration into startup sequence

---

This ensures clean upgrades from 4.16 → 4.17 without leaving orphaned resources on the cluster.

/assign @TheRealJon

[openshift-ci-robot]

@jhadvig: This pull request references Jira Issue OCPBUGS-62307, which is invalid:

• expected the bug to target the "4.21.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

…

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jhadvig

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [jhadvig]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[jhadvig]

/jira refresh

[openshift-ci-robot]

@jhadvig: This pull request references Jira Issue OCPBUGS-62307, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.21.0) matches configured target version for branch (4.21.0)
• bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @jiajliu

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

@jhadvig: This pull request references Jira Issue OCPBUGS-62307, which is valid.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.21.0) matches configured target version for branch (4.21.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @jiajliu

In response to this:

Problem

The console-conversion-webhook deployment was shipped in OCP 4.16 as part of the console-operator manifests but was removed in 4.17. After upgrading from 4.16 → 4.17, the deployment and its related resources (service, secret) remain on the cluster as orphaned resources.

Solution

Adds a new MigrationCleanupController that runs at operator startup to clean up the orphaned resources:

• Deployment: console-conversion-webhook
• Service: webhook
• Secret: webhook-serving-cert

Implementation Details

• Controller runs on every startup (idempotent - safe to run multiple times)
• Uses standard Kubernetes cascade deletion (deployment deletion automatically cleans up ReplicaSets and Pods)
• Only logs when resources are actually deleted to avoid noise
• Integrated into main controller startup sequence in pkg/console/starter/starter.go
• The MigrationCleanupController will run only once when the operator starts up, and then never run again unless the operator is restarted.

Files Changed

• pkg/console/controllers/migration/cleanup_controller.go - New migration cleanup controller
• pkg/console/starter/starter.go - Integration into startup sequence

---

This ensures clean upgrades from 4.16 → 4.17 without leaving orphaned resources on the cluster.

/assign @TheRealJon

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[jhadvig]

/retest

[openshift-ci]

@jhadvig: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/okd-scos-e2e-aws-ovn	5d76137	link	false	/test okd-scos-e2e-aws-ovn
ci/prow/e2e-aws-ovn-single-node	5d76137	link	false	/test e2e-aws-ovn-single-node

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.