Skip to content

ODC-7806: Migrate enzyme "packages/dev-console" unit tests to React Testing Library #15335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 13, 2025
Merged

ODC-7806: Migrate enzyme "packages/dev-console" unit tests to React Testing Library #15335

merged 1 commit into from
Aug 13, 2025

Conversation

lokanandaprabhu
Copy link
Contributor

Story:

https://issues.redhat.com/browse/ODC-7806

Description:

Migrated enzyme to RTL in dev-console package

Screenshot:

image

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jul 28, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jul 28, 2025 •
edited by openshift-ci bot
Loading

@lokanandaprabhu: This pull request references ODC-7806 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set.

In response to this:

Story:

https://issues.redhat.com/browse/ODC-7806

Description:

Migrated enzyme to RTL in dev-console package

Screenshot:

image

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from Lucifergene and vikram-raj July 28, 2025 13:18
@openshift-ci openshift-ci bot added component/dev-console Related to dev-console approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jul 28, 2025
@lokanandaprabhu
Copy link
Contributor Author

/retest

2 similar comments
@lokanandaprabhu
Copy link
Contributor Author

/retest

@vikram-raj
Copy link
Member

/retest

vikram-raj
vikram-raj reviewed Aug 4, 2025
View reviewed changes
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 5, 2025
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 5, 2025
@lokanandaprabhu
Copy link
Contributor Author

Updated the PR. PTAL.

@lokanandaprabhu
Copy link
Contributor Author

/retest

vikram-raj
vikram-raj reviewed Aug 11, 2025
View reviewed changes
Copy link
Member

@vikram-raj vikram-raj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 11, 2025
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Aug 11, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lokanandaprabhu, vikram-raj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@vikram-raj
Copy link
Member

Tech debt

/label px-approved
/label docs-approved

@openshift-ci openshift-ci bot added px-approved Signifies that Product Support has signed off on this PR docs-approved Signifies that Docs has signed off on this PR labels Aug 11, 2025
@lokanandaprabhu
Copy link
Contributor Author

/retest

1 similar comment
@invincibleJai
Copy link
Member

/retest

@vikram-raj
Copy link
Member

/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Aug 12, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Aug 12, 2025 •
edited by openshift-ci bot
Loading

@lokanandaprabhu: This pull request references ODC-7806 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set.

In response to this:

Story:

https://issues.redhat.com/browse/ODC-7806

Description:

Migrated enzyme to RTL in dev-console package

Screenshot:

image

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 4ef70f3 and 2 for PR HEAD d4fffda in total

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Aug 13, 2025

@lokanandaprabhu: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 5655d72 into openshift:main Aug 13, 2025
8 checks passed
@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

Distgit: openshift-enterprise-console
This PR has been included in build openshift-enterprise-console-container-v4.20.0-202508131414.p0.g5655d72.assembly.stream.el9.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lucifergene Lucifergene Awaiting requested review from Lucifergene

1 more reviewer

@vikram-raj vikram-raj vikram-raj left review comments

Reviewers whose approvals may not affect merge requirements
Assignees

@vikram-raj vikram-raj

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. component/dev-console Related to dev-console docs-approved Signifies that Docs has signed off on this PR jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. px-approved Signifies that Product Support has signed off on this PR qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@lokanandaprabhu @openshift-ci-robot @vikram-raj @invincibleJai @openshift-bot @openshift-merge-robot