-
Notifications
You must be signed in to change notification settings - Fork 659
CONSOLE-4690: Add Manifest tab to the ConsolePlugin resource details page #15347
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CONSOLE-4690: Add Manifest tab to the ConsolePlugin resource details page #15347
Conversation
frontend/packages/console-app/src/components/console-operator/ConsolePluginManifestPage.tsx
Outdated
Show resolved
Hide resolved
…ConsolePluginManifestPage.tsx Co-authored-by: logonoff <[email protected]>
frontend/packages/integration-tests-cypress/tests/app/console-plugin-manifest.cy.ts
Outdated
Show resolved
Hide resolved
frontend/packages/integration-tests-cypress/tests/app/console-plugin-manifest.cy.ts
Outdated
Show resolved
Hide resolved
frontend/packages/integration-tests-cypress/tests/app/console-plugin-manifest.cy.ts
Outdated
Show resolved
Hide resolved
/cc @logonoff |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good! just a few more nits
frontend/packages/console-app/src/components/console-operator/ConsolePluginManifestPage.tsx
Outdated
Show resolved
Hide resolved
frontend/packages/console-app/src/components/console-operator/ConsolePluginManifestPage.tsx
Outdated
Show resolved
Hide resolved
frontend/packages/console-app/src/components/console-operator/ConsolePluginManifestPage.tsx
Outdated
Show resolved
Hide resolved
frontend/packages/console-app/src/components/console-operator/ConsolePluginManifestPage.tsx
Outdated
Show resolved
Hide resolved
frontend/packages/console-app/src/components/console-operator/ConsolePluginManifestPage.tsx
Show resolved
Hide resolved
…fest-tab-to-console-plugin
Co-authored-by: logonoff <[email protected]>
…ConsolePluginManifestPage.tsx Co-authored-by: logonoff <[email protected]>
frontend/packages/console-app/src/components/console-operator/ConsolePluginManifestPage.tsx
Outdated
Show resolved
Hide resolved
…ConsolePluginManifestPage.tsx Co-authored-by: logonoff <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Leo6Leo, logonoff The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/label tide/merge-method-squash |
/retest |
/retest-required |
/retest |
/jira refresh |
@Leo6Leo: No Jira issue is referenced in the title of this pull request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/jira refresh |
@Leo6Leo: No Jira issue is referenced in the title of this pull request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/retitle CONSOLE-4690: Add Manifest tab to the ConsolePlugin resource details page |
@Leo6Leo: This pull request references CONSOLE-4690 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/assign @yapei |
@Leo6Leo: This pull request references CONSOLE-4690 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/retest |
/label px-approved |
@Leo6Leo: This pull request references CONSOLE-4690 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/label docs-approved |
@Leo6Leo: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Description
Implement the manifest tab for the ConsolePlugin details page using PatternFly 6's CodeEditor component.
The example impacted page path is http://localhost:9000/k8s/cluster/console.openshift.io~v1~ConsolePlugin/console-demo-plugin/plugin-manifest
Steps to test
Prerequisite:
Please make sure you build both front end and backend before proceeding.
console-demo-plugin
9001
http://localhost:9000/k8s/cluster/console.openshift.io~v1~ConsolePlugin/console-demo-plugin/plugin-manifest
Demo
Before

After
