Skip to content

Conversation

Leo6Leo
Copy link
Contributor

@Leo6Leo Leo6Leo commented Jul 30, 2025

Description

Implement the manifest tab for the ConsolePlugin details page using PatternFly 6's CodeEditor component.

The example impacted page path is http://localhost:9000/k8s/cluster/console.openshift.io~v1~ConsolePlugin/console-demo-plugin/plugin-manifest

Steps to test

Prerequisite:
Please make sure you build both front end and backend before proceeding.

  1. Build the console-demo-plugin
cd dynamic-demo-plugin
yarn install
yarn build
  1. Run the plugin http server on port 9001
yarn http-server
  1. Create the consoleplugin Custom Resource
oc apply -f oc-manifest.yaml
  1. Configure the cluster to be no_auth for development purposes
source ./contrib/oc-environment.sh 
  1. Run the bridge server
 ./bin/bridge -plugins=console-demo-plugin=http://localhost:9001 -i18n-namespaces=plugin__console-demo-plugin
  1. Visit the following url to see the difference
    http://localhost:9000/k8s/cluster/console.openshift.io~v1~ConsolePlugin/console-demo-plugin/plugin-manifest

Demo

Before
Screenshot 2025-07-30 at 3 45 23 PM


After
image

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 30, 2025
@openshift-ci openshift-ci bot requested review from kyoto and spadgett July 30, 2025 19:48
@openshift-ci openshift-ci bot added the component/core Related to console core functionality label Jul 30, 2025
@openshift-ci openshift-ci bot added the kind/cypress Related to Cypress e2e integration testing label Aug 1, 2025
@Leo6Leo Leo6Leo changed the title [WIP] CONSOLE-4690 - Add Manifest tab to the ConsolePlugin resource details page CONSOLE-4690 - Add Manifest tab to the ConsolePlugin resource details page Aug 1, 2025
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 1, 2025
…ConsolePluginManifestPage.tsx

Co-authored-by: logonoff <[email protected]>
@Leo6Leo
Copy link
Contributor Author

Leo6Leo commented Aug 5, 2025

/cc @logonoff

@openshift-ci openshift-ci bot requested a review from logonoff August 5, 2025 19:37
Copy link
Member

@logonoff logonoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good! just a few more nits

@openshift-ci openshift-ci bot added the kind/i18n Indicates issue or PR relates to internationalization or has content that needs to be translated label Aug 6, 2025
Copy link
Member

@logonoff logonoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 6, 2025
Copy link
Contributor

openshift-ci bot commented Aug 6, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Leo6Leo, logonoff

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 6, 2025
@logonoff
Copy link
Member

logonoff commented Aug 6, 2025

/label tide/merge-method-squash

@openshift-ci openshift-ci bot added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Aug 6, 2025
@Leo6Leo
Copy link
Contributor Author

Leo6Leo commented Aug 7, 2025

/retest

@Leo6Leo
Copy link
Contributor Author

Leo6Leo commented Aug 9, 2025

/retest-required

@logonoff
Copy link
Member

logonoff commented Aug 9, 2025

/retest

@Leo6Leo
Copy link
Contributor Author

Leo6Leo commented Aug 11, 2025

/jira refresh

@openshift-ci-robot
Copy link
Contributor

@Leo6Leo: No Jira issue is referenced in the title of this pull request.
To reference a jira issue, add 'XYZ-NNN:' to the title of this pull request and request another refresh with /jira refresh.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@Leo6Leo Leo6Leo changed the title CONSOLE-4690 - Add Manifest tab to the ConsolePlugin resource details page CONSOLE-4690 Add Manifest tab to the ConsolePlugin resource details page Aug 11, 2025
@Leo6Leo
Copy link
Contributor Author

Leo6Leo commented Aug 11, 2025

/jira refresh

@openshift-ci-robot
Copy link
Contributor

@Leo6Leo: No Jira issue is referenced in the title of this pull request.
To reference a jira issue, add 'XYZ-NNN:' to the title of this pull request and request another refresh with /jira refresh.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@logonoff
Copy link
Member

logonoff commented Aug 11, 2025

/retitle CONSOLE-4690: Add Manifest tab to the ConsolePlugin resource details page

@openshift-ci openshift-ci bot changed the title CONSOLE-4690 Add Manifest tab to the ConsolePlugin resource details page CONSOLE-4690: Add Manifest tab to the ConsolePlugin resource details page Aug 11, 2025
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Aug 11, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Aug 11, 2025

@Leo6Leo: This pull request references CONSOLE-4690 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set.

In response to this:

Description

Implement the manifest tab for the ConsolePlugin details page using PatternFly 6's CodeEditor component.

The example impacted page path is http://localhost:9000/k8s/cluster/console.openshift.io~v1~ConsolePlugin/console-demo-plugin/plugin-manifest

Steps to test

Prerequisite:
Please make sure you build both front end and backend before proceeding.

  1. Build the console-demo-plugin
cd dynamic-demo-plugin
yarn install
yarn build
  1. Run the plugin http server on port 9001
yarn http-server
  1. Create the consoleplugin Custom Resource
oc apply -f oc-manifest.yaml
  1. Configure the cluster to be no_auth for development purposes
source ./contrib/oc-environment.sh 
  1. Run the bridge server
./bin/bridge -plugins=console-demo-plugin=http://localhost:9001 -i18n-namespaces=plugin__console-demo-plugin
  1. Visit the following url to see the difference
    http://localhost:9000/k8s/cluster/console.openshift.io~v1~ConsolePlugin/console-demo-plugin/plugin-manifest

Demo

Before
Screenshot 2025-07-30 at 3 45 23 PM


After
Screenshot 2025-07-30 at 3 42 39 PM

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@Leo6Leo
Copy link
Contributor Author

Leo6Leo commented Aug 11, 2025

/assign @yapei

@yapei
Copy link
Contributor

yapei commented Aug 12, 2025

tested the new added tab functionality

  • code editor shows correct plugin manifest content
  • copy to clipboard carry content correctly
  • download JSON file works well
    no other issues found
Screenshot 2025-08-12 at 4 02 11 PM /label qe-approved

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Aug 12, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Aug 12, 2025

@Leo6Leo: This pull request references CONSOLE-4690 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set.

In response to this:

Description

Implement the manifest tab for the ConsolePlugin details page using PatternFly 6's CodeEditor component.

The example impacted page path is http://localhost:9000/k8s/cluster/console.openshift.io~v1~ConsolePlugin/console-demo-plugin/plugin-manifest

Steps to test

Prerequisite:
Please make sure you build both front end and backend before proceeding.

  1. Build the console-demo-plugin
cd dynamic-demo-plugin
yarn install
yarn build
  1. Run the plugin http server on port 9001
yarn http-server
  1. Create the consoleplugin Custom Resource
oc apply -f oc-manifest.yaml
  1. Configure the cluster to be no_auth for development purposes
source ./contrib/oc-environment.sh 
  1. Run the bridge server
./bin/bridge -plugins=console-demo-plugin=http://localhost:9001 -i18n-namespaces=plugin__console-demo-plugin
  1. Visit the following url to see the difference
    http://localhost:9000/k8s/cluster/console.openshift.io~v1~ConsolePlugin/console-demo-plugin/plugin-manifest

Demo

Before
Screenshot 2025-07-30 at 3 45 23 PM


After
Screenshot 2025-07-30 at 3 42 39 PM

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@Leo6Leo
Copy link
Contributor Author

Leo6Leo commented Aug 12, 2025

/retest

@sferich888
Copy link

/label px-approved

@openshift-ci openshift-ci bot added the px-approved Signifies that Product Support has signed off on this PR label Aug 12, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Aug 12, 2025

@Leo6Leo: This pull request references CONSOLE-4690 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set.

In response to this:

Description

Implement the manifest tab for the ConsolePlugin details page using PatternFly 6's CodeEditor component.

The example impacted page path is http://localhost:9000/k8s/cluster/console.openshift.io~v1~ConsolePlugin/console-demo-plugin/plugin-manifest

Steps to test

Prerequisite:
Please make sure you build both front end and backend before proceeding.

  1. Build the console-demo-plugin
cd dynamic-demo-plugin
yarn install
yarn build
  1. Run the plugin http server on port 9001
yarn http-server
  1. Create the consoleplugin Custom Resource
oc apply -f oc-manifest.yaml
  1. Configure the cluster to be no_auth for development purposes
source ./contrib/oc-environment.sh 
  1. Run the bridge server
./bin/bridge -plugins=console-demo-plugin=http://localhost:9001 -i18n-namespaces=plugin__console-demo-plugin
  1. Visit the following url to see the difference
    http://localhost:9000/k8s/cluster/console.openshift.io~v1~ConsolePlugin/console-demo-plugin/plugin-manifest

Demo

Before
Screenshot 2025-07-30 at 3 45 23 PM


After
image

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@opayne1
Copy link
Contributor

opayne1 commented Aug 12, 2025

/label docs-approved

@openshift-ci openshift-ci bot added the docs-approved Signifies that Docs has signed off on this PR label Aug 12, 2025
Copy link
Contributor

openshift-ci bot commented Aug 12, 2025

@Leo6Leo: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/okd-scos-e2e-aws-ovn 3cb0661 link unknown /test okd-scos-e2e-aws-ovn

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit adce6ad into openshift:main Aug 13, 2025
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. component/core Related to console core functionality docs-approved Signifies that Docs has signed off on this PR jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. kind/cypress Related to Cypress e2e integration testing kind/i18n Indicates issue or PR relates to internationalization or has content that needs to be translated lgtm Indicates that a PR is ready to be merged. px-approved Signifies that Product Support has signed off on this PR qe-approved Signifies that QE has signed off on this PR tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants