CONSOLE-4607: Drop createModalLauncher from knative-plugin and use useOverlay hook instead

[vikram-raj]

Fixes: https://issues.redhat.com/browse/CONSOLE-4607

Drop the use of createModalLauncher from the knative-plugin package

[openshift-ci-robot]

@vikram-raj: This pull request references CONSOLE-4607 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set.

In response to this:

Fixes: https://issues.redhat.com/browse/CONSOLE-4607

Drop the use of createModalLauncher from the knative-plugin package

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[vikram-raj]

/retest

[Mylanos]

Couple of comments with repeating patterns, otherwise lgtm

[yapei]

performed some manual testing against actions in Serverless -> Serving and Serverless -> Eventing pages, for example

• Set traffic distribution
• Add/Delete triggers
• Add/Move/Delete subscriptions
• Move sink
  No regression issues found
  /label qe-approved

[openshift-ci-robot]

@vikram-raj: This pull request references CONSOLE-4607 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set.

In response to this:

Fixes: https://issues.redhat.com/browse/CONSOLE-4607

Drop the use of createModalLauncher from the knative-plugin package

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[Mylanos]

FE tests are failing, mostly with the TypeError: (0 , factory_1.createModalLauncher) is not a function

[vikram-raj]

@Mylanos Fixed the tests and updated the PR.

[Mylanos]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Mylanos, vikram-raj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• frontend/packages/knative-plugin/OWNERS [Mylanos,vikram-raj]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[vikram-raj]

Tech debt

/label docs-approved
/label px-approved
/label acknowledge-critical-fixes-only

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD 9ee91ea and 2 for PR HEAD 93db3b7 in total

[openshift-ci]

@vikram-raj: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.