Skip to content

[release-4.18] OCPBUGS-54660: Added patternfly/react-topology to shared module list of dynamic plugin sdk #15371

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 26, 2025
Merged

[release-4.18] OCPBUGS-54660: Added patternfly/react-topology to shared module list of dynamic plugin sdk #15371

merged 1 commit into from
Aug 26, 2025

Conversation

pcbailey
Copy link
Contributor

@pcbailey pcbailey commented Aug 6, 2025

This is a backport of #15039 to the 4.18 release branch.

@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Aug 6, 2025
@openshift-ci-robot
Copy link
Contributor

@pcbailey: This pull request references Jira Issue OCPBUGS-54660, which is invalid:

  • expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is ON_QA instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This is a backport of #15039 to the 4.18 release branch.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@pcbailey pcbailey force-pushed the backport-15039-to-4.18 branch from 17087c4 to 7a4722d Compare August 6, 2025 15:21
@openshift-ci openshift-ci bot requested review from spadgett and vojtechszocs August 6, 2025 15:23
@openshift-ci openshift-ci bot added the component/sdk Related to console-plugin-sdk label Aug 6, 2025
@pcbailey
Copy link
Contributor Author

pcbailey commented Aug 7, 2025

/retest

1 similar comment
@pcbailey
Copy link
Contributor Author

pcbailey commented Aug 7, 2025

/retest

@pcbailey
Copy link
Contributor Author

pcbailey commented Aug 7, 2025

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Aug 7, 2025
@openshift-ci-robot
Copy link
Contributor

@pcbailey: This pull request references Jira Issue OCPBUGS-54660, which is valid.

7 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.18.z) matches configured target version for branch (4.18.z)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note type set to "Release Note Not Required"
  • dependent bug Jira Issue OCPBUGS-60133 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
  • dependent Jira Issue OCPBUGS-60133 targets the "4.19.0" version, which is one of the valid target versions: 4.19.0, 4.19.z
  • bug has dependents

Requesting review from QA contact:
/cc @yapei

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested a review from yapei August 7, 2025 13:09
@pcbailey
Copy link
Contributor Author

pcbailey commented Aug 7, 2025

/retest

3 similar comments
@vikram-raj
Copy link
Member

/retest

@pcbailey
Copy link
Contributor Author

/retest

@pcbailey
Copy link
Contributor Author

/retest

@pcbailey pcbailey force-pushed the backport-15039-to-4.18 branch 2 times, most recently from 3f18f85 to 6f2f044 Compare August 19, 2025 18:30
spadgett
spadgett reviewed Aug 19, 2025
View reviewed changes
Copy link
Member

@spadgett spadgett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

Approving the change, but looks like there are build error @pcbailey

cc @vojtechszocs

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 19, 2025
@openshift-ci-robot openshift-ci-robot mentioned this pull request Aug 21, 2025
Merged
@vikram-raj
Copy link
Member

/retest

@pcbailey pcbailey force-pushed the backport-15039-to-4.18 branch from 6f2f044 to bd8ce6c Compare August 21, 2025 15:46
@pcbailey
Copy link
Contributor Author

/retest

@vojtechszocs
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 25, 2025
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Aug 25, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pcbailey, spadgett, vojtechszocs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

logonoff
logonoff reviewed Aug 26, 2025
View reviewed changes
Copy link
Member

@logonoff logonoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/label backport-risk-assessed

@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Aug 26, 2025
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Aug 26, 2025

@pcbailey: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 9b0a1a1 into openshift:release-4.18 Aug 26, 2025
8 checks passed
@openshift-ci-robot
Copy link
Contributor

@pcbailey: Jira Issue OCPBUGS-54660: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-54660 has been moved to the MODIFIED state.

In response to this:

This is a backport of #15039 to the 4.18 release branch.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

Distgit: openshift-enterprise-console
This PR has been included in build openshift-enterprise-console-container-v4.18.0-202508260733.p0.g9b0a1a1.assembly.stream.el9.
All builds following this will include this PR.

@openshift-merge-robot
Copy link
Contributor

Fix included in accepted release 4.18.0-0.nightly-2025-08-27-065249

@vojtechszocs vojtechszocs mentioned this pull request Sep 10, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spadgett spadgett spadgett left review comments

@vojtechszocs vojtechszocs Awaiting requested review from vojtechszocs

@yapei yapei Awaiting requested review from yapei

+1 more reviewer

@logonoff logonoff logonoff left review comments

Reviewers whose approvals may not affect merge requirements
Assignees

@vojtechszocs vojtechszocs

@yanpzhan yanpzhan

@sanketpathak sanketpathak

@yapei yapei

@XiyunZhao XiyunZhao

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. component/sdk Related to console-plugin-sdk jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.