CONSOLE-4680: Refactor bindings.jsx menuActions to accept actions fro… #15372
Conversation
openshift-ci-robot
added
the
jira/valid-reference
|
@rhamilto: This pull request references CONSOLE-4680 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci
bot
added
the
do-not-merge/work-in-progress
openshift-ci
bot
added
component/core
rhamilto
force-pushed
the
CONSOLE-4680
branch
2 times, most recently
from
994cfa2 to
a740209
Compare
openshift-ci
bot
added
the
kind/i18n
|
@rhamilto: This pull request references CONSOLE-4680 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
rhamilto
force-pushed
the
CONSOLE-4680
branch
2 times, most recently
from
6b042d0 to
cdde84b
Compare
|
@rhamilto: This pull request references CONSOLE-4680 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
rhamilto
changed the title
|
/hold for #15365 to merge first |
openshift-ci
bot
added
do-not-merge/hold
openshift-ci
bot
added
the
px-approved
|
/label docs-approved (typing is hard) |
openshift-ci
bot
added
the
docs-approved
rhamilto
changed the title
|
/test frontend |
|
/retest |
|
/retest-required |
|
Checked on cluster launched against the pr. Regression test about rolebinding related pages passed. |
openshift-ci
bot
added
the
qe-approved
|
@rhamilto: This pull request references CONSOLE-4680 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/test okd-scos-e2e-aws-ovn |
|
/retest |
frontend/packages/console-app/src/actions/hooks/useBindingActions.ts
Outdated
Show resolved
Hide resolved
frontend/packages/console-app/src/actions/hooks/useBindingActions.ts
Outdated
Show resolved
Hide resolved
|
/unhold |
openshift-ci
bot
removed
the
do-not-merge/hold
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: logonoff, rhamilto The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
|
/test okd-scos-e2e-aws-ovn |
|
/retest |
1 similar comment
|
@rhamilto: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
[ART PR BUILD NOTIFIER] Distgit: openshift-enterprise-console |
…m provider
Includes
useWarningModal.tsxfrom https://github.com/openshift/console/pull/15365/files#diff-8f5cae4fe6c6181bcd0ee8cf45de4e7134705e9b43042cf3003eadc618fb8db4, so #15365 should merge first.Additional changes:
bindings.jsxtobindings.tsx(note there are a fewanytypes in there as I didn't want to spend too much more time on the conversion effort)Create RoleBindingform to use PatternFly (screenshot below)