Skip to content

NO-JIRA: Remove yarn-generate from post-install script #15373

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

NO-JIRA: Remove yarn-generate from post-install script #15373

wants to merge 1 commit into from
+3 −4

Conversation

TheRealJon
Copy link
Member

@TheRealJon TheRealJon commented Aug 6, 2025 •
edited
Loading

This is a build task and is repetitive when installing then immediately building, which is a very common use case.

  • remove yarn generate from post-install script
  • add yarn generate step to Dockerfile.plugins.demo

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Aug 6, 2025
@openshift-ci-robot
Copy link
Contributor

@TheRealJon: This pull request explicitly references no jira issue.

In response to this:

This is a build task and is repetitive when installing then immediately building, which is a very common use case.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from Mylanos and rhamilto August 6, 2025 18:12
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 6, 2025
@rhamilto
Copy link
Member

rhamilto commented Aug 6, 2025

/retest

1 similar comment
@TheRealJon
Copy link
Member Author

/retest

@TheRealJon TheRealJon force-pushed the remove-generate-from-post-install branch from 5eecf6b to f054214 Compare August 7, 2025 16:42
@TheRealJon TheRealJon force-pushed the remove-generate-from-post-install branch from f054214 to 182e488 Compare August 7, 2025 16:45
@TheRealJon
Copy link
Member Author

/retest

2 similar comments
@Mylanos
Copy link
Contributor

Mylanos commented Aug 11, 2025

/retest

@TheRealJon
Copy link
Member Author

/retest

@TheRealJon
Copy link
Member Author

/retest

cluster install failed

@TheRealJon
Copy link
Member Author

/retest

@Mylanos
Copy link
Contributor

Mylanos commented Aug 14, 2025

/test okd-scos-e2e-aws-ovn

@Mylanos
Copy link
Contributor

Mylanos commented Aug 14, 2025

Should we update the Dockerfile.plugins.demo2 as well?

@vojtechszocs
Copy link
Contributor

Should we update the Dockerfile.plugins.demo2 as well?

@Mylanos That one does not need an update, since it skips the "build demo plugin" part in favor of reusing the existing files.

@Mylanos
Copy link
Contributor

Mylanos commented Aug 18, 2025

/test okd-scos-e2e-aws-ovn

@Mylanos
Copy link
Contributor

Mylanos commented Aug 18, 2025

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 18, 2025
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Aug 18, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Mylanos, TheRealJon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Aug 18, 2025

@TheRealJon: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/okd-scos-e2e-aws-ovn 182e488 link false /test okd-scos-e2e-aws-ovn

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@TheRealJon
Copy link
Member Author

/label px-approved
/label docs-approved

internal tech-debt

@openshift-ci openshift-ci bot added px-approved Signifies that Product Support has signed off on this PR docs-approved Signifies that Docs has signed off on this PR labels Aug 19, 2025
@TheRealJon
Copy link
Member Author

/assign @yapei

@TheRealJon
Copy link
Member Author

QE Approver
/assign @yapei

yapei
yapei reviewed Aug 29, 2025
View reviewed changes
Dockerfile.plugins.demo
@@ -9,11 +9,10 @@ RUN mkdir -p /src/console
COPY . /src/console

WORKDIR /src/console/frontend
RUN yarn install
RUN yarn install && yarn generate
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, why do we need yarn generate here?
building demo plugin image without yarn generate also works well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mylanos Mylanos Awaiting requested review from Mylanos

@rhamilto rhamilto Awaiting requested review from rhamilto

1 more reviewer

@yapei yapei yapei left review comments

Reviewers whose approvals may not affect merge requirements
Assignees

@yapei yapei

@Mylanos Mylanos

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. docs-approved Signifies that Docs has signed off on this PR jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. px-approved Signifies that Product Support has signed off on this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@TheRealJon @openshift-ci-robot @rhamilto @Mylanos @vojtechszocs @yapei