CONSOLE-4685: Refactor CSV actions; add K8s verbs #15374

TheRealJon · 2025-08-06T21:42:18Z

Introduced new constants for Kubernetes verbs in constants.ts.
Refactored CSV action handling by removing deprecated actions and implementing useClusterServiceVersionActionProvider for managing CSV actions.
Updated console-extensions.json and package.json to reflect new action provider.
Replaced old Kebab actions with LazyActionMenu in relevant components for better action management.
Enhanced uninstall and delete modal functionality with overlays for improved user experience.

Screen.Recording.2025-08-06.at.5.46.21.PM.mov

openshift-ci-robot · 2025-08-06T21:42:22Z

@TheRealJon: This pull request references CONSOLE-4685 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set.

In response to this:

…der extension and useOverlay

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot · 2025-08-06T21:48:01Z

@TheRealJon: This pull request references CONSOLE-4685 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set.

In response to this:

…der extension and useOverlay

Screen.Recording.2025-08-06.at.5.46.21.PM.mov

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot · 2025-08-07T13:58:14Z

@TheRealJon: This pull request references CONSOLE-4685 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set.

In response to this:

Introduced new constants for Kubernetes verbs in constants.ts.

Added getAccessReviewResourceAttributes utility function in access-review.ts for generating access review attributes.

Refactored CSV action handling by removing deprecated actions and implementing useClusterServiceVersionActionProvider for managing CSV actions.

Updated console-extensions.json and package.json to reflect new action provider.

Replaced old Kebab actions with LazyActionMenu in relevant components for better action management.

Enhanced uninstall modal functionality with overlays for improved user experience.

Screen.Recording.2025-08-06.at.5.46.21.PM.mov

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot · 2025-08-07T13:58:54Z

@TheRealJon: This pull request references CONSOLE-4685 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set.

In response to this:

Introduced new constants for Kubernetes verbs in constants.ts.

Added getAccessReviewResourceAttributes utility function in access-review.ts for generating access review attributes.

Refactored CSV action handling by removing deprecated actions and implementing useClusterServiceVersionActionProvider for managing CSV actions.

Updated console-extensions.json and package.json to reflect new action provider.

Replaced old Kebab actions with LazyActionMenu in relevant components for better action management.

Enhanced uninstall and delete modal functionality with overlays for improved user experience.

Screen.Recording.2025-08-06.at.5.46.21.PM.mov

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

TheRealJon · 2025-08-07T15:39:36Z

QE Approver
/assign @yapei

Docs Approver:
/assign @opayne1

PX Approver:
/assign @sferich888

yapei · 2025-08-12T00:01:54Z

@TheRealJon i18n issues is causing CI tests to fail

yapei · 2025-08-12T05:14:29Z

Ran regression testings about Uninstall Operator, Delete Operands during uninstall, Delete ClusterServiceVersion, Edit Subscription actions, no issues found

/label qe-approved

openshift-ci-robot · 2025-08-12T05:14:34Z

@TheRealJon: This pull request references CONSOLE-4685 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set.

In response to this:

Introduced new constants for Kubernetes verbs in constants.ts.

Added getAccessReviewResourceAttributes utility function in access-review.ts for generating access review attributes.

Refactored CSV action handling by removing deprecated actions and implementing useClusterServiceVersionActionProvider for managing CSV actions.

Updated console-extensions.json and package.json to reflect new action provider.

Replaced old Kebab actions with LazyActionMenu in relevant components for better action management.

Enhanced uninstall and delete modal functionality with overlays for improved user experience.

Screen.Recording.2025-08-06.at.5.46.21.PM.mov

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

spadgett · 2025-08-14T10:21:09Z

/label plugin-api-approved

TheRealJon · 2025-08-15T15:42:11Z

/retest

opayne1 · 2025-08-15T19:45:26Z

/label docs-approved

Mylanos

Just small questions/comments otherwise LGTM

Mylanos · 2025-08-14T11:19:47Z

...nd/packages/operator-lifecycle-manager/src/actions/useClusterServiceVersionActionProvider.ts

+    [subscription],
+  );
+
+  const actions = useMemo(() => {


We have been splitting these actions into separate hooks, I don't have strong opinion on this as its more than likely that these actions won't be shared/used anywhere else, so it's fine for me to keep them here, just a note.

frontend/packages/operator-lifecycle-manager/src/status/csv-status.ts

frontend/packages/console-shared/src/utils/access-review.ts

- Introduced new constants for Kubernetes verbs in `constants.ts`. - Added `getAccessReviewResourceAttributes` utility function in `access-review.ts` for generating access review attributes. - Refactored CSV action handling by removing deprecated actions and implementing `useClusterServiceVersionActionProvider` for managing CSV actions. - Updated `console-extensions.json` and `package.json` to reflect new action provider. - Replaced old Kebab actions with `LazyActionMenu` in relevant components for better action management. - Enhanced uninstall modal functionality with overlays for improved user experience.

TheRealJon · 2025-08-18T20:38:13Z

@Mylanos I've addressed your feedback. Could you please take another look 👀

TheRealJon · 2025-08-18T20:38:41Z

/label tide/merge-method-squash

Mylanos · 2025-08-19T07:04:52Z

/retest

Mylanos · 2025-08-19T12:54:51Z

/lgtm

openshift-ci · 2025-08-19T12:55:27Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Mylanos, TheRealJon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~frontend/OWNERS~~ [Mylanos,TheRealJon]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci-robot · 2025-08-19T14:19:57Z

@TheRealJon: This pull request references CONSOLE-4685 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set.

In response to this:

Introduced new constants for Kubernetes verbs in constants.ts.

Refactored CSV action handling by removing deprecated actions and implementing useClusterServiceVersionActionProvider for managing CSV actions.

Updated console-extensions.json and package.json to reflect new action provider.

Replaced old Kebab actions with LazyActionMenu in relevant components for better action management.

Enhanced uninstall and delete modal functionality with overlays for improved user experience.

Screen.Recording.2025-08-06.at.5.46.21.PM.mov

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot · 2025-08-19T22:06:41Z

/retest-required

Remaining retests: 0 against base HEAD 1d0033a and 2 for PR HEAD e5caba9 in total

openshift-ci-robot · 2025-08-20T07:03:06Z

/retest-required

Remaining retests: 0 against base HEAD 08a4cbd and 2 for PR HEAD e5caba9 in total

openshift-ci-robot · 2025-08-20T14:04:58Z

/retest-required

Remaining retests: 0 against base HEAD 11adfac and 1 for PR HEAD e5caba9 in total

TheRealJon · 2025-08-20T16:23:12Z

/retest

openshift-ci · 2025-08-20T20:28:01Z

@TheRealJon: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/okd-scos-e2e-aws-ovn	`e5caba9`	link	false	`/test okd-scos-e2e-aws-ovn`

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Aug 6, 2025

openshift-ci bot requested review from spadgett and vojtechszocs August 6, 2025 21:42

openshift-ci bot assigned jhadvig, spadgett and vojtechszocs Aug 6, 2025

TheRealJon force-pushed the CONSOLE-4685 branch from bca8005 to 6fe9041 Compare August 7, 2025 13:57

TheRealJon changed the title ~~CONSOLE-4685: Refactor CSV list and details page to use action provi…~~ CONSOLE-4685: Refactor CSV actions; add K8s verbs and access review utility Aug 7, 2025

TheRealJon force-pushed the CONSOLE-4685 branch from 6fe9041 to 5f725da Compare August 7, 2025 15:11

openshift-ci bot added the kind/i18n Indicates issue or PR relates to internationalization or has content that needs to be translated label Aug 7, 2025

openshift-ci bot assigned opayne1, sferich888 and yapei Aug 7, 2025

openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Aug 12, 2025

TheRealJon force-pushed the CONSOLE-4685 branch 2 times, most recently from a4b08f9 to 2c91191 Compare August 13, 2025 20:26

TheRealJon force-pushed the CONSOLE-4685 branch from 2c91191 to eaa11d8 Compare August 13, 2025 20:33

openshift-ci bot added the plugin-api-approved Indicates a PR with plugin API changes has been approved by an API reviewer label Aug 14, 2025

TheRealJon force-pushed the CONSOLE-4685 branch from eaa11d8 to 0c30cbf Compare August 14, 2025 20:07

openshift-ci bot added the component/topology Related to topology label Aug 14, 2025

openshift-ci bot added the docs-approved Signifies that Docs has signed off on this PR label Aug 15, 2025

jhadvig added the px-approved Signifies that Product Support has signed off on this PR label Aug 18, 2025

Mylanos reviewed Aug 18, 2025

View reviewed changes

TheRealJon force-pushed the CONSOLE-4685 branch from 0c30cbf to d4baf48 Compare August 18, 2025 19:30

address feedback

e5caba9

openshift-ci bot added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Aug 18, 2025

openshift-ci bot assigned Mylanos Aug 19, 2025

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 19, 2025

TheRealJon changed the title ~~CONSOLE-4685: Refactor CSV actions; add K8s verbs and access review utility~~ CONSOLE-4685: Refactor CSV actions; add K8s verbs Aug 19, 2025

openshift-merge-bot bot merged commit 56f4245 into openshift:main Aug 20, 2025
7 of 8 checks passed

TheRealJon deleted the CONSOLE-4685 branch August 20, 2025 21:53

CONSOLE-4685: Refactor CSV actions; add K8s verbs #15374

CONSOLE-4685: Refactor CSV actions; add K8s verbs #15374

Uh oh!

Conversation

TheRealJon commented Aug 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci-robot commented Aug 6, 2025 • edited by openshift-ci bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci-robot commented Aug 6, 2025 • edited by openshift-ci bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci-robot commented Aug 7, 2025 • edited by openshift-ci bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci-robot commented Aug 7, 2025 • edited by openshift-ci bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TheRealJon commented Aug 7, 2025

Uh oh!

yapei commented Aug 12, 2025

Uh oh!

yapei commented Aug 12, 2025

Uh oh!

openshift-ci-robot commented Aug 12, 2025 • edited by openshift-ci bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

spadgett commented Aug 14, 2025

Uh oh!

TheRealJon commented Aug 15, 2025

Uh oh!

opayne1 commented Aug 15, 2025

Uh oh!

Mylanos left a comment

Choose a reason for hiding this comment

Uh oh!

Mylanos Aug 14, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

TheRealJon commented Aug 18, 2025

Uh oh!

TheRealJon commented Aug 18, 2025

Uh oh!

Mylanos commented Aug 19, 2025

Uh oh!

Mylanos commented Aug 19, 2025

Uh oh!

openshift-ci bot commented Aug 19, 2025

Uh oh!

openshift-ci-robot commented Aug 19, 2025 • edited by openshift-ci bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci-robot commented Aug 19, 2025

Uh oh!

openshift-ci-robot commented Aug 20, 2025

Uh oh!

openshift-ci-robot commented Aug 20, 2025

Uh oh!

TheRealJon commented Aug 20, 2025

Uh oh!

openshift-ci bot commented Aug 20, 2025

Uh oh!

Uh oh!

Uh oh!

TheRealJon commented Aug 6, 2025 •

edited

Loading

openshift-ci-robot commented Aug 6, 2025 •

edited by openshift-ci bot

Loading

openshift-ci-robot commented Aug 6, 2025 •

edited by openshift-ci bot

Loading

openshift-ci-robot commented Aug 7, 2025 •

edited by openshift-ci bot

Loading

openshift-ci-robot commented Aug 7, 2025 •

edited by openshift-ci bot

Loading

openshift-ci-robot commented Aug 12, 2025 •

edited by openshift-ci bot

Loading

openshift-ci-robot commented Aug 19, 2025 •

edited by openshift-ci bot

Loading