CONSOLE-4667: Add ResourceDataView component and related code #15375

vojtechszocs · 2025-08-07T14:02:18Z

This PR follows up on #14897 and #15057 by introducing a reusable ResourceDataView component and related code.

Existing resource list tables are not modified; there will be follow-up PRs to put this component into use.

Thanks to @rhamilto for testing the new component in CronTab plugin so we can fix any immediate issues.

openshift-ci-robot · 2025-08-07T14:02:22Z

@vojtechszocs: This pull request references CONSOLE-4667 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set.

In response to this:

Summary

This PR follows up on #14897 and #15057 by introducing reusable ResourceDataView component and related code.

Existing resource list tables are not modified; there will be follow up PRs to put this component into use.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci · 2025-08-07T14:02:51Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vojtechszocs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~frontend/OWNERS~~ [vojtechszocs]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci-robot · 2025-08-11T13:46:24Z

@vojtechszocs: This pull request references CONSOLE-4667 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set.

In response to this:

This PR follows up on #14897 and #15057 by introducing reusable ResourceDataView component and related code.

Existing resource list tables are not modified; there will be follow up PRs to put this component into use.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

vojtechszocs · 2025-08-11T13:46:31Z

/retest

frontend/packages/console-app/src/components/data-view/useResourceDataViewFilters.ts

rhamilto

A few observations from when I applied this code in openshift/console-crontab-plugin#45

frontend/packages/console-app/src/components/data-view/useResourceDataViewData.tsx

rhamilto · 2025-08-28T12:46:05Z

frontend/packages/console-app/src/components/data-view/useResourceDataViewData.tsx

+        sortFunction: sort,
+        props: {
+          className: props.classes,
+          sort: {


This results in the actions column getting sorting functionality, which is not desired. Sorting should be optional on a per column basis.

And I believe sorting is broken for all but the first column, but even there the header doesn't correctly indicate the sort direction.

openshift/console-crontab-plugin@87da69a makes sorting optional.

Still need to troubleshoot the sorting issues in useResourceDataViewSort.

Note that the hard-coded sortBy object was present in the original DataView PoC code:

CONSOLE-4529: POC PodList using DataView PF extension #14897 - file frontend/public/components/data-view-poc/DataViewPodList.tsx line 489

[WIP] Data view poc #15057 - file frontend/public/components/data-view-poc/DataViewPodList.tsx line 513

sortBy: { defaultDirection: SortByDirection.asc, direction: SortByDirection.asc, index: 0, }

I think that fixing sorting bugs (beyond any immediate issues) can be done as a follow-up.

This PR was supposed to introduce a reusable ResourceDataView component by refactoring and restructuring the original DataView PoC code.

frontend/packages/console-app/src/components/data-view/useResourceDataViewData.tsx

rhamilto · 2025-09-03T19:16:41Z

ResourceDataView.patch

includes the correct fix so the filters dropdown correctly honors hideNameLabelFilters and hideLabelFilter props.

rhamilto · 2025-09-03T19:30:09Z

Oye. One more change.

useResourceDataViewSort.patch

rhamilto · 2025-09-04T14:43:09Z

It occurs to me those patches won't apply cleanly since my directory structure in the CronTab plugin doesn't match, but at least they're there.

rhamilto · 2025-09-04T14:49:37Z

It occurs to me those patches won't apply cleanly since my directory structure in the CronTab plugin doesn't match, but at least they're there.

I think this patch should work (it should contain all the changes we discussed yesterday).

DataView.patch

openshift-ci-robot · 2025-09-04T17:38:10Z

@vojtechszocs: This pull request references CONSOLE-4667 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set.

In response to this:

This PR follows up on #14897 and #15057 by introducing a reusable ResourceDataView component and related code.

Existing resource list tables are not modified; there will be follow-up PRs to put this component into use.

Thanks to @rhamilto for testing the new component so we can fix any immediate issues.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot · 2025-09-04T17:53:52Z

@vojtechszocs: This pull request references CONSOLE-4667 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set.

In response to this:

This PR follows up on #14897 and #15057 by introducing a reusable ResourceDataView component and related code.

Existing resource list tables are not modified; there will be follow-up PRs to put this component into use.

Thanks to @rhamilto for testing the new component in CronTab plugin so we can fix any immediate issues.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

vojtechszocs · 2025-09-04T19:01:55Z

PR rebased and updated, this should cover all of the immediate issues that @rhamilto found while testing ResourceDataView component in CronTab plugin.

openshift-ci · 2025-09-04T20:34:27Z

@vojtechszocs: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/okd-scos-e2e-aws-ovn	`5ba41f2`	link	false	`/test okd-scos-e2e-aws-ovn`
ci/prow/e2e-gcp-console	`5ba41f2`	link	true	`/test e2e-gcp-console`

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

rhamilto · 2025-09-04T20:47:57Z

frontend/packages/console-app/src/components/data-view/ResourceDataView.tsx

+
+    if (!hideNameLabelFilters && !hideLabelFilter) {
+      basicFilters.push(
+        <DataViewLabelFilter key="labels" filterId="label" title={t('public~Label')} data={data} />,


Suggested change

<DataViewLabelFilter key="labels" filterId="label" title={t('public~Label')} data={data} />,

<DataViewLabelFilter key="label" filterId="label" title={t('public~Label')} data={data} />,

rhamilto · 2025-09-04T20:48:52Z

frontend/packages/console-app/src/components/data-view/ResourceDataView.tsx

+  ) : (
+    <StatusBox
+      label={label}
+      data={filteredData}


Suggested change

data={filteredData}

data={data}

rhamilto · 2025-09-04T20:49:02Z

frontend/packages/console-app/src/components/data-view/ResourceDataView.tsx

+    <StatusBox
+      label={label}
+      data={filteredData}
+      unfilteredData={data}


Suggested change

unfilteredData={data}

rhamilto · 2025-09-04T21:21:16Z

frontend/packages/console-app/src/components/data-view/types.ts

+
+export type ResourceFilters = {
+  name: string;
+  labels: string;


Suggested change

labels: string;

label: string;

In order to avoid a conflict with DataView, this needs to be label.

rhamilto · 2025-09-05T14:10:32Z

frontend/packages/console-app/src/components/data-view/ResourceDataView.tsx

+      <Tbody>
+        <Tr>
+          <Td colSpan={dataViewColumns.length}>
+            <Bullseye>{t('public~No Pods found')}</Bullseye>


Need to remove Pods from the empty state text. Ideally this will reflect the resource name, but changing to None found is probably good enough for now?

Suggested change

<Bullseye>{t('public~No Pods found')}</Bullseye>

<Bullseye>

{label ? t('public~No {{label}} found', { label }) : t('public~None found')}

</Bullseye>

Plus the related i18n diff is probably better.

openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Aug 7, 2025

openshift-ci bot requested review from cajieh and TheRealJon August 7, 2025 14:02

openshift-ci bot added the component/core Related to console core functionality label Aug 7, 2025

openshift-ci bot added kind/i18n Indicates issue or PR relates to internationalization or has content that needs to be translated approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Aug 7, 2025

vojtechszocs force-pushed the resource-data-view branch from a07ff6e to a652a44 Compare August 7, 2025 14:28

rhamilto reviewed Aug 27, 2025

View reviewed changes

frontend/packages/console-app/src/components/data-view/useResourceDataViewFilters.ts Show resolved Hide resolved

rhamilto reviewed Aug 28, 2025

View reviewed changes

vojtechszocs force-pushed the resource-data-view branch from a652a44 to e1cc748 Compare August 28, 2025 16:39

openshift-ci bot added component/sdk Related to console-plugin-sdk plugin-api-changed Categorizes a PR as containing plugin API changes labels Aug 28, 2025

openshift-ci bot assigned jhadvig, spadgett and vojtechszocs Aug 28, 2025

rhamilto reviewed Sep 2, 2025

View reviewed changes

frontend/packages/console-app/src/components/data-view/useResourceDataViewData.tsx Outdated Show resolved Hide resolved

vojtechszocs added 4 commits September 4, 2025 19:29

Add ResourceDataView component and related code

3d4fdc6

Use StatusBox to wrap ResourceDataView render output

e8b7638

Address review comments

a23bea5

Make sort optional

dd0edd2

Apply sorting fix changes as per Robb's testing

5ba41f2

vojtechszocs force-pushed the resource-data-view branch from 4e16c11 to 5ba41f2 Compare September 4, 2025 18:45

rhamilto reviewed Sep 4, 2025

View reviewed changes

rhamilto reviewed Sep 5, 2025

View reviewed changes

rhamilto mentioned this pull request Sep 5, 2025

[WIP] CONSOLE-4760: update CRD list to use ResourceDataView #15469

Open

	<DataViewLabelFilter key="labels" filterId="label" title={t('public~Label')} data={data} />,
	<DataViewLabelFilter key="label" filterId="label" title={t('public~Label')} data={data} />,

CONSOLE-4667: Add ResourceDataView component and related code #15375

Are you sure you want to change the base?

CONSOLE-4667: Add ResourceDataView component and related code #15375

Uh oh!

Conversation

vojtechszocs commented Aug 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci-robot commented Aug 7, 2025 • edited by openshift-ci bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Uh oh!

openshift-ci bot commented Aug 7, 2025

Uh oh!

openshift-ci-robot commented Aug 11, 2025 • edited by openshift-ci bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

vojtechszocs commented Aug 11, 2025

Uh oh!

Uh oh!

rhamilto left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

rhamilto Aug 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rhamilto Aug 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rhamilto Aug 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

vojtechszocs Sep 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

rhamilto commented Sep 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rhamilto commented Sep 3, 2025

Uh oh!

rhamilto commented Sep 4, 2025

Uh oh!

rhamilto commented Sep 4, 2025

Uh oh!

openshift-ci-robot commented Sep 4, 2025 • edited by openshift-ci bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci-robot commented Sep 4, 2025 • edited by openshift-ci bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

vojtechszocs commented Sep 4, 2025

Uh oh!

openshift-ci bot commented Sep 4, 2025

Uh oh!

rhamilto Sep 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rhamilto Sep 4, 2025

Choose a reason for hiding this comment

Uh oh!

rhamilto Sep 4, 2025

Choose a reason for hiding this comment

Uh oh!

rhamilto Sep 4, 2025

Choose a reason for hiding this comment

Uh oh!

rhamilto Sep 4, 2025

Choose a reason for hiding this comment

Uh oh!

rhamilto Sep 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

vojtechszocs commented Aug 7, 2025 •

edited

Loading

openshift-ci-robot commented Aug 7, 2025 •

edited by openshift-ci bot

Loading

openshift-ci-robot commented Aug 11, 2025 •

edited by openshift-ci bot

Loading

rhamilto left a comment •

edited

Loading

rhamilto Aug 28, 2025 •

edited

Loading

rhamilto Aug 28, 2025 •

edited

Loading

rhamilto Aug 29, 2025 •

edited

Loading

vojtechszocs Sep 3, 2025 •

edited

Loading

rhamilto commented Sep 3, 2025 •

edited

Loading

openshift-ci-robot commented Sep 4, 2025 •

edited by openshift-ci bot

Loading

openshift-ci-robot commented Sep 4, 2025 •

edited by openshift-ci bot

Loading

rhamilto Sep 4, 2025 •

edited

Loading

rhamilto Sep 5, 2025 •

edited

Loading