Skip to content

Conversation

logonoff
Copy link
Member

@logonoff logonoff commented Aug 7, 2025

fixes a bug where the "expand" button in podconnect doesn't work that well. it now properly fullscreens the browser

code review:
/assign @Mylanos

qe review:
/assign @yapei

/label px-approved
/label docs-approved

demo:

Screencast.From.2025-08-07.15-18-17.mp4

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Aug 7, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Aug 7, 2025

@logonoff: This pull request references CONSOLE-4713 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set.

In response to this:

fixes a bug where the "expand" button in podconnect doesn't work that well. it now properly fullscreens the browser

code review:
/assign @Mylanos

qe review:
/assign @yapei

/label px-approved
/label docs-approved

demo:

Screencast.From.2025-08-07.15-18-17.mp4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added px-approved Signifies that Product Support has signed off on this PR docs-approved Signifies that Docs has signed off on this PR labels Aug 7, 2025
@openshift-ci openshift-ci bot added component/core Related to console core functionality component/pipelines Related to pipelines-plugin approved Indicates a PR has been approved by an approver from all required OWNERS files. component/shared Related to console-shared labels Aug 7, 2025
@logonoff
Copy link
Member Author

logonoff commented Aug 7, 2025

for reference this is what PodConnect did before when "expand" is clicked:

image

@logonoff logonoff force-pushed the CONSOLE-4713-typescriptification branch from 2848dc5 to 09b913d Compare August 7, 2025 19:26
@openshift-ci openshift-ci bot added the kind/i18n Indicates issue or PR relates to internationalization or has content that needs to be translated label Aug 7, 2025
@logonoff logonoff force-pushed the CONSOLE-4713-typescriptification branch from 09b913d to 291aa51 Compare August 11, 2025 02:51
@yanpzhan
Copy link
Contributor

yanpzhan commented Aug 11, 2025

Tested against cluster launched against the pr, now terminal works well when "expand" is clicked.

@yanpzhan
Copy link
Contributor

/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Aug 11, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Aug 11, 2025

@logonoff: This pull request references CONSOLE-4713 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set.

In response to this:

fixes a bug where the "expand" button in podconnect doesn't work that well. it now properly fullscreens the browser

code review:
/assign @Mylanos

qe review:
/assign @yapei

/label px-approved
/label docs-approved

demo:

Screencast.From.2025-08-07.15-18-17.mp4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@Mylanos
Copy link
Contributor

Mylanos commented Aug 11, 2025

/retest

@Mylanos
Copy link
Contributor

Mylanos commented Aug 11, 2025

Great job, no major concerns from my end.
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 11, 2025
Copy link
Contributor

openshift-ci bot commented Aug 11, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: logonoff, Mylanos

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 2189f61 and 2 for PR HEAD 291aa51 in total

1 similar comment
@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 2189f61 and 2 for PR HEAD 291aa51 in total

Copy link
Contributor

openshift-ci bot commented Aug 12, 2025

@logonoff: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/okd-scos-e2e-aws-ovn 291aa51 link false /test okd-scos-e2e-aws-ovn

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit c44318d into openshift:main Aug 12, 2025
7 of 8 checks passed
@logonoff logonoff deleted the CONSOLE-4713-typescriptification branch August 12, 2025 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. component/core Related to console core functionality component/pipelines Related to pipelines-plugin component/shared Related to console-shared docs-approved Signifies that Docs has signed off on this PR jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. kind/i18n Indicates issue or PR relates to internationalization or has content that needs to be translated lgtm Indicates that a PR is ready to be merged. px-approved Signifies that Product Support has signed off on this PR qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants