-
Notifications
You must be signed in to change notification settings - Fork 659
CONSOLE-4713: Refactor PodConnect and Terminal to TypeScript #15377
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CONSOLE-4713: Refactor PodConnect and Terminal to TypeScript #15377
Conversation
@logonoff: This pull request references CONSOLE-4713 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
2848dc5
to
09b913d
Compare
09b913d
to
291aa51
Compare
Tested against cluster launched against the pr, now terminal works well when "expand" is clicked. |
/label qe-approved |
@logonoff: This pull request references CONSOLE-4713 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/retest |
Great job, no major concerns from my end. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: logonoff, Mylanos The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
1 similar comment
@logonoff: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
fixes a bug where the "expand" button in podconnect doesn't work that well. it now properly fullscreens the browser
code review:
/assign @Mylanos
qe review:
/assign @yapei
/label px-approved
/label docs-approved
demo:
Screencast.From.2025-08-07.15-18-17.mp4