[WIP] CONSOLE-5027: Refactor public/ Directory Components to useK8sWatchResource(s)#15954
[WIP] CONSOLE-5027: Refactor public/ Directory Components to useK8sWatchResource(s)#15954cajieh wants to merge 1 commit intoopenshift:mainfrom
Conversation
openshift-ci-robot
added
the
jira/valid-reference
|
@cajieh: This pull request references CONSOLE-5027 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci
bot
added
the
do-not-merge/work-in-progress
openshift-merge-robot
added
the
needs-rebase
|
Important Review skippedAuto reviews are limited based on label configuration. 🚫 Review skipped — only excluded labels are configured. (1)
Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the
Comment |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cajieh The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
component/monitoring
cajieh
force-pushed
the
migrate-firehose-to-hooks
branch
from
ed33b09 to
7b7d0f8
Compare
openshift-merge-robot
removed
the
needs-rebase
cajieh
force-pushed
the
migrate-firehose-to-hooks
branch
from
7b7d0f8 to
5f6e3ed
Compare
|
@cajieh: This pull request references CONSOLE-5027 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set. DetailsIn response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
cajieh
force-pushed
the
migrate-firehose-to-hooks
branch
4 times, most recently
from
7dca8dc to
b879d3d
Compare
| const resources = flags[FLAGS.CONSOLE_YAML_SAMPLE] | ||
| ? [ | ||
| { | ||
| const watchResources = flags[FLAGS.CONSOLE_YAML_SAMPLE] |
There was a problem hiding this comment.
for EditYAML we can actually simplify this even further by using useFlag and moving this into the main EditYAML component. Then we do not need EditYAML_ and WithFlagProps and all that other stuff
cajieh
force-pushed
the
migrate-firehose-to-hooks
branch
from
b879d3d to
7db7e98
Compare
| isList: false, | ||
| prop: 'obj', | ||
| }; | ||
| const objResource = useMemo<FirehoseResource>( |
There was a problem hiding this comment.
Deferring to the Firehose Type migration effort.
|
@cajieh: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
4 participants
No description provided.