OSASINFRA-3683: openstack-manila: Remove --nodeid parameter

[stephenfin]

This option is deprecated as the driver can now auto-configure this [1]. We can also remove some unnecessary quoting.

Note that we don't remove the option from the NFS driver as that is a separate binary that doesn't support this auto-configuration.

[1] kubernetes/cloud-provider-openstack#2734

Signed-off-by: Stephen Finucane [email protected]

[openshift-ci]

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

[openshift-ci-robot]

@stephenfin: This pull request references OSASINFRA-3683 which is a valid jira issue.

In response to this:

This option is deprecated as the driver can now auto-configure this [1]. We can also remove some unnecessary quoting.

Note that we don't remove the option from the NFS driver as that is a separate binary that doesn't support this auto-configuration.

[1] kubernetes/cloud-provider-openstack#2734

Signed-off-by: Stephen Finucane [email protected]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[stephenfin]

/hold

The code only just merged upstream, so this can't merge until after the next rebase of https://github.com/openshift/cloud-provider-openstack

[openshift-ci]

@stephenfin: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/hypershift-e2e-aks	f7e7099	link	true	/test hypershift-e2e-aks

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[openshift-bot]

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

[openshift-bot]

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten
/remove-lifecycle stale

[mandre]

@stephenfin is that something we want to revive?

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: stephenfin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [stephenfin]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-bot]

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

[openshift-ci]

@openshift-bot: Closed this PR.

In response to this:

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[stephenfin]

/reopen
/remove-lifecycle rotten

[openshift-ci]

@stephenfin: Reopened this PR.

In response to this:

/reopen
/remove-lifecycle rotten

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[openshift-ci-robot]

@stephenfin: This pull request references OSASINFRA-3683 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target either version "4.20." or "openshift-4.20.", but it targets "openshift-4.19" instead.

In response to this:

This option is deprecated as the driver can now auto-configure this [1]. We can also remove some unnecessary quoting.

Note that we don't remove the option from the NFS driver as that is a separate binary that doesn't support this auto-configuration.

[1] kubernetes/cloud-provider-openstack#2734

Signed-off-by: Stephen Finucane [email protected]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.