Skip to content

GIE-88: Save onBording status to userSettings#157

Open
vikram-raj wants to merge 1 commit intoopenshift:mainfrom
vikram-raj:gie-88
Open

GIE-88: Save onBording status to userSettings#157
vikram-raj wants to merge 1 commit intoopenshift:mainfrom
vikram-raj:gie-88

Conversation

@vikram-raj
Copy link
Member

Description

Updated the project name from Genie to Project Alladin in the privacy policy onboarding slide. and save the onboarding status in the userSettings configMap.

Type of Change

  • 🐛 Bug fix (non-breaking change which fixes an issue)
  • ✨ New feature (non-breaking change which adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • 📝 Documentation update
  • 🎨 UI/UX improvement
  • ♻️ Code refactoring (no functional changes)
  • ⚡ Performance improvement
  • 🧪 Test updates

Related Issues

https://issues.redhat.com/browse/GIE-88
https://issues.redhat.com/browse/GIE-128

Changes Made

  • legal notice to onboarding flow modal was already there, so just updated the project name Genie -> Project Aladdin
  • Updated OnboardingModal.tsx to save the status to the userSettings configMap
  • Updated the unit tests

Testing Done

  • Unit tests added/updated
  • Integration tests added/updated
  • Manual testing performed
  • Tested on different browsers/devices (if applicable)

Test Details:

Screenshots/Videos

onboarding-status-in-configMap.mov

Definition of Done (DOD)

Code Quality

  • Code follows project style guidelines and conventions
  • Code has been self-reviewed for logic, readability, and best practices
  • No debugging code (console.logs, commented code, etc.) left behind
  • No linter errors or warnings introduced
  • Code is properly commented where necessary

Testing

  • Unit tests added/updated and passing
  • Integration tests added/updated (if applicable)
  • Manual testing completed successfully
  • Edge cases and error scenarios tested
  • No existing tests broken by changes

Documentation

  • Code documentation updated (JSDoc, inline comments)
  • README updated (if applicable)
  • User-facing documentation updated (if applicable)
  • CHANGELOG updated (if maintained)

Review & Quality

  • PR description is clear and complete
  • All related issues are linked
  • Breaking changes are clearly documented
  • Security implications considered and addressed
  • Performance impact assessed
  • Accessibility requirements met (if UI changes)

Pre-Merge

  • All CI/CD checks passing
  • At least one approval from code owner/reviewer
  • All review comments addressed or resolved
  • Branch is up to date with target branch
  • No merge conflicts

Additional Notes

Reviewer Guidance


@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Feb 13, 2026
@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 13, 2026

@vikram-raj: This pull request references GIE-88 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set.

Details

In response to this:

Description

Updated the project name from Genie to Project Alladin in the privacy policy onboarding slide. and save the onboarding status in the userSettings configMap.

Type of Change

  • 🐛 Bug fix (non-breaking change which fixes an issue)
  • ✨ New feature (non-breaking change which adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • 📝 Documentation update
  • 🎨 UI/UX improvement
  • ♻️ Code refactoring (no functional changes)
  • ⚡ Performance improvement
  • 🧪 Test updates

Related Issues

https://issues.redhat.com/browse/GIE-88
https://issues.redhat.com/browse/GIE-128

Changes Made

  • legal notice to onboarding flow modal was already there, so just updated the project name Genie -> Project Aladdin
  • Updated OnboardingModal.tsx to save the status to the userSettings configMap
  • Updated the unit tests

Testing Done

  • Unit tests added/updated
  • Integration tests added/updated
  • Manual testing performed
  • Tested on different browsers/devices (if applicable)

Test Details:

Screenshots/Videos

onboarding-status-in-configMap.mov

Definition of Done (DOD)

Code Quality

  • Code follows project style guidelines and conventions
  • Code has been self-reviewed for logic, readability, and best practices
  • No debugging code (console.logs, commented code, etc.) left behind
  • No linter errors or warnings introduced
  • Code is properly commented where necessary

Testing

  • Unit tests added/updated and passing
  • Integration tests added/updated (if applicable)
  • Manual testing completed successfully
  • Edge cases and error scenarios tested
  • No existing tests broken by changes

Documentation

  • Code documentation updated (JSDoc, inline comments)
  • README updated (if applicable)
  • User-facing documentation updated (if applicable)
  • CHANGELOG updated (if maintained)

Review & Quality

  • PR description is clear and complete
  • All related issues are linked
  • Breaking changes are clearly documented
  • Security implications considered and addressed
  • Performance impact assessed
  • Accessibility requirements met (if UI changes)

Pre-Merge

  • All CI/CD checks passing
  • At least one approval from code owner/reviewer
  • All review comments addressed or resolved
  • Branch is up to date with target branch
  • No merge conflicts

Additional Notes

Reviewer Guidance


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci
Copy link

openshift-ci bot commented Feb 13, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vikram-raj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 13, 2026
@openshift-ci
Copy link

openshift-ci bot commented Feb 13, 2026

@vikram-raj: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/unit-tests 918eba2 link true /test unit-tests

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants