OCPBUGS-60284: Upgrading Cluster-API-Provider-Nutanix version from 1.5.4 to 1.7.0 #9869
Conversation
|
/retest-required |
|
Thanks for the PR! You have updated the code we vendor to build the capi controller binary. You should also bump the version in the top level go.mod, which is the api vendored by the installer to generate the cluster and machine manifests. I think vendoring this may be blocked, when I tested, and we need the new version of cluster api, which will be released soon. Additionally, can you update the crds like I described here: #9855 (comment) |
|
Here's the error I got when bumping That will be fixed in the next version of capi. I will play around a bit more tomorrow to see if we can bump this without newer capi |
This all have been done in this PR. |
To mitigate this. |
|
Looks like CAPI >= v1.10.0 has some breaking changes that involve the removal of that "defaulting" package (see release note and PR). Not sure if they gonna add it back 💭 Also, I think aws capi provider (capa) is not the only one blocking. When I tried bumping capa, the error now points to ibmcloud. go: finding module for package sigs.k8s.io/cluster-api/util/defaulting
go: github.com/openshift/installer/pkg/asset/machines/ibmcloud imports
sigs.k8s.io/cluster-api-provider-ibmcloud/api/v1beta2 tested by
sigs.k8s.io/cluster-api-provider-ibmcloud/api/v1beta2.test imports
sigs.k8s.io/cluster-api/util/defaulting: module sigs.k8s.io/cluster-api@latest found (v1.10.4), but does not contain package sigs.k8s.io/cluster-api/util/defaulting
This seems to help, but then it pins the capi version for all providers, right? We need make sure all providers are using the same minor versions of capi? Curious: What's the usual step/method for that? |
openshift-merge-robot
added
the
needs-rebase
Right, but ibmcloud upstream is up to date, so we may need to just bump multiple providers simultaneously. As an aside, ibmcloud upstream uses depandabot so it is very up to date, upstream is on a beta version of capi. We don't have a system/schedule/process in place for keeping capi providers up to date in sync. I don't think it's rocket science, but having a defined process would really help smooth this over. |
Hm looks like theyre not there Also needs a rebase for the go.mod., unfortunately. |
the PR has changes in /data/data/clusterapi/nutanix-infrastructure-components.yaml |
openshift-merge-robot
removed
the
needs-rebase
Oh, my bad, I am using the new GUI in github and I missed this warning: 
|
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: patrickdillon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
abhay-nutanix
changed the title
openshift-ci-robot
added
jira/valid-reference
|
@abhay-nutanix: This pull request references Jira Issue OCPBUGS-60284, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
Requesting review from QA contact: The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/jira refresh |
|
@abhay-nutanix: This pull request references Jira Issue OCPBUGS-60284, which is valid. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/retest-required |
1 similar comment
|
@abhay-nutanix: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/retest-required |
openshift-merge-bot
bot
merged commit 990be59
into
openshift:main
|
@abhay-nutanix: Jira Issue OCPBUGS-60284: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-60284 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[ART PR BUILD NOTIFIER] Distgit: ose-installer |
|
[ART PR BUILD NOTIFIER] Distgit: ose-baremetal-installer |
|
[ART PR BUILD NOTIFIER] Distgit: ose-installer-artifacts |
Installer currently uses Cluster-API-PROVIDER-NUTANIX version 1.5.4.
Upgrading it to version 1.7.0.