-
Notifications
You must be signed in to change notification settings - Fork 5
Add s390x and powerpc support to pipeline multi-arch build #220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Add s390x and powerpc support to pipeline multi-arch build #220
Conversation
Signed-off-by: Deepali Kushwah <[email protected]>
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Deepali1999 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @Deepali1999. Thanks for your PR. I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/ok-to-test
@@ -29,7 +29,7 @@ spec: | |||
value: 5d | |||
- name: build-platforms | |||
value: | |||
- linux/x86_64 | |||
- linux/x86_64,linux/s390x |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- linux/x86_64,linux/s390x | |
- linux/x86_64 | |
- linux/s390x |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And you should do the same for .tekton/kubernetes-sigs-kueue-main-push-request.yaml
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And you should do the same for .tekton/kubernetes-sigs-kueue-main-push-request.yaml
@kannon92 Thanks for the review! I've made the following changes based on your feedback:
-
Fixed YAML format to .tekton/kubernetes-sigs-kueue-main-pull-request.yaml
-
Applied same changes to push pipeline: Updated .tekton/kubernetes-sigs-kueue-main-push-request.yaml to support s390x..
Please let me know if you need any further modifications!
We are not quite ready for merge things on main as our e2e tests are still in progress. Waiting on #205 |
Signed-off-by: Deepali Kushwah <[email protected]>
/hold As I mentioned, our target for having our CI is hopefully by August 1st. I'll unhold when our CI is functionally again. Sorry about this. |
/ok-to-test |
/retest |
Signed-off-by: Deepali Kushwah <[email protected]>
Added Support for the Power. |
/ok-to-test |
@Deepali1999: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Just a heads up, you will need to apply these changes to the release-0.12 branch also? How will you verify testing for S390z and power? |
Thanks @kannon92! Release-0.12 branch: I've created a separate PR (#233) for the release-0.12 branch with the same s390x and powerpc support changes. For verification testing:
|
I mean can you run e2e with these images? Install kueue on a s390z and powerpc and make sure the images are actually functionally. |
You could run the e2e tests with the quay repo. If those pass I’d be happy with merging this. |
/lgtm Just waiting for confirmation on e2e tests on power and s390z. Once I get that, I will add my approval and remove the hold. |
PR Description
Added s390x architecture to the pipeline build platforms, enabling multi-arch image builds for s390x.
What type of PR is this?
/kind feature
What this PR does / why we need it
This PR adds
s390x
to the multi-architecture build platforms in the Tekton pipeline definition (.tekton/kubernetes-sigs-kueue-main-pull-request.yaml
).With this change, images will be built for both
linux/x86_64
andlinux/s390x
architectures, enabling support for s390x systems.Note:
Dockerfile.rhel
already supports multi-arch builds usingTARGETARCH
andTARGETPLATFORM
.