Skip to content

Add s390x and powerpc support to pipeline multi-arch build #220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

Deepali1999
Copy link

PR Description

Added s390x architecture to the pipeline build platforms, enabling multi-arch image builds for s390x.

What type of PR is this?

/kind feature

What this PR does / why we need it

This PR adds s390x to the multi-architecture build platforms in the Tekton pipeline definition (.tekton/kubernetes-sigs-kueue-main-pull-request.yaml).
With this change, images will be built for both linux/x86_64 and linux/s390x architectures, enabling support for s390x systems.

Note:

  • The Dockerfile.rhel already supports multi-arch builds using TARGETARCH and TARGETPLATFORM.
  • No changes were needed in the Dockerfile.
  • E2E tests have passed for s390x locally.

@openshift-ci openshift-ci bot added the kind/feature Categorizes issue or PR as related to a new feature. label Jul 25, 2025
@openshift-ci openshift-ci bot requested review from kannon92 and mrunalp July 25, 2025 08:56
Copy link

openshift-ci bot commented Jul 25, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Deepali1999
Once this PR has been reviewed and has the lgtm label, please assign kannon92 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jul 25, 2025
Copy link

openshift-ci bot commented Jul 25, 2025

Hi @Deepali1999. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

@kannon92 kannon92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test

@openshift-ci openshift-ci bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 25, 2025
@@ -29,7 +29,7 @@ spec:
value: 5d
- name: build-platforms
value:
- linux/x86_64
- linux/x86_64,linux/s390x

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- linux/x86_64,linux/s390x
- linux/x86_64
- linux/s390x

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And you should do the same for .tekton/kubernetes-sigs-kueue-main-push-request.yaml

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And you should do the same for .tekton/kubernetes-sigs-kueue-main-push-request.yaml

@kannon92 Thanks for the review! I've made the following changes based on your feedback:

  1. Fixed YAML format to .tekton/kubernetes-sigs-kueue-main-pull-request.yaml

  2. Applied same changes to push pipeline: Updated .tekton/kubernetes-sigs-kueue-main-push-request.yaml to support s390x..

Please let me know if you need any further modifications!

@kannon92
Copy link

We are not quite ready for merge things on main as our e2e tests are still in progress.

Waiting on #205

@kannon92
Copy link

/hold

As I mentioned, our target for having our CI is hopefully by August 1st.

I'll unhold when our CI is functionally again. Sorry about this.

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 25, 2025
@kannon92
Copy link

/ok-to-test

@kannon92
Copy link

/retest

Signed-off-by: Deepali Kushwah <[email protected]>
@Deepali1999
Copy link
Author

Added Support for the Power.

@kannon92 kannon92 changed the title Add s390x support to pipeline multi-arch build Add s390x and powerpc support to pipeline multi-arch build Aug 4, 2025
@kannon92
Copy link

kannon92 commented Aug 4, 2025

/ok-to-test

Copy link

openshift-ci bot commented Aug 4, 2025

@Deepali1999: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@kannon92
Copy link

kannon92 commented Aug 4, 2025

Just a heads up, you will need to apply these changes to the release-0.12 branch also?

How will you verify testing for S390z and power?

@Deepali1999
Copy link
Author

Deepali1999 commented Aug 5, 2025

How will you verify testing for S390z and power?

Thanks @kannon92!

Release-0.12 branch: I've created a separate PR (#233) for the release-0.12 branch with the same s390x and powerpc support changes.

For verification testing:

  1. Local testing: I've tested the builds locally using cross-compilation.
  2. CI/CD verification: The Tekton pipelines will automatically build and test on s390x/ppc64le platforms
  3. Pipeline monitoring: I'll monitor the pipeline runs to ensure they pass on both architectures.

@kannon92
Copy link

kannon92 commented Aug 5, 2025

How will you verify testing for S390z and power?

Thanks @kannon92!

Release-0.12 branch: I've created a separate PR (#233) for the release-0.12 branch with the same s390x and powerpc support changes.

For verification testing:

  1. Local testing: I've tested the builds locally using cross-compilation.
  2. CI/CD verification: The Tekton pipelines will automatically build and test on s390x/ppc64le platforms
  3. Pipeline monitoring: I'll monitor the pipeline runs to ensure they pass on both architectures.

I mean can you run e2e with these images?

Install kueue on a s390z and powerpc and make sure the images are actually functionally.

@kannon92
Copy link

kannon92 commented Aug 7, 2025

You could run the e2e tests with the quay repo. If those pass I’d be happy with merging this.

@Deepali1999
Copy link
Author

You could run the e2e tests with the quay repo. If those pass I’d be happy with merging this.

I have ran the e2e tests and it is completed successfully.

image

@kannon92
Copy link

kannon92 commented Aug 7, 2025

You could run the e2e tests with the quay repo. If those pass I’d be happy with merging this.

I have ran the e2e tests and it is completed successfully.

image

On power and s390z?

@kannon92
Copy link

kannon92 commented Aug 7, 2025

/lgtm

Just waiting for confirmation on e2e tests on power and s390z. Once I get that, I will add my approval and remove the hold.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants