Skip to content

Conversation

kannon92
Copy link

@kannon92 kannon92 commented Aug 4, 2025

Ran git merge v0.12.6 on the release-0.12 branch.

Updating to the latest released tag for 0.12.

I just add to apply 1600e7d to this merge as Kueue changed how certs are created in their kustomize.

k8s-infra-cherrypick-robot and others added 30 commits June 2, 2025 01:08
…s-sigs#5438)

* Delete namesapce AfterEach

* Delete duplicate namespace creation

---------

Co-authored-by: Michal Szadkowski <[email protected]>
…de fails" test time (kubernetes-sigs#5447)

* Fix long test time

* Rewrite if to switch

* Address comments

---------

Co-authored-by: Dominik Pajak <[email protected]>
… default localqueue (kubernetes-sigs#5460)

* block removal of localqueue label if namespace has default localqueue

* add unit tests

* fix linter error in imports

* unit test for localqueue deletion on leaderworkerset

---------

Co-authored-by: David Grove <[email protected]>
…s-sigs#5448)

* Use function instead of directly updating the cond

* Refactor the utility function

* Remove setting transitiontime to now

---------

Co-authored-by: Dominik Pajak <[email protected]>
…s-sigs#5491)

The cert-manager rotator previously used a hardcoded default
certificate directory (/tmp/k8s-webhook-server/serving-certs),
ignoring the configured webhook.certDir value. This commit updates
the logic to use the configured value if provided, falling back to
the default only when necessary.

Signed-off-by: ichekrygin <[email protected]>
Co-authored-by: ichekrygin <[email protected]>
…test (kubernetes-sigs#5577)

* Remove assertion on annotation

* Remove more assertions

---------

Co-authored-by: Dominik Pajak <[email protected]>
mimowo and others added 11 commits July 30, 2025 10:58
…cting workloads due to AdmissionCheck retry (kubernetes-sigs#6301)

* Fix evicting workloads due to AdmissionCheck retry

* Fix compilation in MultiKueue
…client-side rate limiting (kubernetes-sigs#6306)

* Support disabling client side rate limiting

Signed-off-by: Yuki Iwai <[email protected]>

* Align with controller-ruintime v0.20 specification

Signed-off-by: Yuki Iwai <[email protected]>

---------

Signed-off-by: Yuki Iwai <[email protected]>
…ed attempt (kubernetes-sigs#6330)

* Add repro test scenario that fails

* Copy requeue state from base workload to patch

---------

Co-authored-by: Patryk Bundyra <[email protected]>
Extend timeout for expected object deletions, as they happen right after Kueue rollout
Wait for Kueue availability post Kueue configuration update
…configuration. (kubernetes-sigs#6361)

* Rename metrics-cert to metrics-certs.

* Revert "Rename metrics-cert to metrics-certs."

This reverts commit 7de2344.

* Rename metrics-certs to metrics-cert.

---------

Co-authored-by: Mykhailo Bobrovskyi <[email protected]>
@openshift-ci openshift-ci bot requested review from akram and sohankunkerkar August 4, 2025 20:36
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 4, 2025
@kannon92 kannon92 changed the title Sync 0 12 6 Update release branch to v0.12.6 Aug 4, 2025
@MaysaMacedo
Copy link

In general it LGTM.
I'm just wondering why we need this commit 5c80a38?
I took a look in upstream and didn't spot that folder https://github.com/kubernetes-sigs/kueue/tree/v0.12.6/hack/internal/tools

@MaysaMacedo
Copy link

Is there any plan to make this syncing of branch automatic?

@kannon92
Copy link
Author

kannon92 commented Aug 9, 2025

In general it LGTM. I'm just wondering why we need this commit 5c80a38? I took a look in upstream and didn't spot that folder https://github.com/kubernetes-sigs/kueue/tree/v0.12.6/hack/internal/tools

Yea, upstream doesn’t vendor hack/internal/tools. So it’s added in our fork.

@kannon92
Copy link
Author

kannon92 commented Aug 9, 2025

Is there any plan to make this syncing of branch automatic?

Any ideas how to do that?

Copy link

@MaysaMacedo MaysaMacedo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 11, 2025
Copy link

openshift-ci bot commented Aug 11, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kannon92, MaysaMacedo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [MaysaMacedo,kannon92]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kannon92
Copy link
Author

/test e2e-aws-ocp-4-18

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 8efa7c5 and 2 for PR HEAD 5c80a38 in total

@kannon92
Copy link
Author

/retest

Copy link

openshift-ci bot commented Aug 11, 2025

@kannon92: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 084cd75 into openshift:release-0.12 Aug 11, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.