Skip to content

OCPBUGS-45214: Add groupsnapshot tests #2155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 28, 2025
Merged

OCPBUGS-45214: Add groupsnapshot tests #2155

merged 2 commits into from
Feb 28, 2025

Conversation

jsafrane
Copy link

@jsafrane jsafrane commented Dec 6, 2024 •
edited
Loading

Add e2e test for volume group snapshots.

There are several commits:

  • Upstream 126326 - adds the e2e tests. Already part of Kubernetes 1.32, but we still have 1.31 in o/k
  • Upstream 128972 - updates the tests for breaking changes in the new external-snapshotter. This is needed even with 1.32 in o/k.
  • Carry: Regenerate test annotations

I prepared a PR to update Fabio's ongoing rebase to 1.32: bertinatto#4

@openshift-ci-robot openshift-ci-robot added the backports/unvalidated-commits Indicates that not all commits come to merged upstream PRs. label Dec 6, 2024
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 6, 2024
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Dec 6, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci-robot
Copy link

@jsafrane: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

  • a027a96|128972: does not specify an upstream backport in the commit message
  • a21f7d6|: does not specify an upstream backport in the commit message

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

jsafrane added a commit to jsafrane/origin that referenced this pull request Dec 6, 2024
@jsafrane
Update k/k from openshift/kubernetes#2155
21b4a2d
@jsafrane jsafrane mentioned this pull request Dec 6, 2024
Closed
@gnufied
Copy link
Member

gnufied commented Dec 6, 2024

Once 1.32 rebase lands we don't need kubernetes#126326 right?

@jsafrane
Copy link
Author

Yes, kubernetes#126326 is only for Kubernetes 1.31

@jsafrane jsafrane force-pushed the 4.18-add-groupsnapshot branch from a027a96 to 0711f08 Compare December 16, 2024 13:55
jsafrane added a commit to jsafrane/origin that referenced this pull request Dec 16, 2024
@jsafrane
Update k/k from openshift/kubernetes#2155
ae164e6
@openshift-ci-robot
Copy link

@jsafrane: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

@jsafrane jsafrane force-pushed the 4.18-add-groupsnapshot branch from 0711f08 to 33cedfd Compare December 16, 2024 17:22
@openshift-ci-robot
Copy link

@jsafrane: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

jsafrane added a commit to jsafrane/origin that referenced this pull request Dec 16, 2024
@jsafrane
Update k/k from openshift/kubernetes#2155
a429a1c
@duanwei33 duanwei33 mentioned this pull request Dec 17, 2024
Merged
@openshift-ci-robot
Copy link

@jsafrane: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

@jsafrane jsafrane force-pushed the 4.18-add-groupsnapshot branch from f09528f to 0279cb6 Compare January 2, 2025 14:24
@openshift-ci-robot
Copy link

@jsafrane: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

jsafrane added a commit to jsafrane/origin that referenced this pull request Jan 2, 2025
@jsafrane
Update k/k from openshift/kubernetes#2155
3d16509
@jsafrane jsafrane changed the title WIP: add groupsnapshot tests Add groupsnapshot tests Jan 6, 2025
@jsafrane jsafrane force-pushed the 4.18-add-groupsnapshot branch from 0279cb6 to fbe715a Compare January 6, 2025 09:18
@openshift-ci-robot
Copy link

@jsafrane: the contents of this pull request could not be automatically validated.

The following commits are valid:

The following commits could not be validated and must be approved by a top-level approver:

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

@jsafrane jsafrane marked this pull request as ready for review January 6, 2025 09:18
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 6, 2025
@jsafrane jsafrane changed the title Add groupsnapshot tests STOR-2120: Add groupsnapshot tests Jan 6, 2025
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jan 6, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 6, 2025 •
edited by openshift-ci bot
Loading

@jsafrane: This pull request references STOR-2120 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target either version "4.19." or "openshift-4.19.", but it targets "openshift-4.18" instead.

In response to this:

Add e2e test for volume group snapshots.

There are several commits:

  • Upstream 126326 + 128972 that add the e2e test. Only the second commit is needed in Kubernetes 1.32, but we still have 1.31 in o/k.
  • Regenerate test annotations.
  • In the last commit, force enable --feature-gates=CSIVolumeGroupSnapshot=true in csi-driver-hostpath test yaml manifests. This feature is off by default upstream, but we want it on by default in OCP in e2e tests. We will need to carry this until it's enabled upstream, probably for a few releases. This affects only e2e test manifests.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 6, 2025 •
edited by openshift-ci bot
Loading

@jsafrane: This pull request references STOR-2120 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target either version "4.19." or "openshift-4.19.", but it targets "openshift-4.18" instead.

In response to this:

Add e2e test for volume group snapshots.

There are several commits:

  • Upstream 126326 - adds the e2e tests. Already part of Kubernetes 1.32, but we still have 1.31 in o/k
  • Upstream 128972 - updates the tests for breaking changes in the new external-snapshotter. This is needed even with 1.32 in o/k.
  • Carry: Regenerate test annotations.
  • Carry: force enable --feature-gates=CSIVolumeGroupSnapshot=true in csi-driver-hostpath test yaml manifests. This feature is off by default upstream, but we want it on by default in OCP in e2e tests. We will need to carry this until it's enabled upstream, probably for a few releases.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@jsafrane
Copy link
Author

jsafrane commented Jan 6, 2025

/test

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Jan 6, 2025

@jsafrane: The /test command needs one or more targets.
The following commands are available to trigger required jobs:

/test artifacts

/test configmap-scale

/test e2e-aws-crun-wasm

/test e2e-aws-jenkins

/test e2e-aws-ovn-cgroupsv2

/test e2e-aws-ovn-crun

/test e2e-aws-ovn-downgrade

/test e2e-aws-ovn-fips

/test e2e-aws-ovn-runc

/test e2e-aws-ovn-serial

/test e2e-aws-ovn-upgrade

/test e2e-azure-ovn-upgrade

/test e2e-gcp

/test e2e-gcp-ovn-upgrade

/test images

/test integration

/test k8s-e2e-conformance-aws

/test k8s-e2e-gcp-ovn

/test k8s-e2e-gcp-serial

/test perfscale-control-plane-6nodes

/test unit

/test verify

/test verify-commits

The following commands are available to trigger optional jobs:

/test e2e-agnostic-ovn-cmd

/test e2e-aws

/test e2e-aws-csi

/test e2e-aws-disruptive

/test e2e-aws-ovn

/test e2e-aws-single-node

/test e2e-azure

/test e2e-metal-ipi-ovn-dualstack

/test e2e-metal-ipi-ovn-ipv6

/test e2e-openstack

/test e2e-openstack-csi-cinder

/test e2e-openstack-csi-manila

/test e2e-vsphere

/test k8s-e2e-aws

/test k8s-e2e-aws-ovn-serial

/test k8s-e2e-gcp-five-control-plane-replicas

/test okd-scos-e2e-aws-ovn

/test okd-scos-images

Use /test all to run the following jobs that were automatically triggered:

pull-ci-openshift-kubernetes-master-artifacts

pull-ci-openshift-kubernetes-master-e2e-agnostic-ovn-cmd

pull-ci-openshift-kubernetes-master-e2e-aws-crun-wasm

pull-ci-openshift-kubernetes-master-e2e-aws-csi

pull-ci-openshift-kubernetes-master-e2e-aws-ovn-cgroupsv2

pull-ci-openshift-kubernetes-master-e2e-aws-ovn-crun

pull-ci-openshift-kubernetes-master-e2e-aws-ovn-fips

pull-ci-openshift-kubernetes-master-e2e-aws-ovn-runc

pull-ci-openshift-kubernetes-master-e2e-aws-ovn-serial

pull-ci-openshift-kubernetes-master-e2e-gcp

pull-ci-openshift-kubernetes-master-e2e-gcp-ovn-upgrade

pull-ci-openshift-kubernetes-master-images

pull-ci-openshift-kubernetes-master-integration

pull-ci-openshift-kubernetes-master-k8s-e2e-aws-ovn-serial

pull-ci-openshift-kubernetes-master-k8s-e2e-conformance-aws

pull-ci-openshift-kubernetes-master-k8s-e2e-gcp-ovn

pull-ci-openshift-kubernetes-master-k8s-e2e-gcp-serial

pull-ci-openshift-kubernetes-master-okd-scos-e2e-aws-ovn

pull-ci-openshift-kubernetes-master-unit

pull-ci-openshift-kubernetes-master-verify

pull-ci-openshift-kubernetes-master-verify-commits

In response to this:

/test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@jsafrane jsafrane force-pushed the 4.18-add-groupsnapshot branch from 298bbf5 to 613b73f Compare February 26, 2025 14:10
@openshift-ci-robot
Copy link

@jsafrane: the contents of this pull request could not be automatically validated.

The following commits are valid:

The following commits could not be validated and must be approved by a top-level approver:

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

@bertinatto
Copy link
Member

@bertinatto: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

* periodic-ci-openshift-release-master-nightly-4.19-e2e-metal-ipi-ovn-bm

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/39d28ab0-f374-11ef-9d63-d8eb1464411e-0

The job above is green.

/remove-label backports/unvalidated-commits
/label backports/validated-commits
/lgtm

@openshift-ci openshift-ci bot added backports/validated-commits Indicates that all commits come to merged upstream PRs. and removed backports/unvalidated-commits Indicates that not all commits come to merged upstream PRs. labels Feb 26, 2025
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 26, 2025
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Feb 26, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bertinatto, jsafrane

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 26, 2025
@bertinatto bertinatto changed the title OCPBUGS-45214: STOR-2285: Add groupsnapshot tests OCPBUGS-45214: Add groupsnapshot tests Feb 26, 2025
@bertinatto
Copy link
Member

/jira refresh

@openshift-ci-robot openshift-ci-robot added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label Feb 26, 2025
@openshift-ci-robot
Copy link

@bertinatto: This pull request references Jira Issue OCPBUGS-45214, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.19.0) matches configured target version for branch (4.19.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira ([email protected]), skipping review request.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot removed the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Feb 26, 2025
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD efd4d77 and 2 for PR HEAD 613b73f in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 0d5e184 and 1 for PR HEAD 613b73f in total

@jsafrane
Copy link
Author

/retest-required

2 similar comments
@bertinatto
Copy link
Member

/retest-required

@bertinatto
Copy link
Member

/retest-required

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 0d5e184 and 2 for PR HEAD 613b73f in total

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Feb 27, 2025 •
edited
Loading

@jsafrane: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-agnostic-ovn-cmd 613b73f link false /test e2e-agnostic-ovn-cmd

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 0d5e184 and 2 for PR HEAD 613b73f in total

@openshift-merge-bot openshift-merge-bot bot merged commit c3a6a36 into openshift:master Feb 28, 2025
22 of 23 checks passed
@openshift-ci-robot
Copy link

@jsafrane: Jira Issue OCPBUGS-45214: Some pull requests linked via external trackers have merged:

The following pull requests linked via external trackers have not merged:

These pull request must merge or be unlinked from the Jira bug in order for it to move to the next state. Once unlinked, request a bug refresh with /jira refresh.

Jira Issue OCPBUGS-45214 has not been moved to the MODIFIED state.

In response to this:

Add e2e test for volume group snapshots.

There are several commits:

  • Upstream 126326 - adds the e2e tests. Already part of Kubernetes 1.32, but we still have 1.31 in o/k
  • Upstream 128972 - updates the tests for breaking changes in the new external-snapshotter. This is needed even with 1.32 in o/k.
  • Carry: Regenerate test annotations

I prepared a PR to update Fabio's ongoing rebase to 1.32: bertinatto#4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-bot
Copy link

[ART PR BUILD NOTIFIER]

Distgit: openshift-enterprise-pod
This PR has been included in build openshift-enterprise-pod-container-v4.19.0-202502280209.p0.gc3a6a36.assembly.stream.el9.
All builds following this will include this PR.

@openshift-bot
Copy link

[ART PR BUILD NOTIFIER]

Distgit: openshift-enterprise-hyperkube
This PR has been included in build openshift-enterprise-hyperkube-container-v4.19.0-202502280209.p0.gc3a6a36.assembly.stream.el9.
All builds following this will include this PR.

@openshift-bot
Copy link

[ART PR BUILD NOTIFIER]

Distgit: kube-proxy
This PR has been included in build kube-proxy-container-v4.19.0-202502280209.p0.gc3a6a36.assembly.stream.el9.
All builds following this will include this PR.

@openshift-bot
Copy link

[ART PR BUILD NOTIFIER]

Distgit: ose-installer-kube-apiserver-artifacts
This PR has been included in build ose-installer-kube-apiserver-artifacts-container-v4.19.0-202502280209.p0.gc3a6a36.assembly.stream.el9.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@bertinatto bertinatto

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. backports/validated-commits Indicates that all commits come to merged upstream PRs. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@jsafrane @openshift-ci-robot @gnufied @bertinatto @openshift-bot